From: David Turner <dturner@twopensource.com>
To: git@vger.kernel.org, pclouds@gmail.com, aevarb@gmail.com,
jeffhost@microsoft.com
Subject: [PATCH v3 05/16] daemonize(): set a flag before exiting the main process
Date: Wed, 6 Apr 2016 18:11:51 -0400 [thread overview]
Message-ID: <1459980722-4836-6-git-send-email-dturner@twopensource.com> (raw)
In-Reply-To: <1459980722-4836-1-git-send-email-dturner@twopensource.com>
From: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
This allows signal handlers and atexit functions to realize this
situation and not clean up.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
builtin/gc.c | 2 +-
cache.h | 2 +-
daemon.c | 2 +-
setup.c | 4 +++-
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/builtin/gc.c b/builtin/gc.c
index c583aad..37180de 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -385,7 +385,7 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
* failure to daemonize is ok, we'll continue
* in foreground
*/
- daemonized = !daemonize();
+ daemonized = !daemonize(NULL);
}
} else
add_repack_all_option();
diff --git a/cache.h b/cache.h
index 4b678e9..0aeb994 100644
--- a/cache.h
+++ b/cache.h
@@ -530,7 +530,7 @@ extern int set_git_dir_init(const char *git_dir, const char *real_git_dir, int);
extern int init_db(const char *template_dir, unsigned int flags);
extern void sanitize_stdfds(void);
-extern int daemonize(void);
+extern int daemonize(int *);
#define alloc_nr(x) (((x)+16)*3/2)
diff --git a/daemon.c b/daemon.c
index 8d45c33..a5cf954 100644
--- a/daemon.c
+++ b/daemon.c
@@ -1365,7 +1365,7 @@ int main(int argc, char **argv)
return execute();
if (detach) {
- if (daemonize())
+ if (daemonize(NULL))
die("--detach not supported on this platform");
} else
sanitize_stdfds();
diff --git a/setup.c b/setup.c
index de1a2a7..9adf13f 100644
--- a/setup.c
+++ b/setup.c
@@ -1017,7 +1017,7 @@ void sanitize_stdfds(void)
close(fd);
}
-int daemonize(void)
+int daemonize(int *daemonized)
{
#ifdef NO_POSIX_GOODIES
errno = ENOSYS;
@@ -1029,6 +1029,8 @@ int daemonize(void)
case -1:
die_errno("fork failed");
default:
+ if (daemonized)
+ *daemonized = 1;
exit(0);
}
if (setsid() == -1)
--
2.4.2.767.g62658d5-twtrsrc
next prev parent reply other threads:[~2016-04-06 22:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 22:11 [PATCH v3 00/16] index-helper, watchman David Turner
2016-04-06 22:11 ` [PATCH v3 01/16] read-cache.c: fix constness of verify_hdr() David Turner
2016-04-06 22:11 ` [PATCH v3 02/16] read-cache: allow to keep mmap'd memory after reading David Turner
2016-04-06 22:11 ` [PATCH v3 03/16] index-helper: new daemon for caching index and related stuff David Turner
2016-04-07 6:21 ` Johannes Sixt
2016-04-07 14:14 ` Johannes Schindelin
2016-04-07 18:47 ` David Turner
2016-04-08 14:17 ` Johannes Schindelin
2016-04-08 11:26 ` Duy Nguyen
2016-04-08 22:16 ` David Turner
2016-04-11 23:27 ` David Turner
2016-04-12 9:40 ` Duy Nguyen
2016-04-12 17:28 ` David Turner
2016-04-12 18:05 ` Junio C Hamano
2016-04-13 0:32 ` David Turner
2016-04-14 10:43 ` Duy Nguyen
2016-04-14 18:12 ` Junio C Hamano
2016-04-14 18:20 ` David Turner
2016-04-15 0:16 ` Duy Nguyen
2016-04-15 1:31 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 04/16] index-helper: add --strict David Turner
2016-04-06 22:11 ` David Turner [this message]
2016-04-06 22:11 ` [PATCH v3 06/16] index-helper: add --detach David Turner
2016-04-06 22:11 ` [PATCH v3 07/16] read-cache: add watchman 'WAMA' extension David Turner
2016-04-06 22:11 ` [PATCH v3 08/16] Add watchman support to reduce index refresh cost David Turner
2016-04-06 22:11 ` [PATCH v3 09/16] index-helper: use watchman to avoid refreshing index with lstat() David Turner
2016-04-07 22:47 ` Junio C Hamano
2016-04-07 22:52 ` Junio C Hamano
2016-04-08 0:14 ` David Turner
2016-04-08 6:03 ` Junio C Hamano
2016-04-06 22:11 ` [PATCH v3 10/16] update-index: enable/disable watchman support David Turner
2016-04-06 22:11 ` [PATCH v3 11/16] unpack-trees: preserve index extensions David Turner
2016-04-06 22:11 ` [PATCH v3 12/16] index-helper: kill mode David Turner
2016-04-06 22:11 ` [PATCH v3 13/16] index-helper: don't run if already running David Turner
2016-04-06 22:12 ` [PATCH v3 14/16] index-helper: autorun mode David Turner
2016-04-06 22:12 ` [PATCH v3 15/16] index-helper: optionally automatically run David Turner
2016-04-06 22:12 ` [PATCH v3 16/16] read-cache: config for waiting for index-helper David Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459980722-4836-6-git-send-email-dturner@twopensource.com \
--to=dturner@twopensource.com \
--cc=aevarb@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.