From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Koul, Vinod) Date: Wed, 6 Apr 2016 22:13:59 +0000 Subject: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan In-Reply-To: <57057C9B.8040804@metafoo.de> References: <1459959335-24083-1-git-send-email-appanad@xilinx.com> <1459959335-24083-2-git-send-email-appanad@xilinx.com> <20160406162022.GS23198@xsjsorenbubuntu> <57057C9B.8040804@metafoo.de> Message-ID: <1459980839.3136.87.camel@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > +++ > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > @@ -24,8 +24,8 @@ Optional properties: > > > > {3}, flush s2mm channel > > > > > > > > Required child node properties: > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel" > > > > or > > > > - "xlnx,axi-vdma-s2mm-channel". > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s-channel" > > > > or > > > > + "xlnx,axi-dma-s2mm-channel". > > > > > > This change is not backwards compatible and breaks every user of > > > the current > > > binding. > > > > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave- > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa > > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of > > the above properties. That patch changes driver from vdma to dma. It does not change property name! > > The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to > > xilinx_dma) already got applied in the dma-next tree. > > That's why sent this patch to sync with the current driver I mean > > latest driver. > > The correct solution for this is to revert that part of the change > ASAP, > since, as Soeren pointed out, it breaks all existing users. No the commit applied is only the name changes inside the driver. They don't break anything yet. IIUC this patch breaks not the applied one.. Thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Koul, Vinod" Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Date: Wed, 6 Apr 2016 22:13:59 +0000 Message-ID: <1459980839.3136.87.camel@intel.com> References: <1459959335-24083-1-git-send-email-appanad@xilinx.com> <1459959335-24083-2-git-send-email-appanad@xilinx.com> <20160406162022.GS23198@xsjsorenbubuntu> <57057C9B.8040804@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <57057C9B.8040804-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Content-Language: en-US Content-ID: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org" , "appana.durga.rao-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "sorenb-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "pawel.moll-5wv7dgnIgG8@public.gmane.org" , "anirudh-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "luis-HiykPkW1eAzzDCI4PIEvbQC/G2K4zDHf@public.gmane.org" , "moritz.fischer-+aYTwkv1SeIAvxtiuMwx3w@public.gmane.org" , "michals-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "svemula-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Williams, Dan J" , "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org" List-Id: devicetree@vger.kernel.org T24gV2VkLCAyMDE2LTA0LTA2IGF0IDIzOjE2ICswMjAwLCBMYXJzLVBldGVyIENsYXVzZW4gd3Jv dGU6DQo+IE9uIDA0LzA2LzIwMTYgMDY6MjUgUE0sIEFwcGFuYSBEdXJnYSBLZWRhcmVzd2FyYSBS YW8gd3JvdGU6DQo+ID4gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZG1hL3hp bGlueC94aWxpbnhfdmRtYS50eHQNCj4gPiA+ID4gKysrDQo+ID4gPiA+IGIvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS94aWxpbngveGlsaW54X3ZkbWEudHh0DQo+ID4gPiA+ IEBAIC0yNCw4ICsyNCw4IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6DQo+ID4gPiA+ICAJezN9LCBm bHVzaCBzMm1tIGNoYW5uZWwNCj4gPiA+ID4gDQo+ID4gPiA+ICBSZXF1aXJlZCBjaGlsZCBub2Rl IHByb3BlcnRpZXM6DQo+ID4gPiA+IC0tIGNvbXBhdGlibGU6IEl0IHNob3VsZCBiZSBlaXRoZXIg InhsbngsYXhpLXZkbWEtbW0ycy1jaGFubmVsIg0KPiA+ID4gPiBvcg0KPiA+ID4gPiAtCSJ4bG54 LGF4aS12ZG1hLXMybW0tY2hhbm5lbCIuDQo+ID4gPiA+ICstIGNvbXBhdGlibGU6IEl0IHNob3Vs ZCBiZSBlaXRoZXIgInhsbngsYXhpLWRtYS1tbTJzLWNoYW5uZWwiDQo+ID4gPiA+IG9yDQo+ID4g PiA+ICsJInhsbngsYXhpLWRtYS1zMm1tLWNoYW5uZWwiLg0KPiA+ID4gDQo+ID4gPiBUaGlzIGNo YW5nZSBpcyBub3QgYmFja3dhcmRzIGNvbXBhdGlibGUgYW5kIGJyZWFrcyBldmVyeSB1c2VyIG9m DQo+ID4gPiB0aGUgY3VycmVudA0KPiA+ID4gYmluZGluZy4NCj4gPiANCj4gPiBUaGlzIGNvbW1p dCBodHRwOi8vZ2l0Lmtlcm5lbC5vcmcvY2dpdC9saW51eC9rZXJuZWwvZ2l0L3Zrb3VsL3NsYXZl LQ0KPiA+IGRtYS5naXQvY29tbWl0Lz9oPW5leHQmaWQ9OGU2NmU3ZDY4MmIwNGY3MTQxZjhhZTY2 NjkwOGM4ZGNkN2ZjMGJmYSANCj4gPiBSZW5hbWVzIHhpbGlueF92ZG1hXyBwcmVmaXggdG8geGls aW54X2RtYSB3aGljaCBpbmNsdWRlcyByZW5hbWluZyBvZg0KPiA+IHRoZSBhYm92ZSBwcm9wZXJ0 aWVzLg0KDQpUaGF0IHBhdGNoIGNoYW5nZXMgZHJpdmVyIGZyb20gdmRtYSB0byBkbWEuIEl0IGRv ZXMgbm90IGNoYW5nZSBwcm9wZXJ0eQ0KbmFtZSENCg0KPiA+IFRoZSBwYXRjaCAoZG1hZW5naW5l OiB2ZG1hOiBSZW5hbWUgeGlsaW54X3ZkbWFfIHByZWZpeCB0bw0KPiA+IHhpbGlueF9kbWEpIGFs cmVhZHkgZ290IGFwcGxpZWQgaW4gdGhlIGRtYS1uZXh0IHRyZWUuDQo+ID4gVGhhdCdzIHdoeSBz ZW50IHRoaXMgcGF0Y2ggdG8gc3luYyB3aXRoIHRoZSBjdXJyZW50IGRyaXZlciBJIG1lYW4NCj4g PiBsYXRlc3QgZHJpdmVyLg0KPiANCj4gVGhlIGNvcnJlY3Qgc29sdXRpb24gZm9yIHRoaXMgaXMg dG8gcmV2ZXJ0IHRoYXQgcGFydCBvZiB0aGUgY2hhbmdlDQo+IEFTQVAsDQo+IHNpbmNlLCBhcyBT b2VyZW4gcG9pbnRlZCBvdXQsIGl0IGJyZWFrcyBhbGwgZXhpc3RpbmcgdXNlcnMuDQoNCk5vIHRo ZSBjb21taXQgYXBwbGllZCBpcyBvbmx5IHRoZSBuYW1lIGNoYW5nZXMgaW5zaWRlIHRoZSBkcml2 ZXIuIFRoZXkNCmRvbid0IGJyZWFrIGFueXRoaW5nIHlldC4gSUlVQyB0aGlzIHBhdGNoIGJyZWFr cyBub3QgdGhlIGFwcGxpZWQgb25lLi4NCg0KVGhhbmtzDQotLSANCn5WaW5vZA0K -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754498AbcDFWOI (ORCPT ); Wed, 6 Apr 2016 18:14:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:5879 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753521AbcDFWOF (ORCPT ); Wed, 6 Apr 2016 18:14:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="scan'208";a="927017843" From: "Koul, Vinod" To: "lars@metafoo.de" , "appana.durga.rao@xilinx.com" , "sorenb@xilinx.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "anirudh@xilinx.com" , "luis@debethencourt.com" , "moritz.fischer@ettus.com" , "michals@xilinx.com" , "svemula@xilinx.com" , "devicetree@vger.kernel.org" , "Williams, Dan J" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "laurent.pinchart@ideasonboard.com" Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Thread-Topic: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Thread-Index: AQHRkB+tMNON9LaHQ029m8TpSbwCX598w/wAgAABkQCAAFEWgIAAECaA Date: Wed, 6 Apr 2016 22:13:59 +0000 Message-ID: <1459980839.3136.87.camel@intel.com> References: <1459959335-24083-1-git-send-email-appanad@xilinx.com> <1459959335-24083-2-git-send-email-appanad@xilinx.com> <20160406162022.GS23198@xsjsorenbubuntu> <57057C9B.8040804@metafoo.de> In-Reply-To: <57057C9B.8040804@metafoo.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.180.190] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u36MEE9b005688 On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > +++ > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > @@ -24,8 +24,8 @@ Optional properties: > > > > {3}, flush s2mm channel > > > > > > > > Required child node properties: > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel" > > > > or > > > > - "xlnx,axi-vdma-s2mm-channel". > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s-channel" > > > > or > > > > + "xlnx,axi-dma-s2mm-channel". > > > > > > This change is not backwards compatible and breaks every user of > > > the current > > > binding. > > > > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave- > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa > > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of > > the above properties. That patch changes driver from vdma to dma. It does not change property name! > > The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to > > xilinx_dma) already got applied in the dma-next tree. > > That's why sent this patch to sync with the current driver I mean > > latest driver. > > The correct solution for this is to revert that part of the change > ASAP, > since, as Soeren pointed out, it breaks all existing users. No the commit applied is only the name changes inside the driver. They don't break anything yet. IIUC this patch breaks not the applied one.. Thanks -- ~Vinod