From: "Koul, Vinod" <vinod.koul@intel.com>
To: "ckeepax@opensource.wolfsonmicro.com"
<ckeepax@opensource.wolfsonmicro.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH v2 2/6] ALSA: compress: Add function to indicate the stream has gone bad
Date: Thu, 7 Apr 2016 00:40:03 +0000 [thread overview]
Message-ID: <1459989603.3136.95.camel@intel.com> (raw)
In-Reply-To: <1459938115-25456-3-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Wed, 2016-04-06 at 11:21 +0100, Charles Keepax wrote:
> +int snd_compr_stop_xrun(struct snd_compr_stream *stream)
> +{
> + if (stream->runtime->state == SNDRV_PCM_STATE_XRUN)
> + return 0;
> +
> + stream->runtime->state = SNDRV_PCM_STATE_XRUN;
> +
> + queue_delayed_work(system_power_efficient_wq, &stream
> ->xrun_work, 0);
why do we want to do this in workqueue and not stop the compress stream
immediately.
Also if we do this, then why should pointer return error?
--
~Vinod
next prev parent reply other threads:[~2016-04-07 0:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 10:21 [PATCH v2 0/6] Propagate errors out from compressed streams Charles Keepax
2016-04-06 10:21 ` [PATCH v2 1/6] ASoC: compress: Pass error out of soc_compr_pointer Charles Keepax
2016-04-06 10:21 ` [PATCH v2 2/6] ALSA: compress: Add function to indicate the stream has gone bad Charles Keepax
2016-04-07 0:40 ` Koul, Vinod [this message]
2016-04-07 8:28 ` Charles Keepax
2016-04-07 23:07 ` Koul, Vinod
2016-04-08 4:49 ` Takashi Iwai
2016-04-08 10:58 ` Charles Keepax
2016-04-06 10:21 ` [PATCH v2 3/6] ALSA: compress: Replace complex if statement with switch Charles Keepax
2016-04-06 10:21 ` [PATCH v2 4/6] ASoC: wm_adsp: Factor out fetching of stream errors from the DSP Charles Keepax
2016-04-06 17:19 ` Applied "ASoC: wm_adsp: Factor out fetching of stream errors from the DSP" to the asoc tree Mark Brown
2016-04-06 10:21 ` [PATCH v2 5/6] ASoC: wm_adsp: Improve DSP error handling Charles Keepax
2016-04-06 17:19 ` Applied "ASoC: wm_adsp: Improve DSP error handling" to the asoc tree Mark Brown
2016-04-06 10:21 ` [PATCH v2 6/6] ASoC: wm_adsp: Use new snd_compr_stop_xrun to signal stream failure Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459989603.3136.95.camel@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.