From: Joe Perches <joe@perches.com>
To: "Haim, Maya" <merez@qti.qualcomm.com>,
qca_merez <qca_merez@qca.qualcomm.com>,
Kalle Valo <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
wil6210 <wil6210@qca.qualcomm.com>
Subject: Re: [PATCH 1/7] wil6210: add function name to wil log macros
Date: Thu, 07 Apr 2016 09:05:58 -0700 [thread overview]
Message-ID: <1460045158.6715.93.camel@perches.com> (raw)
In-Reply-To: <bc848beb5cd947f9905b55983a76b6f5@euamsexm01a.eu.qualcomm.com>
On Thu, 2016-04-07 at 15:04 +0000, Haim, Maya wrote:
> On 4/6/2016 10:19 AM, Joe Perches wrote:
> > On Tue, 2016-04-05 at 14:24 +0300, Maya Erez wrote:
> > > Add __func__ to all wil log macros for easier debugging.
> > I think this is unnecessary and merely bloats code size.
> > For all the _dbg calls, dynamic debug can add function names if
> > desired.
> >
> > If really desired, I suggest changing the logging functions to use
> > "%ps and __builtin_return_address(0)
[]
> implemented it with __builtin_return_address(0) at first but found its format less readable (e.g. wil_start_xmit+0x58/0x7e8).
> I agree that using __builtin_return_address(0) simplifies the code and I'm OK with your suggestion to use it.
I believe you must have used %pS and not %ps
See: Documentation/printk-formats.txt
Symbols/Function Pointers:
%pS versatile_init+0x0/0x110
%ps versatile_init
next prev parent reply other threads:[~2016-04-07 16:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 11:24 [PATCH 0/7] wil6210 patches Maya Erez
2016-04-05 11:24 ` [PATCH 1/7] wil6210: add function name to wil log macros Maya Erez
2016-04-06 7:19 ` Joe Perches
2016-04-07 15:04 ` Haim, Maya
2016-04-07 15:41 ` Kalle Valo
2016-04-12 7:45 ` Haim, Maya
2016-04-15 12:28 ` Kalle Valo
2016-04-25 9:08 ` merez
2016-04-07 16:05 ` Joe Perches [this message]
2016-04-05 11:24 ` [PATCH 2/7] wil6210: support regular scan on P2P_DEVICE interface Maya Erez
2016-04-05 11:24 ` [PATCH 3/7] wil6210: change RX_HTRSH interrupt print level to debug Maya Erez
2016-04-05 11:24 ` [PATCH 4/7] wil6210: print debug message when transmitting while disconnected Maya Erez
2016-04-06 7:22 ` Joe Perches
2016-04-10 19:17 ` qca_merez
2016-04-11 2:30 ` Joe Perches
2016-04-25 13:30 ` merez
2016-04-05 11:24 ` [PATCH 5/7] wil6210: unmask RX_HTRSH interrupt only when connected Maya Erez
2016-04-05 11:24 ` [PATCH 6/7] wil6210: prevent deep sleep of 60G device in critical paths Maya Erez
2016-04-05 11:24 ` [PATCH 7/7] wil6210: add support for device led configuration Maya Erez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460045158.6715.93.camel@perches.com \
--to=joe@perches.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@qti.qualcomm.com \
--cc=qca_merez@qca.qualcomm.com \
--cc=wil6210@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.