From: Rik van Riel <riel@redhat.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
aarcange@redhat.com, iamjoonsoo.kim@lge.com,
linux-kernel@vger.kernel.org, mgorman@suse.de,
rientjes@google.com, vbabka@suse.cz,
aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org,
mhocko@suse.cz, boaz@plexistor.com
Subject: Re: [PATCH v5 2/2] mm, thp: avoid unnecessary swapin in khugepaged
Date: Thu, 07 Apr 2016 15:39:05 -0400 [thread overview]
Message-ID: <1460057945.25336.0.camel@redhat.com> (raw)
In-Reply-To: <20160407185854.GO2258@uranus.lan>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Thu, 2016-04-07 at 21:58 +0300, Cyrill Gorcunov wrote:
> On Thu, Apr 07, 2016 at 08:28:01PM +0300, Ebru Akagunduz wrote:
> ...
> >
> > + swap = get_mm_counter(mm, MM_SWAPENTS);
> > + curr_allocstall = sum_vm_event(ALLOCSTALL);
> > + /*
> > + * When system under pressure, don't swapin readahead.
> > + * So that avoid unnecessary resource consuming.
> > + */
> > + if (allocstall == curr_allocstall && swap !=)
> > + __collapse_huge_page_swapin(mm, vma, address,
> > pmd);
> This !=) looks like someone got fun ;)
Looks like someone sent out emails before refreshing the
patch, which is a such an easy mistake to make I must have
done it a dozen times by now :)
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-07 19:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 17:24 [PATCH v5 0/2] mm, thp: Fix unnecessarry resource consuming in swapin Ebru Akagunduz
2016-04-07 17:24 ` Ebru Akagunduz
2016-04-07 17:26 ` [PATCH v5 1/2] mm, vmstat: calculate particular vm event Ebru Akagunduz
2016-04-07 17:26 ` Ebru Akagunduz
2016-04-07 20:15 ` Christoph Lameter
2016-04-07 20:15 ` Christoph Lameter
2016-04-07 17:28 ` [PATCH v5 2/2] mm, thp: avoid unnecessary swapin in khugepaged Ebru Akagunduz
2016-04-07 17:28 ` Ebru Akagunduz
2016-04-07 17:34 ` Rik van Riel
2016-04-07 17:39 ` kbuild test robot
2016-04-07 17:39 ` kbuild test robot
2016-04-07 17:48 ` kbuild test robot
2016-04-07 17:48 ` kbuild test robot
2016-04-07 18:58 ` Cyrill Gorcunov
2016-04-07 18:58 ` Cyrill Gorcunov
2016-04-07 19:39 ` Rik van Riel [this message]
2016-04-07 19:47 ` Cyrill Gorcunov
2016-04-07 19:47 ` Cyrill Gorcunov
2016-04-07 20:11 ` Ebru Akagunduz
2016-04-07 20:11 ` Ebru Akagunduz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460057945.25336.0.camel@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=boaz@plexistor.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.