From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757499AbcDGUWF (ORCPT ); Thu, 7 Apr 2016 16:22:05 -0400 Received: from smtprelay0220.hostedemail.com ([216.40.44.220]:45566 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753854AbcDGUWD (ORCPT ); Thu, 7 Apr 2016 16:22:03 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:967:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2691:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6119:7903:8985:9010:9025:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12517:12519:12555:12663:12679:12740:13069:13255:13311:13357:13439:13894:14181:14659:14721:21080:21324:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: pull82_4ba2479cb8031 X-Filterd-Recvd-Size: 2223 Message-ID: <1460060518.1800.8.camel@perches.com> Subject: Re: [PATCH 2/9] rxrpc: Disable a debugging statement that has been left enabled. From: Joe Perches To: David Howells Cc: linux-afs@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 07 Apr 2016 13:21:58 -0700 In-Reply-To: <981.1460058224@warthog.procyon.org.uk> References: <1460049545.6715.98.camel@perches.com> <1460046677.6715.95.camel@perches.com> <20160407162256.21283.47849.stgit@warthog.procyon.org.uk> <20160407162309.21283.11482.stgit@warthog.procyon.org.uk> <24286.1460048722@warthog.procyon.org.uk> <981.1460058224@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-04-07 at 20:43 +0100, David Howells wrote: > Joe Perches wrote: > > > Joe Perches wrote: > > > > It might be better to remove kenter and _enter > > > > altogether and use function tracing instead. > > > Possibly - but not at this time. > > Swell. > I didn't say I wouldn't do it - it's just that I'm trying to fix other stuff > at the moment and don't particularly want to add that to the list just now. > kenter, _enter and co. are serving me very well. No worries, I didn't mean to imply you wouldn't. It's your code, do what and when you want. > > > Besides, isn't the function tracing log lost > > > if the machine crashes? > > I believe yes, but would it matter? > Let's see...  If the machine panics whilst I'm developing stuff (quite likely > if something goes wrong in BH context), how do I get at the function tracing > log to find out why it panicked if the log is then lost?  With the serial > console, at least I automatically capture the output of kenter and co.. But you also don't get a bunch of other useful stuff. btw: there is ftrace_dump_on_oops https://lwn.net/Articles/366796/