From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arc: Add virt_to_phys() stub
Date: Fri, 8 Apr 2016 17:08:47 +0000 [thread overview]
Message-ID: <1460135325.2839.18.camel@synopsys.com> (raw)
In-Reply-To: <5707E4EE.2010009@denx.de>
Hi Marek,
On Fri, 2016-04-08 at 19:05 +0200, Marek Vasut wrote:
> On 04/08/2016 07:00 PM, Alexey Brodkin wrote:
> >
> > Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping"
> > introduced usage of virt_to_phys() in ehci-hcd.
> >
> > Since there was no implementation of virt_to_phys() for ARC
> > compilation of the ehci-generic driver failed.
> >
> > This change adds virt_to_phys() stub for ARC so now
> > USB driver for AXS101 board could be built again.
> >
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Marek Vasut <marex@denx.de>
> > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > ---
> > ?arch/arc/include/asm/io.h | 5 +++++
> > ?1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arc/include/asm/io.h b/arch/arc/include/asm/io.h
> > index 281682c..b6f7724 100644
> > --- a/arch/arc/include/asm/io.h
> > +++ b/arch/arc/include/asm/io.h
> > @@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, void *data, int longlen)
> > ?#define setbits_8(addr, set) setbits(8, addr, set)
> > ?#define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set)
> > ?
> > +static inline phys_addr_t virt_to_phys(void *vaddr)
> > +{
> > + return (phys_addr_t)((unsigned long)vaddr);
> > +}
> > +
> > ?#endif /* __ASM_ARC_IO_H */
> >
> Sorry for breaking your arch.
That happens. No problem.
Real problem though is we still don't have autobuilder that
catches these kinds of trivial flaws.
I don't build for all arches as well before submitting patches so
before autobuilder is there we'll see more issues of that kind :)
-Alexey
next prev parent reply other threads:[~2016-04-08 17:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 17:00 [U-Boot] [PATCH] arc: Add virt_to_phys() stub Alexey Brodkin
2016-04-08 17:05 ` Marek Vasut
2016-04-08 17:08 ` Alexey Brodkin [this message]
2016-04-08 17:23 ` Marek Vasut
2016-04-08 17:26 ` Alexey Brodkin
2016-04-08 17:27 ` Marek Vasut
2016-04-11 17:25 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460135325.2839.18.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.