All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: bp@alien8.de, hpa@zytor.com, tglx@linutronix.de,
	mingo@redhat.com, rusty@rustcorp.com.au
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	luto@amacapital.net, boris.ostrovsky@oracle.com,
	david.vrabel@citrix.com, konrad.wilk@oracle.com,
	xen-devel@lists.xensource.com, lguest@lists.ozlabs.org,
	andriy.shevchenko@linux.intel.com, jlee@suse.com, glin@suse.com,
	matt@codeblueprint.co.uk, andrew.cooper3@citrix.com,
	rjw@rjwysocki.net, lenb@kernel.org, robert.moore@intel.com,
	lv.zheng@intel.com, toshi.kani@hp.com,
	linux-acpi@vger.kernel.org, kozerkov@parallels.com,
	josh@joshtriplett.org, joro@8bytes.org, tiwai@suse.de,
	"Luis R. Rodriguez" <mcgrof@kernel.org>
Subject: [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code
Date: Fri,  8 Apr 2016 16:57:45 -0700	[thread overview]
Message-ID: <1460159865-13296-1-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1460158825-13117-1-git-send-email-mcgrof@kernel.org>

This moves the ACPI specific check into the ACPI boot code,
it also takes advantage of the x86_platform.legacy.rtc which
is checked for already on the RTC initialization code. This
lets us remove the nasty #ifdefery and consolidate the checks
to use only one toggle to disable the RTC init code.

The works as RTC is initialized by device_initcall(add_rtc_cmos),
this will run late in boot on start_kernel() during rest_init(),
acpi_parse_fadt() gets called earlier during setup_arch().

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
 arch/x86/kernel/acpi/boot.c | 4 ++++
 arch/x86/kernel/rtc.c       | 8 --------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
index 8c2f1ef6ca23..8c9c2bdba092 100644
--- a/arch/x86/kernel/acpi/boot.c
+++ b/arch/x86/kernel/acpi/boot.c
@@ -913,6 +913,10 @@ late_initcall(hpet_insert_resource);
 
 static int __init acpi_parse_fadt(struct acpi_table_header *table)
 {
+	if (acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) {
+		pr_debug("ACPI: not registering RTC platform device\n");
+		x86_platform.legacy.rtc = 0;
+	}
 
 #ifdef CONFIG_X86_PM_TIMER
 	/* detect the location of the ACPI PM Timer */
diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c
index 62c48da3889d..ff4f4180fefd 100644
--- a/arch/x86/kernel/rtc.c
+++ b/arch/x86/kernel/rtc.c
@@ -189,14 +189,6 @@ static __init int add_rtc_cmos(void)
 	if (of_have_populated_dt())
 		return 0;
 
-#ifdef CONFIG_ACPI
-	if (acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC) {
-		/* This warning can likely go away again in a year or two. */
-		pr_info("ACPI: not registering RTC platform device\n");
-		return -ENODEV;
-	}
-#endif
-
 	if (!x86_platform.legacy.rtc)
 		return -ENODEV;
 
-- 
2.7.2


  parent reply	other threads:[~2016-04-08 23:57 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 23:40 [PATCH v5 00/14] x86: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 01/14] x86/boot: enumerate documentation for the x86 hardware_subarch Luis R. Rodriguez
2016-04-13  8:01   ` Ingo Molnar
2016-04-13 15:17     ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 03/14] tools/lguest: make lguest launcher use X86_SUBARCH_LGUEST explicitly Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-11  6:50   ` [Xen-devel] " Juergen Gross
2016-04-12 20:50     ` Luis R. Rodriguez
2016-04-13 22:49       ` Luis R. Rodriguez
2016-04-11 13:49   ` Boris Ostrovsky
2016-04-11 13:49     ` Boris Ostrovsky
2016-04-12 20:56     ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 05/14] x86, ACPI: move ACPI_FADT_NO_CMOS_RTC check to ACPI boot code Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 06/14] x86/init: use a platform legacy quirk for ebda Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 08/14] apm32: remove paravirt_enabled() use Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 11/14] pnpbios: replace paravirt_enabled() check with legacy device check Luis R. Rodriguez
2016-04-08 23:40   ` Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 12/14] x86, ACPI: parse ACPI_FADT_LEGACY_DEVICES Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 13/14] x86/init: rename ebda code file Luis R. Rodriguez
2016-04-08 23:40 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-11  6:51   ` [Xen-devel] " Juergen Gross
2016-04-08 23:57 ` [PATCH v5 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots Luis R. Rodriguez
2016-04-08 23:57 ` [PATCH v5 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk Luis R. Rodriguez
2016-04-08 23:57 ` Luis R. Rodriguez [this message]
2016-04-08 23:58 ` [PATCH v5 07/14] tools/lguest: force disable tboot and apm Luis R. Rodriguez
2016-04-13  8:44   ` Ingo Molnar
2016-04-13 15:45     ` Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 09/14] x86/tboot: remove paravirt_enabled() Luis R. Rodriguez
2016-04-08 23:58 ` [PATCH v5 10/14] x86/cpu/intel: remove not needed paravirt_enabled() for f00f work around Luis R. Rodriguez
2016-04-08 23:59 ` [PATCH v5 14/14] x86/paravirt: remove paravirt_enabled() Luis R. Rodriguez
2016-04-09  0:00 ` [PATCH v5 00/14] x86: " Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1460159865-13296-1-git-send-email-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=david.vrabel@citrix.com \
    --cc=glin@suse.com \
    --cc=hpa@zytor.com \
    --cc=jlee@suse.com \
    --cc=joro@8bytes.org \
    --cc=josh@joshtriplett.org \
    --cc=konrad.wilk@oracle.com \
    --cc=kozerkov@parallels.com \
    --cc=lenb@kernel.org \
    --cc=lguest@lists.ozlabs.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=lv.zheng@intel.com \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=rusty@rustcorp.com.au \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=toshi.kani@hp.com \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.