Re: cppc_cpufreq

[Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>]

On Fri, 2016-04-08 at 11:08 -0400, Ashwin Chaugule wrote:
> On 7 April 2016 at 19:50, Pandruvada, Srinivas
> <srinivas.pandruvada@intel.com> wrote:
> > Hi Ashwin,
> > 
> > I didn't see in the cppc_cpufreq.c
> > 
> > MODULE_LICENSE()
> > 
> > Is it intentional?
> 
> Not intentional. Doesn't the absence of this default to GPLv2? or is
> it required that the license be explicitly stated?
> 
You are using symbols exported using EXPORT_SYMBOL_GPL

I get following error during insmod:

[   33.400861] cppc_cpufreq: module verification failed: signature
and/or required key missing - tainting kernel
[   33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver
(err 0)
[   33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err 0)
[   33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err 0)
[   33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end
(err 0)
[   33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err 0)
[   33.400945] cppc_cpufreq: Unknown symbol
cpufreq_freq_transition_begin (err 0)
[   33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)

I had to add MODULE_LICENSE(GPL).


Thanks,
Srinivas
> 
> Thanks,
> Ashwin.