Patch "Input: powermate - fix oops with malicious USB descriptors" has been added to the 4.4-stable tree

Patch "Input: powermate - fix oops with malicious USB descriptors" has been added to the 4.4-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    Input: powermate - fix oops with malicious USB descriptors

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     input-powermate-fix-oops-with-malicious-usb-descriptors.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 9c6ba456711687b794dcf285856fc14e2c76074f Mon Sep 17 00:00:00 2001
From: Josh Boyer <jwboyer@fedoraproject.org>
Date: Mon, 14 Mar 2016 09:33:40 -0700
Subject: Input: powermate - fix oops with malicious USB descriptors

From: Josh Boyer <jwboyer@fedoraproject.org>

commit 9c6ba456711687b794dcf285856fc14e2c76074f upstream.

The powermate driver expects at least one valid USB endpoint in its
probe function.  If given malicious descriptors that specify 0 for
the number of endpoints, it will crash.  Validate the number of
endpoints on the interface before using them.

The full report for this issue can be found here:
http://seclists.org/bugtraq/2016/Mar/85

Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/input/misc/powermate.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/input/misc/powermate.c
+++ b/drivers/input/misc/powermate.c
@@ -307,6 +307,9 @@ static int powermate_probe(struct usb_in
 	int error = -ENOMEM;
 
 	interface = intf->cur_altsetting;
+	if (interface->desc.bNumEndpoints < 1)
+		return -EINVAL;
+
 	endpoint = &interface->endpoint[0].desc;
 	if (!usb_endpoint_is_int_in(endpoint))
 		return -EIO;


Patches currently in stable-queue which might be from jwboyer@fedoraproject.org are

queue-4.4/usb-serial-ftdi_sio-add-support-for-icp-das-i-756xu-devices.patch
queue-4.4/input-powermate-fix-oops-with-malicious-usb-descriptors.patch
queue-4.4/perf-tools-fix-python-extension-build.patch
queue-4.4/usb-iowarrior-fix-oops-with-malicious-usb-descriptors.patch