All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "sd: Fix discard granularity when LBPRZ=1" has been added to the 4.4-stable tree
@ 2016-04-09 23:40 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-04-09 23:40 UTC (permalink / raw)
  To: martin.petersen, bart.vanassche, emilne, gregkh, snitzer
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    sd: Fix discard granularity when LBPRZ=1

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     sd-fix-discard-granularity-when-lbprz-1.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 6540a65da90c09590897310e31993b1f6e28485a Mon Sep 17 00:00:00 2001
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Date: Sat, 5 Mar 2016 17:52:02 -0500
Subject: sd: Fix discard granularity when LBPRZ=1

From: Martin K. Petersen <martin.petersen@oracle.com>

commit 6540a65da90c09590897310e31993b1f6e28485a upstream.

Commit 397737223c59 ("sd: Make discard granularity match logical block
size when LBPRZ=1") accidentally set the granularity to one byte instead
of one logical block on devices that provide deterministic zeroes after
UNMAP.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Mike Snitzer <snitzer@redhat.com>
Reviewed-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Fixes: 397737223c59e89dca7305feb6528caef8fbef84
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/scsi/sd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -648,7 +648,7 @@ static void sd_config_discard(struct scs
 	 */
 	if (sdkp->lbprz) {
 		q->limits.discard_alignment = 0;
-		q->limits.discard_granularity = 1;
+		q->limits.discard_granularity = logical_block_size;
 	} else {
 		q->limits.discard_alignment = sdkp->unmap_alignment *
 			logical_block_size;


Patches currently in stable-queue which might be from martin.petersen@oracle.com are

queue-4.4/be2iscsi-set-the-boot_kset-pointer-to-null-in-case-of-failure.patch
queue-4.4/sg-fix-dxferp-in-from_to-case.patch
queue-4.4/aacraid-fix-memory-leak-in-aac_fib_map_free.patch
queue-4.4/scsi-storvsc-fix-srb_status_aborted-handling.patch
queue-4.4/aacraid-fix-rrq-overload.patch
queue-4.4/aacraid-set-correct-msix-count-for-eeh-recovery.patch
queue-4.4/aic7xxx-fix-queue-depth-handling.patch
queue-4.4/sd-fix-discard-granularity-when-lbprz-1.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-09 23:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-09 23:40 Patch "sd: Fix discard granularity when LBPRZ=1" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.