From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] checkpatch: Improve missing break for switch/case tests Date: Sun, 10 Apr 2016 22:04:10 -0700 Message-ID: <1460351050.1800.69.camel@perches.com> References: <570928CC.6030404@metafoo.de> <1460341582.1800.66.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtprelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by alsa0.perex.cz (Postfix) with ESMTP id 1707326153A for ; Mon, 11 Apr 2016 07:04:13 +0200 (CEST) In-Reply-To: <1460341582.1800.66.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andrew Morton , Andy Whitcroft Cc: Takashi Iwai , "alsa-devel@alsa-project.org" , Lars-Peter Clausen , LKML , "Harvey, Ryan" List-Id: alsa-devel@alsa-project.org On Sun, 2016-04-10 at 19:26 -0700, Joe Perches wrote: > The current switch/case test doesn't handle ... case labels like: > > switch (foo) { > case bar ... baz: > etc... > } > > Add a specific regex for that form and the default label. > Use the regex where a case label is tested. Please ignore, the patch is defective as it has too many false positives. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750971AbcDKFEP (ORCPT ); Mon, 11 Apr 2016 01:04:15 -0400 Received: from smtprelay0019.hostedemail.com ([216.40.44.19]:53422 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750705AbcDKFEO (ORCPT ); Mon, 11 Apr 2016 01:04:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3868:3871:3872:3874:4321:5007:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14659:21080:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: fan96_77cb5897d953 X-Filterd-Recvd-Size: 1432 Message-ID: <1460351050.1800.69.camel@perches.com> Subject: Re: [PATCH] checkpatch: Improve missing break for switch/case tests From: Joe Perches To: Andrew Morton , Andy Whitcroft Cc: "alsa-devel@alsa-project.org" , Lars-Peter Clausen , Takashi Iwai , "Harvey, Ryan" , LKML Date: Sun, 10 Apr 2016 22:04:10 -0700 In-Reply-To: <1460341582.1800.66.camel@perches.com> References: <570928CC.6030404@metafoo.de> <1460341582.1800.66.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-04-10 at 19:26 -0700, Joe Perches wrote: > The current switch/case test doesn't handle ... case labels like: > > switch (foo) { > case bar ... baz: > etc... > } > > Add a specific regex for that form and the default label. > Use the regex where a case label is tested. Please ignore, the patch is defective as it has too many false positives.