From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes.
Date: Mon, 11 Apr 2016 17:12:21 +0200 [thread overview]
Message-ID: <1460387541.1765.12.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA9kgdVbePr0Vf2N+Z_qv7hiSgK9AzfyVVev49MFJ5Zu_g@mail.gmail.com>
> Hi. I'm afraid this doesn't compile on ppc64be:
>
> /home/pm215/qemu/hw/input/virtio-input-hid.c:487:9: error: suggest
> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
> ^
> /home/pm215/qemu/hw/input/virtio-input-hid.c:492:9: error: suggest
> parentheses around ‘-’ in operand of ‘&’ [-Werror=parentheses]
> .u.abs.max = const_le32(INPUT_EVENT_ABS_SIZE - 1),
> ^
>
> It looks like the const_le32() and const_le16() macros in
> include/hw/virtio/virtio-input.h are missing brackets around the macro
> argument
Indeed. /me needs a be machine.
> -- can you send a patch which adds the missing brackets, please?
Sure.
> (Side question, why is an apparently generic endianness support
> macro implemented in virtio-input.h ?)
Suggestions for a better place? Looks like there isn't something like
byteorder.h ...
cheers,
Gerd
next prev parent reply other threads:[~2016-04-11 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 10:29 [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 1/5] virtio-input: add missing key mappings Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 2/5] virtio-input: retrieve EV_LED host config bits Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 3/5] virtio-input: implement pass-through evdev writes Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 4/5] virtio-input: add live migration support Gerd Hoffmann
2016-04-11 10:29 ` [Qemu-devel] [PULL 5/5] virtio-input: fix emulated tablet axis ranges Gerd Hoffmann
2016-04-11 12:30 ` [Qemu-devel] [PULL 0/5] virtio-input; live migration support, various bugfixes Peter Maydell
2016-04-11 15:12 ` Gerd Hoffmann [this message]
2016-04-11 15:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460387541.1765.12.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.