From: David Turner <dturner@twopensource.com>
To: Jeff King <peff@peff.net>, Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin
Date: Mon, 11 Apr 2016 17:29:22 -0400 [thread overview]
Message-ID: <1460410162.5540.20.camel@twopensource.com> (raw)
In-Reply-To: <20160411133343.GA7492@sigill.intra.peff.net>
On Mon, 2016-04-11 at 09:33 -0400, Jeff King wrote:
> On Sun, Apr 10, 2016 at 11:57:31PM +0100, Ramsay Jones wrote:
>
> > So, the approach taken by patch #1 is to forget about UNIX_PATH_MAX
> > and
> > simply use sizeof(address.sun_path) instead!
>
> That's what the existing code in unix-socket.c does. Which makes me
> wonder why the index-helper code is not simply calling that.
Because I didn't notice it at the time. Duy pointed it out on another
comment on this series; I'll fix it.
next prev parent reply other threads:[~2016-04-11 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 22:57 [PATCH 0/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin Ramsay Jones
2016-04-11 13:33 ` Jeff King
2016-04-11 21:29 ` David Turner [this message]
2016-04-12 1:46 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460410162.5540.20.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.