From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 2/3] xen: hypercall docs annotations for
 xen_sysctl_cpupool_op
Date: Thu, 14 Apr 2016 22:37:20 +0200
Message-ID: <1460666240.13871.206.camel@citrix.com>
References: <1460653660-6654-1-git-send-email-ian.jackson@eu.citrix.com>
 <1460653660-6654-3-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2252928254303922074=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1460653660-6654-3-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xensource.com
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wei.liu2@citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

--===============2252928254303922074==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-iN1GcpljPd3oGpWsFyq9"

--=-iN1GcpljPd3oGpWsFyq9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2016-04-14 at 18:07 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Tim Deegan <tim@xen.org>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

One thing, out of curiosity. This syntax, here:

> -/* XEN_SYSCTL_cpupool_op */
> +/* ` enum XEN_SYSCTL_cpupool_op { */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_CREATE=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A01=C2=A0=
=C2=A0/* C */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_DESTROY=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A02=C2=A0=C2=A0/*=
 D */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_INFO=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
3=C2=A0=C2=A0/* I */
> @@ -546,9 +546,10 @@ DEFINE_XEN_GUEST_HANDLE(xen_sysctl_numainfo_t);
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_RMCPU=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A05=
=C2=A0=C2=A0/* R */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_MOVEDOMAIN=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A06=C2=A0=C2=A0/* M */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_OP_FREEINFO=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A07=C2=A0=C2=A0/* F =
*/
> +/* ` } */
> =C2=A0#define XEN_SYSCTL_CPUPOOL_PAR_ANY=C2=A0=C2=A0=C2=A0=C2=A0=C2=A00xF=
FFFFFFF
> =C2=A0struct xen_sysctl_cpupool_op {
> -=C2=A0=C2=A0=C2=A0=C2=A0uint32_t op;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0/* IN */
> +=C2=A0=C2=A0=C2=A0=C2=A0uint32_t op;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0/* IN ` enum XEN_SYSCTL_cpupool_op ` */
>
and here, is I guess useful to the hypercall HTML docs generator, as
mentioned in the cover letter?

It is not something we do in many other places (if at all, at least in
this file)... If it is, I'll happily add to my TODO list to convert
more entries to it.

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-iN1GcpljPd3oGpWsFyq9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcP/4AACgkQk4XaBE3IOsTdOQCdHIPA3rcMpjrmCFcGaPxF7/lG
Q/MAn2i8y2lVBOjA6SxH3L5IDkXPO9IO
=PSMi
-----END PGP SIGNATURE-----

--=-iN1GcpljPd3oGpWsFyq9--


--===============2252928254303922074==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============2252928254303922074==--