From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 3/3] xen: Document XEN_SYSCTL_CPUPOOL_OP_RMCPU anomalous EBUSY result Date: Fri, 15 Apr 2016 12:58:33 +0200 Message-ID: <1460717913.13871.240.camel@citrix.com> References: <1460653660-6654-1-git-send-email-ian.jackson@eu.citrix.com> <1460653660-6654-4-git-send-email-ian.jackson@eu.citrix.com> <570FD25B.3060802@citrix.com> <22287.55772.931614.61945@mariner.uk.xensource.com> <1460665330.13871.196.camel@citrix.com> <22288.49281.920483.206367@mariner.uk.xensource.com> <5710C5DD.1090403@suse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8660832690059059069==" Return-path: In-Reply-To: <5710C5DD.1090403@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross , Ian Jackson Cc: xen-devel@lists.xensource.com, Wei Liu , George Dunlap , Andrew Cooper , Tim Deegan , Jan Beulich List-Id: xen-devel@lists.xenproject.org --===============8660832690059059069== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-D2QagxiAeuW6f9LpCllM" --=-D2QagxiAeuW6f9LpCllM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2016-04-15 at 12:43 +0200, Juergen Gross wrote: > On 15/04/16 12:20, Ian Jackson wrote: > >=20 > > Would either of you care to provide a version of my documentation > > patch > > which answers the questions that my text answers ?=C2=A0=C2=A0Or shall = we > > commit > > my version and you can edit it in-tree :-). > I can provide an updated patch. >=20 Great. > > All I need now is a recipe for the tools to tell what has happened > > and > > then I can make xl or libxl at least print comprehensible and > > correct > > error messages... > So this boils down to finding an appropriate ESOMETHING replacement > for the EBUSY case introduced by the temporary pinning. >=20 Exactly. > I think ENOTEMPTY or EADDRINUSE would fit best. > I like the latter better. >=20 > The EBUSY returns of not successful repair attempts (trying to assign > a > cpu to another cpupool) should be changed to e.g. EADDRNOTAVAIL? >=20 I'd go for EADDRINUSE and EADDRNOTAVAIL so the two error values are similarly *wrong* hinting an addressing issue, which is more consistent (and would come handy when documenting) than having one pointing at the filesystem and the other at the address space. Are you going to do the patch for this yourself as well? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-D2QagxiAeuW6f9LpCllM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlcQyVoACgkQk4XaBE3IOsRy8ACfRNQRICMMKZeNFBO42W57Rwqa sVMAnij+EYJM7QxNwedqFAfpQup6Sr1w =gmEM -----END PGP SIGNATURE----- --=-D2QagxiAeuW6f9LpCllM-- --===============8660832690059059069== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --===============8660832690059059069==--