From: Paolo Abeni <pabeni@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, mst@redhat.com,
hannes@stressinduktion.org, ebiederm@xmission.com,
gkurz@linux.vnet.ibm.com, jasowang@redhat.com
Subject: Re: [PATCH net-next] tun: use per cpu variables for stats accounting
Date: Fri, 15 Apr 2016 14:30:28 +0200 [thread overview]
Message-ID: <1460723428.7410.7.camel@redhat.com> (raw)
In-Reply-To: <20160414.225617.2128747969495613941.davem@davemloft.net>
On Thu, 2016-04-14 at 22:56 -0400, David Miller wrote:
> From: Paolo Abeni <pabeni@redhat.com>
> Date: Wed, 13 Apr 2016 10:52:20 +0200
>
> > Currently the tun device accounting uses dev->stats without applying any
> > kind of protection, regardless that accounting happens in preemptible
> > process context.
> > This patch move the tun stats to a per cpu data structure, and protect
> > the updates with u64_stats_update_begin()/u64_stats_update_end() or
> > this_cpu_inc according to the stat type. The per cpu stats are
> > aggregated by the newly added ndo_get_stats64 ops.
> >
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
>
> Ok this seems reasonable, applied, thanks.
>
> I guess most applications use tuntap by having two threads, one
> for transmit and one for receive processing?
Probably. I guess that an user space application can leverage multiple
transmit threads to improve the throughput.
Paolo
prev parent reply other threads:[~2016-04-15 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 8:52 [PATCH net-next] tun: use per cpu variables for stats accounting Paolo Abeni
2016-04-15 2:56 ` David Miller
2016-04-15 12:30 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460723428.7410.7.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=hannes@stressinduktion.org \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.