From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH 2/3] libxc: adjust retry loop in
	xc_cpupool_removecpu()
Date: Fri, 15 Apr 2016 17:26:53 +0200
Message-ID: <1460734013.13871.268.camel@citrix.com>
References: <1460732057-30032-1-git-send-email-jgross@suse.com>
 <1460732057-30032-3-git-send-email-jgross@suse.com>
 <22289.1641.430855.745154@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4946834667303610904=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <22289.1641.430855.745154@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Juergen Gross <jgross@suse.com>
Cc: andrew.cooper3@citrix.com, wei.liu2@citrix.com, david.vrabel@citrix.com, jbeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4946834667303610904==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-zisFo3Wn/moXhlwkKXIF"

--=-zisFo3Wn/moXhlwkKXIF
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-04-15 at 16:19 +0100, Ian Jackson wrote:
> Juergen Gross writes ("[PATCH 2/3] libxc: adjust retry loop in
> xc_cpupool_removecpu()"):
> >=20
> > Commit 1ef6beea187b ("libxc: do some retries in
> > xc_cpupool_removecpu()
> > for EBUSY case") added a retry loop in xc_cpupool_removecpu() for
> > the
> > EBUSY case. As EBUSY was returned in multiple error situations the
> > loop would have been executed in situations where a retry would not
> > be successful. Additionally calling sleep(1) between the rerires is
> > a
> > bad idea when being called in a daemon.
> >=20
> > The hypervisor has been changed to return different error values
> > now.
> > The retry added in above mentioned commit should be done in the
> > EADDRINUSE case now. As the error condition should last only for a
> > very short time, the sleep(1) call can be removed.
> >=20
> > Requested-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> Thanks.
>=20
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>=20
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

Regards,
Dario
--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-zisFo3Wn/moXhlwkKXIF
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlcRCD0ACgkQk4XaBE3IOsSKHACdFK7qkTCyqyEczn8IohbTNIdP
YcYAoJfW8VqTIIew8pctgRzd03xbArK5
=jfZA
-----END PGP SIGNATURE-----

--=-zisFo3Wn/moXhlwkKXIF--


--===============4946834667303610904==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y
Zy94ZW4tZGV2ZWwK

--===============4946834667303610904==--