From: Joe Perches <joe@perches.com>
To: Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
"H. Peter Anvin" <hpa@zytor.com>, Borislav Petkov <bp@alien8.de>,
Brian Gerst <brgerst@gmail.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix non-static inlines
Date: Fri, 15 Apr 2016 10:10:38 -0700 [thread overview]
Message-ID: <1460740238.19090.35.camel@perches.com> (raw)
In-Reply-To: <1460739626-12179-1-git-send-email-dvlasenk@redhat.com>
On Fri, 2016-04-15 at 19:00 +0200, Denys Vlasenko wrote:
> Four instances of incorrect usage of non-static "inline" crept up
> in arch/x86, all trivial; cleaning them up:
Thanks and trivia:
> diff --git a/arch/x86/crypto/sha-mb/sha1_mb.c b/arch/x86/crypto/sha-mb/sha1_mb.c
[]
> @@ -102,14 +102,14 @@ static asmlinkage struct job_sha1* (*sha1_job_mgr_submit)(struct sha1_mb_mgr *st
[]
> -inline uint32_t sha1_pad(uint8_t padblock[SHA1_BLOCK_SIZE * 2],
> +static inline uint32_t sha1_pad(uint8_t padblock[SHA1_BLOCK_SIZE * 2],
> uint32_t total_len)
It'd be good to reindent the multi-line statements
at the same time.
next prev parent reply other threads:[~2016-04-15 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 17:00 [PATCH] x86: fix non-static inlines Denys Vlasenko
2016-04-15 17:10 ` Joe Perches [this message]
2016-04-16 11:24 ` [tip:x86/cleanups] x86: Fix " tip-bot for Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460740238.19090.35.camel@perches.com \
--to=joe@perches.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.