From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2] e1000e: don't modify SYSTIM registers during SIOCSHWTSTAMP ioctl
Date: Fri, 15 Apr 2016 22:16:25 +0000 [thread overview]
Message-ID: <1460758585.13811.7.camel@intel.com> (raw)
In-Reply-To: <20160415220913.GA28644@hobbes.lan20.walshnetwork.net>
On Fri, 2016-04-15 at 18:09 -0400, Brian Walsh wrote:
> On Fri, Apr 15, 2016 at 02:36:55PM -0700, Jacob Keller wrote:
> >
> > +
> > + if (adapter->ptp_clock_info) {
> > + /* restore the previous ptp frequency delta */
> > + ret_val = adapter-
> > >ptp_clock_info.adjfreq(&adapter->ptp_clock_info,
> > + ??adapter-
> > >ptp_delta);
> > + if (ret_val)
> > + dev_warn(&adapter->pdev->dev,
> > + ?"Failed to restore TIMINCA clock
> > rate delta: %d\n",
> > + ?ret_val);
> > + else {
> > + ret_val = e1000e_get_base_timinca(adapter,
> > &timinca);
> > + if (ret_val)
> > + dev_warn(&adapter->pdev->dev,
> > + ?"Failed to set default TIMINCA
> > clock rate: %d\n",
> > + ?ret_val);
> > + else
> > + ew32(TIMINCA, timinca);
> > + }
> Can't do a boolean check on a struct ptp_clock_info.
>
> Testing the patch without the handle NULL ptp_clock_info change.
>
Oops you're right it's not a pointer... Hmm I was thinking of
ptp_clock. I'll think that through a bit more.
Thanks,
Jake
next prev parent reply other threads:[~2016-04-15 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 21:36 [Intel-wired-lan] [PATCH v2] e1000e: don't modify SYSTIM registers during SIOCSHWTSTAMP ioctl Jacob Keller
2016-04-15 22:05 ` kbuild test robot
2016-04-15 22:08 ` kbuild test robot
2016-04-15 22:08 ` kbuild test robot
2016-04-15 22:09 ` Brian Walsh
2016-04-15 22:16 ` Keller, Jacob E [this message]
2016-04-15 22:29 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460758585.13811.7.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.