diff for duplicates of <1460991578.8946.10.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 32277c9..d705972 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,8 +7,8 @@ On Sat, 2016-04-16 at 20:20 +0100, Jonathan Cameron wrote: > > > > Patch created using Coccinelle plus manual edits. > > -> > Signed-off-by: Alison Schofield <amsfield22@gmail.com> -Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> +> > Signed-off-by: Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> +Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > I'm happy with this but please do make sure to cc the maintainer / > author diff --git a/a/content_digest b/N1/content_digest index 41239cd..44972e8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,22 @@ "ref\0cover.1460314070.git.amsfield22@gmail.com\0" "ref\0f3cae5dd803486a774248afad096032f3f0546a2.1460314070.git.amsfield22@gmail.com\0" "ref\057129064.9050508@kernel.org\0" - "From\0Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>\0" + "ref\057129064.9050508-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org\0" + "From\0Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\0" "Subject\0Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device\0" "Date\0Mon, 18 Apr 2016 07:59:38 -0700\0" - "To\0Jonathan Cameron <jic23@kernel.org>" - " Alison Schofield <amsfield22@gmail.com>\0" - "Cc\0knaack.h@gmx.de" - lars@metafoo.de - pmeerw@pmeerw.net - kgene@kernel.org - k.kozlowski@samsung.com - linux-iio@vger.kernel.org - linux-kernel@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-samsung-soc@vger.kernel.org - " Irina Tirdea <irina.tirdea@intel.com>\0" + "To\0Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>" + " Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "Cc\0knaack.h-Mmb7MZpHnFY@public.gmane.org" + lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org + pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org + kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org + k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org + linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org + linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org + " Irina Tirdea <irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>\0" "\00:1\0" "b\0" "On Sat, 2016-04-16 at 20:20 +0100, Jonathan Cameron wrote:\n" @@ -27,8 +28,8 @@ "> > \n" "> > Patch created using Coccinelle plus manual edits.\n" "> > \n" - "> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>\n" - "Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>\n" + "> > Signed-off-by: Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" + "Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>\n" "\n" "> I'm happy with this but please do make sure to cc the maintainer /\n" "> author\n" @@ -572,4 +573,4 @@ "> > \302\240\tif (ret < 0)\n" > > -8754b54c28ee8ff2b0bcb9f47d61e53c003050e7ec9275972be4a3b0e5a589d4 +4454d8a43e27eeb946016c6b4c55f40ff78a35589ffbc6f026550c0289d0a8ef
diff --git a/a/1.txt b/N2/1.txt index 32277c9..27fbe0f 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -14,7 +14,7 @@ Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > author > of drivers if possible (often the email addresses are out of date!) > -> Srinivas, this is one of yours. Are you happy with this? +> Srinivas, this is one of yours.??Are you happy with this? > I've also cc'd Irina who has worked on this driver recently for any > comments. > @@ -25,9 +25,9 @@ Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Jonathan > > > > --- -> > drivers/iio/accel/bmc150-accel-core.c | 99 +++++++++++++++++++-- +> > ?drivers/iio/accel/bmc150-accel-core.c | 99 +++++++++++++++++++-- > > -------------- -> > 1 file changed, 54 insertions(+), 45 deletions(-) +> > ?1 file changed, 54 insertions(+), 45 deletions(-) > > > > diff --git a/drivers/iio/accel/bmc150-accel-core.c > > b/drivers/iio/accel/bmc150-accel-core.c @@ -35,519 +35,519 @@ Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > --- a/drivers/iio/accel/bmc150-accel-core.c > > +++ b/drivers/iio/accel/bmc150-accel-core.c > > @@ -188,7 +188,6 @@ enum bmc150_accel_trigger_id { -> > -> > struct bmc150_accel_data { -> > struct regmap *regmap; +> > ? +> > ?struct bmc150_accel_data { +> > ? struct regmap *regmap; > > - struct device *dev; -> > int irq; -> > struct bmc150_accel_interrupt +> > ? int irq; +> > ? struct bmc150_accel_interrupt > > interrupts[BMC150_ACCEL_INTERRUPTS]; -> > atomic_t active_intr; +> > ? atomic_t active_intr; > > @@ -256,6 +255,7 @@ static int bmc150_accel_set_mode(struct > > bmc150_accel_data *data, -> > enum bmc150_power_modes mode, -> > int dur_us) -> > { +> > ? ?enum bmc150_power_modes mode, +> > ? ?int dur_us) +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int i; -> > int ret; -> > u8 lpw_bits; +> > ? int i; +> > ? int ret; +> > ? u8 lpw_bits; > > @@ -279,11 +279,11 @@ static int bmc150_accel_set_mode(struct > > bmc150_accel_data *data, -> > lpw_bits = mode << BMC150_ACCEL_PMU_MODE_SHIFT; -> > lpw_bits |= (dur_val << +> > ? lpw_bits = mode << BMC150_ACCEL_PMU_MODE_SHIFT; +> > ? lpw_bits |= (dur_val << > > BMC150_ACCEL_PMU_BIT_SLEEP_DUR_SHIFT); -> > +> > ? > > - dev_dbg(data->dev, "Set Mode bits %x\n", lpw_bits); > > + dev_dbg(dev, "Set Mode bits %x\n", lpw_bits); -> > -> > ret = regmap_write(data->regmap, BMC150_ACCEL_REG_PMU_LPW, +> > ? +> > ? ret = regmap_write(data->regmap, BMC150_ACCEL_REG_PMU_LPW, > > lpw_bits); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error writing reg_pmu_lpw\n"); > > + dev_err(dev, "Error writing reg_pmu_lpw\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -316,23 +316,24 @@ static int bmc150_accel_set_bw(struct > > bmc150_accel_data *data, int val, -> > -> > static int bmc150_accel_update_slope(struct bmc150_accel_data +> > ? +> > ?static int bmc150_accel_update_slope(struct bmc150_accel_data > > *data) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret; -> > -> > ret = regmap_write(data->regmap, BMC150_ACCEL_REG_INT_6, -> > data->slope_thres); -> > if (ret < 0) { +> > ? int ret; +> > ? +> > ? ret = regmap_write(data->regmap, BMC150_ACCEL_REG_INT_6, +> > ? data->slope_thres); +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error writing reg_int_6\n"); > > + dev_err(dev, "Error writing reg_int_6\n"); -> > return ret; -> > } -> > -> > ret = regmap_update_bits(data->regmap, +> > ? return ret; +> > ? } +> > ? +> > ? ret = regmap_update_bits(data->regmap, > > BMC150_ACCEL_REG_INT_5, -> > BMC150_ACCEL_SLOPE_DUR_MASK, +> > ? ?BMC150_ACCEL_SLOPE_DUR_MASK, > > data->slope_dur); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error updating reg_int_5\n"); > > + dev_err(dev, "Error updating reg_int_5\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > - dev_dbg(data->dev, "%s: %x %x\n", __func__, data- > > >slope_thres, > > + dev_dbg(dev, "%s: %x %x\n", __func__, data->slope_thres, -> > data->slope_dur); -> > -> > return ret; +> > ? data->slope_dur); +> > ? +> > ? return ret; > > @@ -378,20 +379,21 @@ static int > > bmc150_accel_get_startup_times(struct bmc150_accel_data *data) -> > -> > static int bmc150_accel_set_power_state(struct bmc150_accel_data +> > ? +> > ?static int bmc150_accel_set_power_state(struct bmc150_accel_data > > *data, bool on) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret; -> > -> > if (on) { +> > ? int ret; +> > ? +> > ? if (on) { > > - ret = pm_runtime_get_sync(data->dev); > > + ret = pm_runtime_get_sync(dev); -> > } else { +> > ? } else { > > - pm_runtime_mark_last_busy(data->dev); > > - ret = pm_runtime_put_autosuspend(data->dev); > > + pm_runtime_mark_last_busy(dev); > > + ret = pm_runtime_put_autosuspend(dev); -> > } -> > -> > if (ret < 0) { +> > ? } +> > ? +> > ? if (ret < 0) { > > - dev_err(data->dev, > > + dev_err(dev, -> > "Failed: bmc150_accel_set_power_state for +> > ? "Failed: bmc150_accel_set_power_state for > > %d\n", on); -> > if (on) +> > ? if (on) > > - pm_runtime_put_noidle(data->dev); > > + pm_runtime_put_noidle(dev); -> > -> > return ret; -> > } +> > ? +> > ? return ret; +> > ? } > > @@ -445,6 +447,7 @@ static void > > bmc150_accel_interrupts_setup(struct iio_dev *indio_dev, -> > static int bmc150_accel_set_interrupt(struct bmc150_accel_data +> > ?static int bmc150_accel_set_interrupt(struct bmc150_accel_data > > *data, int i, -> > bool state) -> > { +> > ? ??????bool state) +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > struct bmc150_accel_interrupt *intr = &data- +> > ? struct bmc150_accel_interrupt *intr = &data- > > >interrupts[i]; -> > const struct bmc150_accel_interrupt_info *info = intr- +> > ? const struct bmc150_accel_interrupt_info *info = intr- > > >info; -> > int ret; +> > ? int ret; > > @@ -474,7 +477,7 @@ static int bmc150_accel_set_interrupt(struct > > bmc150_accel_data *data, int i, -> > ret = regmap_update_bits(data->regmap, info->map_reg, +> > ? ret = regmap_update_bits(data->regmap, info->map_reg, > > info->map_bitmask, -> > (state ? info->map_bitmask : 0)); -> > if (ret < 0) { +> > ? ?(state ? info->map_bitmask : 0)); +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error updating > > reg_int_map\n"); > > + dev_err(dev, "Error updating reg_int_map\n"); -> > goto out_fix_power_state; -> > } -> > +> > ? goto out_fix_power_state; +> > ? } +> > ? > > @@ -482,7 +485,7 @@ static int bmc150_accel_set_interrupt(struct > > bmc150_accel_data *data, int i, -> > ret = regmap_update_bits(data->regmap, info->en_reg, info- +> > ? ret = regmap_update_bits(data->regmap, info->en_reg, info- > > >en_bitmask, -> > (state ? info->en_bitmask : 0)); -> > if (ret < 0) { +> > ? ?(state ? info->en_bitmask : 0)); +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error updating reg_int_en\n"); > > + dev_err(dev, "Error updating reg_int_en\n"); -> > goto out_fix_power_state; -> > } -> > +> > ? goto out_fix_power_state; +> > ? } +> > ? > > @@ -500,6 +503,7 @@ out_fix_power_state: -> > -> > static int bmc150_accel_set_scale(struct bmc150_accel_data *data, +> > ? +> > ?static int bmc150_accel_set_scale(struct bmc150_accel_data *data, > > int val) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret, i; -> > -> > for (i = 0; i < ARRAY_SIZE(data->chip_info->scale_table); +> > ? int ret, i; +> > ? +> > ? for (i = 0; i < ARRAY_SIZE(data->chip_info->scale_table); > > ++i) { > > @@ -508,8 +512,7 @@ static int bmc150_accel_set_scale(struct > > bmc150_accel_data *data, int val) -> > BMC150_ACCEL_REG_PMU_RANGE, -> > data->chip_info- +> > ? ?????BMC150_ACCEL_REG_PMU_RANGE, +> > ? ?????data->chip_info- > > >scale_table[i].reg_range); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, > > - "Error writing > > pmu_range\n"); > > + dev_err(dev, "Error writing > > pmu_range\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -523,6 +526,7 @@ static int bmc150_accel_set_scale(struct > > bmc150_accel_data *data, int val) -> > -> > static int bmc150_accel_get_temp(struct bmc150_accel_data *data, +> > ? +> > ?static int bmc150_accel_get_temp(struct bmc150_accel_data *data, > > int *val) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret; -> > unsigned int value; -> > +> > ? int ret; +> > ? unsigned int value; +> > ? > > @@ -530,7 +534,7 @@ static int bmc150_accel_get_temp(struct > > bmc150_accel_data *data, int *val) -> > -> > ret = regmap_read(data->regmap, BMC150_ACCEL_REG_TEMP, +> > ? +> > ? ret = regmap_read(data->regmap, BMC150_ACCEL_REG_TEMP, > > &value); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error reading reg_temp\n"); > > + dev_err(dev, "Error reading reg_temp\n"); -> > mutex_unlock(&data->mutex); -> > return ret; -> > } +> > ? mutex_unlock(&data->mutex); +> > ? return ret; +> > ? } > > @@ -545,6 +549,7 @@ static int bmc150_accel_get_axis(struct > > bmc150_accel_data *data, -> > struct iio_chan_spec const *chan, -> > int *val) -> > { +> > ? ?struct iio_chan_spec const *chan, +> > ? ?int *val) +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret; -> > int axis = chan->scan_index; -> > unsigned int raw_val; +> > ? int ret; +> > ? int axis = chan->scan_index; +> > ? unsigned int raw_val; > > @@ -559,7 +564,7 @@ static int bmc150_accel_get_axis(struct > > bmc150_accel_data *data, -> > ret = regmap_bulk_read(data->regmap, +> > ? ret = regmap_bulk_read(data->regmap, > > BMC150_ACCEL_AXIS_TO_REG(axis), -> > &raw_val, 2); -> > if (ret < 0) { +> > ? ???????&raw_val, 2); +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error reading axis %d\n", > > axis); > > + dev_err(dev, "Error reading axis %d\n", axis); -> > bmc150_accel_set_power_state(data, false); -> > mutex_unlock(&data->mutex); -> > return ret; +> > ? bmc150_accel_set_power_state(data, false); +> > ? mutex_unlock(&data->mutex); +> > ? return ret; > > @@ -831,6 +836,7 @@ static int bmc150_accel_set_watermark(struct > > iio_dev *indio_dev, unsigned val) -> > static int bmc150_accel_fifo_transfer(struct bmc150_accel_data +> > ?static int bmc150_accel_fifo_transfer(struct bmc150_accel_data > > *data, -> > char *buffer, int samples) -> > { +> > ? ??????char *buffer, int samples) +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int sample_length = 3 * 2; -> > int ret; -> > int total_length = samples * sample_length; +> > ? int sample_length = 3 * 2; +> > ? int ret; +> > ? int total_length = samples * sample_length; > > @@ -854,7 +860,8 @@ static int bmc150_accel_fifo_transfer(struct > > bmc150_accel_data *data, -> > } -> > -> > if (ret) +> > ? } +> > ? +> > ? if (ret) > > - dev_err(data->dev, "Error transferring data from > > fifo in single steps of %zu\n", > > + dev_err(dev, > > + "Error transferring data from fifo in > > single steps of %zu\n", -> > step); -> > -> > return ret; +> > ? step); +> > ? +> > ? return ret; > > @@ -864,6 +871,7 @@ static int __bmc150_accel_fifo_flush(struct > > iio_dev *indio_dev, -> > unsigned samples, bool irq) -> > { -> > struct bmc150_accel_data *data = iio_priv(indio_dev); +> > ? ?????unsigned samples, bool irq) +> > ?{ +> > ? struct bmc150_accel_data *data = iio_priv(indio_dev); > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret, i; -> > u8 count; -> > u16 buffer[BMC150_ACCEL_FIFO_LENGTH * 3]; +> > ? int ret, i; +> > ? u8 count; +> > ? u16 buffer[BMC150_ACCEL_FIFO_LENGTH * 3]; > > @@ -873,7 +881,7 @@ static int __bmc150_accel_fifo_flush(struct > > iio_dev *indio_dev, -> > -> > ret = regmap_read(data->regmap, +> > ? +> > ? ret = regmap_read(data->regmap, > > BMC150_ACCEL_REG_FIFO_STATUS, &val); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error reading > > reg_fifo_status\n"); > > + dev_err(dev, "Error reading reg_fifo_status\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1135,6 +1143,7 @@ static int bmc150_accel_trig_try_reen(struct > > iio_trigger *trig) -> > { -> > struct bmc150_accel_trigger *t = +> > ?{ +> > ? struct bmc150_accel_trigger *t = > > iio_trigger_get_drvdata(trig); -> > struct bmc150_accel_data *data = t->data; +> > ? struct bmc150_accel_data *data = t->data; > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret; -> > -> > /* new data interrupts don't need ack */ +> > ? int ret; +> > ? +> > ? /* new data interrupts don't need ack */ > > @@ -1148,8 +1157,7 @@ static int bmc150_accel_trig_try_reen(struct > > iio_trigger *trig) -> > BMC150_ACCEL_INT_MODE_LATCH_RESET); -> > mutex_unlock(&data->mutex); -> > if (ret < 0) { +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_RESET); +> > ? mutex_unlock(&data->mutex); +> > ? if (ret < 0) { > > - dev_err(data->dev, > > - "Error writing reg_int_rst_latch\n"); > > + dev_err(dev, "Error writing reg_int_rst_latch\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1200,13 +1208,14 @@ static const struct iio_trigger_ops > > bmc150_accel_trigger_ops = { -> > static int bmc150_accel_handle_roc_event(struct iio_dev +> > ?static int bmc150_accel_handle_roc_event(struct iio_dev > > *indio_dev) -> > { -> > struct bmc150_accel_data *data = iio_priv(indio_dev); +> > ?{ +> > ? struct bmc150_accel_data *data = iio_priv(indio_dev); > > + struct device *dev = regmap_get_device(data->regmap); -> > int dir; -> > int ret; -> > unsigned int val; -> > -> > ret = regmap_read(data->regmap, +> > ? int dir; +> > ? int ret; +> > ? unsigned int val; +> > ? +> > ? ret = regmap_read(data->regmap, > > BMC150_ACCEL_REG_INT_STATUS_2, &val); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error reading > > reg_int_status_2\n"); > > + dev_err(dev, "Error reading reg_int_status_2\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1249,6 +1258,7 @@ static irqreturn_t > > bmc150_accel_irq_thread_handler(int irq, void *private) -> > { -> > struct iio_dev *indio_dev = private; -> > struct bmc150_accel_data *data = iio_priv(indio_dev); +> > ?{ +> > ? struct iio_dev *indio_dev = private; +> > ? struct bmc150_accel_data *data = iio_priv(indio_dev); > > + struct device *dev = regmap_get_device(data->regmap); -> > bool ack = false; -> > int ret; -> > +> > ? bool ack = false; +> > ? int ret; +> > ? > > @@ -1272,7 +1282,7 @@ static irqreturn_t > > bmc150_accel_irq_thread_handler(int irq, void *private) -> > BMC150_ACCEL_INT_MODE_LATCH_INT +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_INT > > | -> > BMC150_ACCEL_INT_MODE_LATCH_RES +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_RES > > ET); -> > if (ret) +> > ? if (ret) > > - dev_err(data->dev, "Error writing > > reg_int_rst_latch\n"); > > + dev_err(dev, "Error writing > > reg_int_rst_latch\n"); -> > -> > ret = IRQ_HANDLED; -> > } else { +> > ? +> > ? ret = IRQ_HANDLED; +> > ? } else { > > @@ -1343,13 +1353,14 @@ static void > > bmc150_accel_unregister_triggers(struct bmc150_accel_data *data, -> > static int bmc150_accel_triggers_setup(struct iio_dev *indio_dev, -> > struct bmc150_accel_data +> > ?static int bmc150_accel_triggers_setup(struct iio_dev *indio_dev, +> > ? ???????struct bmc150_accel_data > > *data) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int i, ret; -> > -> > for (i = 0; i < BMC150_ACCEL_TRIGGERS; i++) { -> > struct bmc150_accel_trigger *t = &data- +> > ? int i, ret; +> > ? +> > ? for (i = 0; i < BMC150_ACCEL_TRIGGERS; i++) { +> > ? struct bmc150_accel_trigger *t = &data- > > >triggers[i]; -> > +> > ? > > - t->indio_trig = devm_iio_trigger_alloc(data->dev, -> > - bmc150_accel_trigge +> > - ???????bmc150_accel_trigge > > rs[i].name, > > + t->indio_trig = devm_iio_trigger_alloc(dev, > > + bmc150_accel_triggers[i].n > > ame, -> > indio_dev- +> > ? ???????indio_dev- > > >name, -> > indio_dev- +> > ? ???????indio_dev- > > >id); -> > if (!t->indio_trig) { +> > ? if (!t->indio_trig) { > > @@ -1357,7 +1368,7 @@ static int bmc150_accel_triggers_setup(struct > > iio_dev *indio_dev, -> > break; -> > } -> > +> > ? break; +> > ? } +> > ? > > - t->indio_trig->dev.parent = data->dev; > > + t->indio_trig->dev.parent = dev; -> > t->indio_trig->ops = &bmc150_accel_trigger_ops; -> > t->intr = bmc150_accel_triggers[i].intr; -> > t->data = data; +> > ? t->indio_trig->ops = &bmc150_accel_trigger_ops; +> > ? t->intr = bmc150_accel_triggers[i].intr; +> > ? t->data = data; > > @@ -1381,12 +1392,13 @@ static int > > bmc150_accel_triggers_setup(struct iio_dev *indio_dev, -> > -> > static int bmc150_accel_fifo_set_mode(struct bmc150_accel_data +> > ? +> > ?static int bmc150_accel_fifo_set_mode(struct bmc150_accel_data > > *data) -> > { +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > u8 reg = BMC150_ACCEL_REG_FIFO_CONFIG1; -> > int ret; -> > -> > ret = regmap_write(data->regmap, reg, data->fifo_mode); -> > if (ret < 0) { +> > ? u8 reg = BMC150_ACCEL_REG_FIFO_CONFIG1; +> > ? int ret; +> > ? +> > ? ret = regmap_write(data->regmap, reg, data->fifo_mode); +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error writing > > reg_fifo_config1\n"); > > + dev_err(dev, "Error writing reg_fifo_config1\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1396,7 +1408,7 @@ static int bmc150_accel_fifo_set_mode(struct > > bmc150_accel_data *data) -> > ret = regmap_write(data->regmap, +> > ? ret = regmap_write(data->regmap, > > BMC150_ACCEL_REG_FIFO_CONFIG0, -> > data->watermark); -> > if (ret < 0) +> > ? ???data->watermark); +> > ? if (ret < 0) > > - dev_err(data->dev, "Error writing > > reg_fifo_config0\n"); > > + dev_err(dev, "Error writing reg_fifo_config0\n"); -> > -> > return ret; -> > } +> > ? +> > ? return ret; +> > ?} > > @@ -1480,17 +1492,17 @@ static const struct iio_buffer_setup_ops > > bmc150_accel_buffer_ops = { -> > -> > static int bmc150_accel_chip_init(struct bmc150_accel_data *data) -> > { +> > ? +> > ?static int bmc150_accel_chip_init(struct bmc150_accel_data *data) +> > ?{ > > + struct device *dev = regmap_get_device(data->regmap); -> > int ret, i; -> > unsigned int val; -> > -> > ret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID, +> > ? int ret, i; +> > ? unsigned int val; +> > ? +> > ? ret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID, > > &val); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, > > - "Error: Reading chip id\n"); > > + dev_err(dev, "Error: Reading chip id\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > - dev_dbg(data->dev, "Chip Id %x\n", val); > > + dev_dbg(dev, "Chip Id %x\n", val); -> > for (i = 0; i < ARRAY_SIZE(bmc150_accel_chip_info_tbl); +> > ? for (i = 0; i < ARRAY_SIZE(bmc150_accel_chip_info_tbl); > > i++) { -> > if (bmc150_accel_chip_info_tbl[i].chip_id == val) +> > ? if (bmc150_accel_chip_info_tbl[i].chip_id == val) > > { -> > data->chip_info = +> > ? data->chip_info = > > &bmc150_accel_chip_info_tbl[i]; > > @@ -1499,7 +1511,7 @@ static int bmc150_accel_chip_init(struct > > bmc150_accel_data *data) -> > } -> > -> > if (!data->chip_info) { +> > ? } +> > ? +> > ? if (!data->chip_info) { > > - dev_err(data->dev, "Invalid chip %x\n", val); > > + dev_err(dev, "Invalid chip %x\n", val); -> > return -ENODEV; -> > } -> > +> > ? return -ENODEV; +> > ? } +> > ? > > @@ -1516,8 +1528,7 @@ static int bmc150_accel_chip_init(struct > > bmc150_accel_data *data) -> > ret = regmap_write(data->regmap, +> > ? ret = regmap_write(data->regmap, > > BMC150_ACCEL_REG_PMU_RANGE, -> > BMC150_ACCEL_DEF_RANGE_4G); -> > if (ret < 0) { +> > ? ???BMC150_ACCEL_DEF_RANGE_4G); +> > ? if (ret < 0) { > > - dev_err(data->dev, > > - "Error writing > > reg_pmu_range\n"); > > + dev_err(dev, "Error writing reg_pmu_range\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1535,8 +1546,7 @@ static int bmc150_accel_chip_init(struct > > bmc150_accel_data *data) -> > BMC150_ACCEL_INT_MODE_LATCH_INT | -> > BMC150_ACCEL_INT_MODE_LATCH_RESET); -> > if (ret < 0) { +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_INT | +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_RESET); +> > ? if (ret < 0) { > > - dev_err(data->dev, > > - "Error writing reg_int_rst_latch\n"); > > + dev_err(dev, "Error writing reg_int_rst_latch\n"); -> > return ret; -> > } -> > +> > ? return ret; +> > ? } +> > ? > > @@ -1556,7 +1566,6 @@ int bmc150_accel_core_probe(struct device > > *dev, struct regmap *regmap, int irq, -> > -> > data = iio_priv(indio_dev); -> > dev_set_drvdata(dev, indio_dev); +> > ? +> > ? data = iio_priv(indio_dev); +> > ? dev_set_drvdata(dev, indio_dev); > > - data->dev = dev; -> > data->irq = irq; -> > -> > data->regmap = regmap; +> > ? data->irq = irq; +> > ? +> > ? data->regmap = regmap; > > @@ -1580,13 +1589,13 @@ int bmc150_accel_core_probe(struct device > > *dev, struct regmap *regmap, int irq, -> > bmc150_accel_trigger_hand +> > ? ?bmc150_accel_trigger_hand > > ler, -> > &bmc150_accel_buffer_ops) +> > ? ?&bmc150_accel_buffer_ops) > > ; -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Failed: iio triggered buffer > > setup\n"); > > + dev_err(dev, "Failed: iio triggered buffer > > setup\n"); -> > return ret; -> > } -> > -> > if (data->irq > 0) { -> > ret = devm_request_threaded_irq( +> > ? return ret; +> > ? } +> > ? +> > ? if (data->irq > 0) { +> > ? ret = devm_request_threaded_irq( > > - data->dev, data- > > >irq, > > + dev, data->irq, -> > bmc150_accel_irq_h +> > ? bmc150_accel_irq_h > > andler, -> > bmc150_accel_irq_t +> > ? bmc150_accel_irq_t > > hread_handler, -> > IRQF_TRIGGER_RISIN +> > ? IRQF_TRIGGER_RISIN > > G, > > @@ -1604,7 +1613,7 @@ int bmc150_accel_core_probe(struct device > > *dev, struct regmap *regmap, int irq, -> > ret = regmap_write(data->regmap, +> > ? ret = regmap_write(data->regmap, > > BMC150_ACCEL_REG_INT_RST_LATCH, -> > BMC150_ACCEL_INT_MODE_LATCH_RES +> > ? ???BMC150_ACCEL_INT_MODE_LATCH_RES > > ET); -> > if (ret < 0) { +> > ? if (ret < 0) { > > - dev_err(data->dev, "Error writing > > reg_int_rst_latch\n"); > > + dev_err(dev, "Error writing > > reg_int_rst_latch\n"); -> > goto err_buffer_cleanup; -> > } -> > +> > ? goto err_buffer_cleanup; +> > ? } +> > ? > > @@ -1653,9 +1662,9 @@ int bmc150_accel_core_remove(struct device > > *dev) -> > -> > iio_device_unregister(indio_dev); -> > +> > ? +> > ? iio_device_unregister(indio_dev); +> > ? > > - pm_runtime_disable(data->dev); > > - pm_runtime_set_suspended(data->dev); > > - pm_runtime_put_noidle(data->dev); > > + pm_runtime_disable(dev); > > + pm_runtime_set_suspended(dev); > > + pm_runtime_put_noidle(dev); -> > -> > bmc150_accel_unregister_triggers(data, +> > ? +> > ? bmc150_accel_unregister_triggers(data, > > BMC150_ACCEL_TRIGGERS - 1); -> > +> > ? > > @@ -1704,7 +1713,7 @@ static int > > bmc150_accel_runtime_suspend(struct device *dev) -> > struct bmc150_accel_data *data = iio_priv(indio_dev); -> > int ret; -> > -> > - dev_dbg(data->dev, __func__); -> > + dev_dbg(dev, __func__); -> > ret = bmc150_accel_set_mode(data, +> > ? struct bmc150_accel_data *data = iio_priv(indio_dev); +> > ? int ret; +> > ? +> > - dev_dbg(data->dev,??__func__); +> > + dev_dbg(dev,??__func__); +> > ? ret = bmc150_accel_set_mode(data, > > BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0); -> > if (ret < 0) -> > return -EAGAIN; +> > ? if (ret < 0) +> > ? return -EAGAIN; > > @@ -1719,7 +1728,7 @@ static int bmc150_accel_runtime_resume(struct > > device *dev) -> > int ret; -> > int sleep_val; -> > -> > - dev_dbg(data->dev, __func__); -> > + dev_dbg(dev, __func__); -> > -> > ret = bmc150_accel_set_mode(data, +> > ? int ret; +> > ? int sleep_val; +> > ? +> > - dev_dbg(data->dev,??__func__); +> > + dev_dbg(dev,??__func__); +> > ? +> > ? ret = bmc150_accel_set_mode(data, > > BMC150_ACCEL_SLEEP_MODE_NORMAL, 0); -> > if (ret < 0) +> > ? if (ret < 0) > > diff --git a/a/content_digest b/N2/content_digest index 41239cd..4bd8c30 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,21 +1,10 @@ "ref\0cover.1460314070.git.amsfield22@gmail.com\0" "ref\0f3cae5dd803486a774248afad096032f3f0546a2.1460314070.git.amsfield22@gmail.com\0" "ref\057129064.9050508@kernel.org\0" - "From\0Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>\0" - "Subject\0Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device\0" + "From\0srinivas.pandruvada@linux.intel.com (Srinivas Pandruvada)\0" + "Subject\0[PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device\0" "Date\0Mon, 18 Apr 2016 07:59:38 -0700\0" - "To\0Jonathan Cameron <jic23@kernel.org>" - " Alison Schofield <amsfield22@gmail.com>\0" - "Cc\0knaack.h@gmx.de" - lars@metafoo.de - pmeerw@pmeerw.net - kgene@kernel.org - k.kozlowski@samsung.com - linux-iio@vger.kernel.org - linux-kernel@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-samsung-soc@vger.kernel.org - " Irina Tirdea <irina.tirdea@intel.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Sat, 2016-04-16 at 20:20 +0100, Jonathan Cameron wrote:\n" @@ -34,7 +23,7 @@ "> author\n" "> of drivers if possible (often the email addresses are out of date!)\n" "> \n" - "> Srinivas, this is one of yours.\302\240\302\240Are you happy with this?\n" + "> Srinivas, this is one of yours.??Are you happy with this?\n" "> I've also cc'd Irina who has worked on this driver recently for any\n" "> comments.\n" "> \n" @@ -45,9 +34,9 @@ "> Jonathan\n" "> > \n" "> > ---\n" - "> > \302\240drivers/iio/accel/bmc150-accel-core.c | 99 +++++++++++++++++++--\n" + "> > ?drivers/iio/accel/bmc150-accel-core.c | 99 +++++++++++++++++++--\n" "> > --------------\n" - "> > \302\2401 file changed, 54 insertions(+), 45 deletions(-)\n" + "> > ?1 file changed, 54 insertions(+), 45 deletions(-)\n" "> > \n" "> > diff --git a/drivers/iio/accel/bmc150-accel-core.c\n" "> > b/drivers/iio/accel/bmc150-accel-core.c\n" @@ -55,521 +44,521 @@ "> > --- a/drivers/iio/accel/bmc150-accel-core.c\n" "> > +++ b/drivers/iio/accel/bmc150-accel-core.c\n" "> > @@ -188,7 +188,6 @@ enum bmc150_accel_trigger_id {\n" - "> > \302\240\n" - "> > \302\240struct bmc150_accel_data {\n" - "> > \302\240\tstruct regmap *regmap;\n" + "> > ?\n" + "> > ?struct bmc150_accel_data {\n" + "> > ?\tstruct regmap *regmap;\n" "> > -\tstruct device *dev;\n" - "> > \302\240\tint irq;\n" - "> > \302\240\tstruct bmc150_accel_interrupt\n" + "> > ?\tint irq;\n" + "> > ?\tstruct bmc150_accel_interrupt\n" "> > interrupts[BMC150_ACCEL_INTERRUPTS];\n" - "> > \302\240\tatomic_t active_intr;\n" + "> > ?\tatomic_t active_intr;\n" "> > @@ -256,6 +255,7 @@ static int bmc150_accel_set_mode(struct\n" "> > bmc150_accel_data *data,\n" - "> > \302\240\t\t\t\t\302\240enum bmc150_power_modes mode,\n" - "> > \302\240\t\t\t\t\302\240int dur_us)\n" - "> > \302\240{\n" + "> > ?\t\t\t\t?enum bmc150_power_modes mode,\n" + "> > ?\t\t\t\t?int dur_us)\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint i;\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tu8 lpw_bits;\n" + "> > ?\tint i;\n" + "> > ?\tint ret;\n" + "> > ?\tu8 lpw_bits;\n" "> > @@ -279,11 +279,11 @@ static int bmc150_accel_set_mode(struct\n" "> > bmc150_accel_data *data,\n" - "> > \302\240\tlpw_bits = mode << BMC150_ACCEL_PMU_MODE_SHIFT;\n" - "> > \302\240\tlpw_bits |= (dur_val <<\n" + "> > ?\tlpw_bits = mode << BMC150_ACCEL_PMU_MODE_SHIFT;\n" + "> > ?\tlpw_bits |= (dur_val <<\n" "> > BMC150_ACCEL_PMU_BIT_SLEEP_DUR_SHIFT);\n" - "> > \302\240\n" + "> > ?\n" "> > -\tdev_dbg(data->dev, \"Set Mode bits %x\\n\", lpw_bits);\n" "> > +\tdev_dbg(dev, \"Set Mode bits %x\\n\", lpw_bits);\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_write(data->regmap, BMC150_ACCEL_REG_PMU_LPW,\n" + "> > ?\n" + "> > ?\tret = regmap_write(data->regmap, BMC150_ACCEL_REG_PMU_LPW,\n" "> > lpw_bits);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error writing reg_pmu_lpw\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_pmu_lpw\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -316,23 +316,24 @@ static int bmc150_accel_set_bw(struct\n" "> > bmc150_accel_data *data, int val,\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_update_slope(struct bmc150_accel_data\n" + "> > ?\n" + "> > ?static int bmc150_accel_update_slope(struct bmc150_accel_data\n" "> > *data)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_write(data->regmap, BMC150_ACCEL_REG_INT_6,\n" - "> > \302\240\t\t\t\t\tdata->slope_thres);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tint ret;\n" + "> > ?\n" + "> > ?\tret = regmap_write(data->regmap, BMC150_ACCEL_REG_INT_6,\n" + "> > ?\t\t\t\t\tdata->slope_thres);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error writing reg_int_6\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_int_6\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_update_bits(data->regmap,\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" + "> > ?\tret = regmap_update_bits(data->regmap,\n" "> > BMC150_ACCEL_REG_INT_5,\n" - "> > \302\240\t\t\t\t\302\240BMC150_ACCEL_SLOPE_DUR_MASK,\n" + "> > ?\t\t\t\t?BMC150_ACCEL_SLOPE_DUR_MASK,\n" "> > data->slope_dur);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error updating reg_int_5\\n\");\n" "> > +\t\tdev_err(dev, \"Error updating reg_int_5\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > -\tdev_dbg(data->dev, \"%s: %x %x\\n\", __func__, data-\n" "> > >slope_thres,\n" "> > +\tdev_dbg(dev, \"%s: %x %x\\n\", __func__, data->slope_thres,\n" - "> > \302\240\t\tdata->slope_dur);\n" - "> > \302\240\n" - "> > \302\240\treturn ret;\n" + "> > ?\t\tdata->slope_dur);\n" + "> > ?\n" + "> > ?\treturn ret;\n" "> > @@ -378,20 +379,21 @@ static int\n" "> > bmc150_accel_get_startup_times(struct bmc150_accel_data *data)\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_set_power_state(struct bmc150_accel_data\n" + "> > ?\n" + "> > ?static int bmc150_accel_set_power_state(struct bmc150_accel_data\n" "> > *data, bool on)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" - "> > \302\240\tif (on) {\n" + "> > ?\tint ret;\n" + "> > ?\n" + "> > ?\tif (on) {\n" "> > -\t\tret = pm_runtime_get_sync(data->dev);\n" "> > +\t\tret = pm_runtime_get_sync(dev);\n" - "> > \302\240\t} else {\n" + "> > ?\t} else {\n" "> > -\t\tpm_runtime_mark_last_busy(data->dev);\n" "> > -\t\tret = pm_runtime_put_autosuspend(data->dev);\n" "> > +\t\tpm_runtime_mark_last_busy(dev);\n" "> > +\t\tret = pm_runtime_put_autosuspend(dev);\n" - "> > \302\240\t}\n" - "> > \302\240\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t}\n" + "> > ?\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev,\n" "> > +\t\tdev_err(dev,\n" - "> > \302\240\t\t\t\"Failed: bmc150_accel_set_power_state for\n" + "> > ?\t\t\t\"Failed: bmc150_accel_set_power_state for\n" "> > %d\\n\", on);\n" - "> > \302\240\t\tif (on)\n" + "> > ?\t\tif (on)\n" "> > -\t\t\tpm_runtime_put_noidle(data->dev);\n" "> > +\t\t\tpm_runtime_put_noidle(dev);\n" - "> > \302\240\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" + "> > ?\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" "> > @@ -445,6 +447,7 @@ static void\n" "> > bmc150_accel_interrupts_setup(struct iio_dev *indio_dev,\n" - "> > \302\240static int bmc150_accel_set_interrupt(struct bmc150_accel_data\n" + "> > ?static int bmc150_accel_set_interrupt(struct bmc150_accel_data\n" "> > *data, int i,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240bool state)\n" - "> > \302\240{\n" + "> > ?\t\t\t\t??????bool state)\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tstruct bmc150_accel_interrupt *intr = &data-\n" + "> > ?\tstruct bmc150_accel_interrupt *intr = &data-\n" "> > >interrupts[i];\n" - "> > \302\240\tconst struct bmc150_accel_interrupt_info *info = intr-\n" + "> > ?\tconst struct bmc150_accel_interrupt_info *info = intr-\n" "> > >info;\n" - "> > \302\240\tint ret;\n" + "> > ?\tint ret;\n" "> > @@ -474,7 +477,7 @@ static int bmc150_accel_set_interrupt(struct\n" "> > bmc150_accel_data *data, int i,\n" - "> > \302\240\tret = regmap_update_bits(data->regmap, info->map_reg,\n" + "> > ?\tret = regmap_update_bits(data->regmap, info->map_reg,\n" "> > info->map_bitmask,\n" - "> > \302\240\t\t\t\t\302\240(state ? info->map_bitmask : 0));\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t\t?(state ? info->map_bitmask : 0));\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error updating\n" "> > reg_int_map\\n\");\n" "> > +\t\tdev_err(dev, \"Error updating reg_int_map\\n\");\n" - "> > \302\240\t\tgoto out_fix_power_state;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\tgoto out_fix_power_state;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -482,7 +485,7 @@ static int bmc150_accel_set_interrupt(struct\n" "> > bmc150_accel_data *data, int i,\n" - "> > \302\240\tret = regmap_update_bits(data->regmap, info->en_reg, info-\n" + "> > ?\tret = regmap_update_bits(data->regmap, info->en_reg, info-\n" "> > >en_bitmask,\n" - "> > \302\240\t\t\t\t\302\240(state ? info->en_bitmask : 0));\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t\t?(state ? info->en_bitmask : 0));\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error updating reg_int_en\\n\");\n" "> > +\t\tdev_err(dev, \"Error updating reg_int_en\\n\");\n" - "> > \302\240\t\tgoto out_fix_power_state;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\tgoto out_fix_power_state;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -500,6 +503,7 @@ out_fix_power_state:\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_set_scale(struct bmc150_accel_data *data,\n" + "> > ?\n" + "> > ?static int bmc150_accel_set_scale(struct bmc150_accel_data *data,\n" "> > int val)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret, i;\n" - "> > \302\240\n" - "> > \302\240\tfor (i = 0; i < ARRAY_SIZE(data->chip_info->scale_table);\n" + "> > ?\tint ret, i;\n" + "> > ?\n" + "> > ?\tfor (i = 0; i < ARRAY_SIZE(data->chip_info->scale_table);\n" "> > ++i) {\n" "> > @@ -508,8 +512,7 @@ static int bmc150_accel_set_scale(struct\n" "> > bmc150_accel_data *data, int val)\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240BMC150_ACCEL_REG_PMU_RANGE,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240data->chip_info-\n" + "> > ?\t\t\t\t?????BMC150_ACCEL_REG_PMU_RANGE,\n" + "> > ?\t\t\t\t?????data->chip_info-\n" "> > >scale_table[i].reg_range);\n" - "> > \302\240\t\t\tif (ret < 0) {\n" + "> > ?\t\t\tif (ret < 0) {\n" "> > -\t\t\t\tdev_err(data->dev,\n" "> > -\t\t\t\t\t\"Error writing\n" "> > pmu_range\\n\");\n" "> > +\t\t\t\tdev_err(dev, \"Error writing\n" "> > pmu_range\\n\");\n" - "> > \302\240\t\t\t\treturn ret;\n" - "> > \302\240\t\t\t}\n" - "> > \302\240\n" + "> > ?\t\t\t\treturn ret;\n" + "> > ?\t\t\t}\n" + "> > ?\n" "> > @@ -523,6 +526,7 @@ static int bmc150_accel_set_scale(struct\n" "> > bmc150_accel_data *data, int val)\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_get_temp(struct bmc150_accel_data *data,\n" + "> > ?\n" + "> > ?static int bmc150_accel_get_temp(struct bmc150_accel_data *data,\n" "> > int *val)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tunsigned int value;\n" - "> > \302\240\n" + "> > ?\tint ret;\n" + "> > ?\tunsigned int value;\n" + "> > ?\n" "> > @@ -530,7 +534,7 @@ static int bmc150_accel_get_temp(struct\n" "> > bmc150_accel_data *data, int *val)\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_read(data->regmap, BMC150_ACCEL_REG_TEMP,\n" + "> > ?\n" + "> > ?\tret = regmap_read(data->regmap, BMC150_ACCEL_REG_TEMP,\n" "> > &value);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error reading reg_temp\\n\");\n" "> > +\t\tdev_err(dev, \"Error reading reg_temp\\n\");\n" - "> > \302\240\t\tmutex_unlock(&data->mutex);\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" + "> > ?\t\tmutex_unlock(&data->mutex);\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" "> > @@ -545,6 +549,7 @@ static int bmc150_accel_get_axis(struct\n" "> > bmc150_accel_data *data,\n" - "> > \302\240\t\t\t\t\302\240struct iio_chan_spec const *chan,\n" - "> > \302\240\t\t\t\t\302\240int *val)\n" - "> > \302\240{\n" + "> > ?\t\t\t\t?struct iio_chan_spec const *chan,\n" + "> > ?\t\t\t\t?int *val)\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tint axis = chan->scan_index;\n" - "> > \302\240\tunsigned int raw_val;\n" + "> > ?\tint ret;\n" + "> > ?\tint axis = chan->scan_index;\n" + "> > ?\tunsigned int raw_val;\n" "> > @@ -559,7 +564,7 @@ static int bmc150_accel_get_axis(struct\n" "> > bmc150_accel_data *data,\n" - "> > \302\240\tret = regmap_bulk_read(data->regmap,\n" + "> > ?\tret = regmap_bulk_read(data->regmap,\n" "> > BMC150_ACCEL_AXIS_TO_REG(axis),\n" - "> > \302\240\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240&raw_val, 2);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t???????&raw_val, 2);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error reading axis %d\\n\",\n" "> > axis);\n" "> > +\t\tdev_err(dev, \"Error reading axis %d\\n\", axis);\n" - "> > \302\240\t\tbmc150_accel_set_power_state(data, false);\n" - "> > \302\240\t\tmutex_unlock(&data->mutex);\n" - "> > \302\240\t\treturn ret;\n" + "> > ?\t\tbmc150_accel_set_power_state(data, false);\n" + "> > ?\t\tmutex_unlock(&data->mutex);\n" + "> > ?\t\treturn ret;\n" "> > @@ -831,6 +836,7 @@ static int bmc150_accel_set_watermark(struct\n" "> > iio_dev *indio_dev, unsigned val)\n" - "> > \302\240static int bmc150_accel_fifo_transfer(struct bmc150_accel_data\n" + "> > ?static int bmc150_accel_fifo_transfer(struct bmc150_accel_data\n" "> > *data,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240char *buffer, int samples)\n" - "> > \302\240{\n" + "> > ?\t\t\t\t??????char *buffer, int samples)\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint sample_length = 3 * 2;\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tint total_length = samples * sample_length;\n" + "> > ?\tint sample_length = 3 * 2;\n" + "> > ?\tint ret;\n" + "> > ?\tint total_length = samples * sample_length;\n" "> > @@ -854,7 +860,8 @@ static int bmc150_accel_fifo_transfer(struct\n" "> > bmc150_accel_data *data,\n" - "> > \302\240\t}\n" - "> > \302\240\n" - "> > \302\240\tif (ret)\n" + "> > ?\t}\n" + "> > ?\n" + "> > ?\tif (ret)\n" "> > -\t\tdev_err(data->dev, \"Error transferring data from\n" "> > fifo in single steps of %zu\\n\",\n" "> > +\t\tdev_err(dev,\n" "> > +\t\t\t\"Error transferring data from fifo in\n" "> > single steps of %zu\\n\",\n" - "> > \302\240\t\t\tstep);\n" - "> > \302\240\n" - "> > \302\240\treturn ret;\n" + "> > ?\t\t\tstep);\n" + "> > ?\n" + "> > ?\treturn ret;\n" "> > @@ -864,6 +871,7 @@ static int __bmc150_accel_fifo_flush(struct\n" "> > iio_dev *indio_dev,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240unsigned samples, bool irq)\n" - "> > \302\240{\n" - "> > \302\240\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" + "> > ?\t\t\t\t?????unsigned samples, bool irq)\n" + "> > ?{\n" + "> > ?\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret, i;\n" - "> > \302\240\tu8 count;\n" - "> > \302\240\tu16 buffer[BMC150_ACCEL_FIFO_LENGTH * 3];\n" + "> > ?\tint ret, i;\n" + "> > ?\tu8 count;\n" + "> > ?\tu16 buffer[BMC150_ACCEL_FIFO_LENGTH * 3];\n" "> > @@ -873,7 +881,7 @@ static int __bmc150_accel_fifo_flush(struct\n" "> > iio_dev *indio_dev,\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_read(data->regmap,\n" + "> > ?\n" + "> > ?\tret = regmap_read(data->regmap,\n" "> > BMC150_ACCEL_REG_FIFO_STATUS, &val);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error reading\n" "> > reg_fifo_status\\n\");\n" "> > +\t\tdev_err(dev, \"Error reading reg_fifo_status\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1135,6 +1143,7 @@ static int bmc150_accel_trig_try_reen(struct\n" "> > iio_trigger *trig)\n" - "> > \302\240{\n" - "> > \302\240\tstruct bmc150_accel_trigger *t =\n" + "> > ?{\n" + "> > ?\tstruct bmc150_accel_trigger *t =\n" "> > iio_trigger_get_drvdata(trig);\n" - "> > \302\240\tstruct bmc150_accel_data *data = t->data;\n" + "> > ?\tstruct bmc150_accel_data *data = t->data;\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" - "> > \302\240\t/* new data interrupts don't need ack */\n" + "> > ?\tint ret;\n" + "> > ?\n" + "> > ?\t/* new data interrupts don't need ack */\n" "> > @@ -1148,8 +1157,7 @@ static int bmc150_accel_trig_try_reen(struct\n" "> > iio_trigger *trig)\n" - "> > \302\240\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_RESET);\n" - "> > \302\240\tmutex_unlock(&data->mutex);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_RESET);\n" + "> > ?\tmutex_unlock(&data->mutex);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev,\n" "> > -\t\t\t\"Error writing reg_int_rst_latch\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_int_rst_latch\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1200,13 +1208,14 @@ static const struct iio_trigger_ops\n" "> > bmc150_accel_trigger_ops = {\n" - "> > \302\240static int bmc150_accel_handle_roc_event(struct iio_dev\n" + "> > ?static int bmc150_accel_handle_roc_event(struct iio_dev\n" "> > *indio_dev)\n" - "> > \302\240{\n" - "> > \302\240\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" + "> > ?{\n" + "> > ?\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint dir;\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tunsigned int val;\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_read(data->regmap,\n" + "> > ?\tint dir;\n" + "> > ?\tint ret;\n" + "> > ?\tunsigned int val;\n" + "> > ?\n" + "> > ?\tret = regmap_read(data->regmap,\n" "> > BMC150_ACCEL_REG_INT_STATUS_2, &val);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error reading\n" "> > reg_int_status_2\\n\");\n" "> > +\t\tdev_err(dev, \"Error reading reg_int_status_2\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1249,6 +1258,7 @@ static irqreturn_t\n" "> > bmc150_accel_irq_thread_handler(int irq, void *private)\n" - "> > \302\240{\n" - "> > \302\240\tstruct iio_dev *indio_dev = private;\n" - "> > \302\240\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" + "> > ?{\n" + "> > ?\tstruct iio_dev *indio_dev = private;\n" + "> > ?\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tbool ack = false;\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" + "> > ?\tbool ack = false;\n" + "> > ?\tint ret;\n" + "> > ?\n" "> > @@ -1272,7 +1282,7 @@ static irqreturn_t\n" "> > bmc150_accel_irq_thread_handler(int irq, void *private)\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_INT\n" + "> > ?\t\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_INT\n" "> > |\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_RES\n" + "> > ?\t\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_RES\n" "> > ET);\n" - "> > \302\240\t\tif (ret)\n" + "> > ?\t\tif (ret)\n" "> > -\t\t\tdev_err(data->dev, \"Error writing\n" "> > reg_int_rst_latch\\n\");\n" "> > +\t\t\tdev_err(dev, \"Error writing\n" "> > reg_int_rst_latch\\n\");\n" - "> > \302\240\n" - "> > \302\240\t\tret = IRQ_HANDLED;\n" - "> > \302\240\t} else {\n" + "> > ?\n" + "> > ?\t\tret = IRQ_HANDLED;\n" + "> > ?\t} else {\n" "> > @@ -1343,13 +1353,14 @@ static void\n" "> > bmc150_accel_unregister_triggers(struct bmc150_accel_data *data,\n" - "> > \302\240static int bmc150_accel_triggers_setup(struct iio_dev *indio_dev,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240struct bmc150_accel_data\n" + "> > ?static int bmc150_accel_triggers_setup(struct iio_dev *indio_dev,\n" + "> > ?\t\t\t\t???????struct bmc150_accel_data\n" "> > *data)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint i, ret;\n" - "> > \302\240\n" - "> > \302\240\tfor (i = 0; i < BMC150_ACCEL_TRIGGERS; i++) {\n" - "> > \302\240\t\tstruct bmc150_accel_trigger *t = &data-\n" + "> > ?\tint i, ret;\n" + "> > ?\n" + "> > ?\tfor (i = 0; i < BMC150_ACCEL_TRIGGERS; i++) {\n" + "> > ?\t\tstruct bmc150_accel_trigger *t = &data-\n" "> > >triggers[i];\n" - "> > \302\240\n" + "> > ?\n" "> > -\t\tt->indio_trig = devm_iio_trigger_alloc(data->dev,\n" - "> > -\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240bmc150_accel_trigge\n" + "> > -\t\t\t\t\t???????bmc150_accel_trigge\n" "> > rs[i].name,\n" "> > +\t\tt->indio_trig = devm_iio_trigger_alloc(dev,\n" "> > +\t\t\t\t\tbmc150_accel_triggers[i].n\n" "> > ame,\n" - "> > \302\240\t\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240indio_dev-\n" + "> > ?\t\t\t\t\t\t???????indio_dev-\n" "> > >name,\n" - "> > \302\240\t\t\t\t\t\t\302\240\302\240\302\240\302\240\302\240\302\240\302\240indio_dev-\n" + "> > ?\t\t\t\t\t\t???????indio_dev-\n" "> > >id);\n" - "> > \302\240\t\tif (!t->indio_trig) {\n" + "> > ?\t\tif (!t->indio_trig) {\n" "> > @@ -1357,7 +1368,7 @@ static int bmc150_accel_triggers_setup(struct\n" "> > iio_dev *indio_dev,\n" - "> > \302\240\t\t\tbreak;\n" - "> > \302\240\t\t}\n" - "> > \302\240\n" + "> > ?\t\t\tbreak;\n" + "> > ?\t\t}\n" + "> > ?\n" "> > -\t\tt->indio_trig->dev.parent = data->dev;\n" "> > +\t\tt->indio_trig->dev.parent = dev;\n" - "> > \302\240\t\tt->indio_trig->ops = &bmc150_accel_trigger_ops;\n" - "> > \302\240\t\tt->intr = bmc150_accel_triggers[i].intr;\n" - "> > \302\240\t\tt->data = data;\n" + "> > ?\t\tt->indio_trig->ops = &bmc150_accel_trigger_ops;\n" + "> > ?\t\tt->intr = bmc150_accel_triggers[i].intr;\n" + "> > ?\t\tt->data = data;\n" "> > @@ -1381,12 +1392,13 @@ static int\n" "> > bmc150_accel_triggers_setup(struct iio_dev *indio_dev,\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_fifo_set_mode(struct bmc150_accel_data\n" + "> > ?\n" + "> > ?static int bmc150_accel_fifo_set_mode(struct bmc150_accel_data\n" "> > *data)\n" - "> > \302\240{\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tu8 reg = BMC150_ACCEL_REG_FIFO_CONFIG1;\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_write(data->regmap, reg, data->fifo_mode);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tu8 reg = BMC150_ACCEL_REG_FIFO_CONFIG1;\n" + "> > ?\tint ret;\n" + "> > ?\n" + "> > ?\tret = regmap_write(data->regmap, reg, data->fifo_mode);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Error writing\n" "> > reg_fifo_config1\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_fifo_config1\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1396,7 +1408,7 @@ static int bmc150_accel_fifo_set_mode(struct\n" "> > bmc150_accel_data *data)\n" - "> > \302\240\tret = regmap_write(data->regmap,\n" + "> > ?\tret = regmap_write(data->regmap,\n" "> > BMC150_ACCEL_REG_FIFO_CONFIG0,\n" - "> > \302\240\t\t\t\302\240\302\240\302\240data->watermark);\n" - "> > \302\240\tif (ret < 0)\n" + "> > ?\t\t\t???data->watermark);\n" + "> > ?\tif (ret < 0)\n" "> > -\t\tdev_err(data->dev, \"Error writing\n" "> > reg_fifo_config0\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_fifo_config0\\n\");\n" - "> > \302\240\n" - "> > \302\240\treturn ret;\n" - "> > \302\240}\n" + "> > ?\n" + "> > ?\treturn ret;\n" + "> > ?}\n" "> > @@ -1480,17 +1492,17 @@ static const struct iio_buffer_setup_ops\n" "> > bmc150_accel_buffer_ops = {\n" - "> > \302\240\n" - "> > \302\240static int bmc150_accel_chip_init(struct bmc150_accel_data *data)\n" - "> > \302\240{\n" + "> > ?\n" + "> > ?static int bmc150_accel_chip_init(struct bmc150_accel_data *data)\n" + "> > ?{\n" "> > +\tstruct device *dev = regmap_get_device(data->regmap);\n" - "> > \302\240\tint ret, i;\n" - "> > \302\240\tunsigned int val;\n" - "> > \302\240\n" - "> > \302\240\tret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID,\n" + "> > ?\tint ret, i;\n" + "> > ?\tunsigned int val;\n" + "> > ?\n" + "> > ?\tret = regmap_read(data->regmap, BMC150_ACCEL_REG_CHIP_ID,\n" "> > &val);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev,\n" "> > -\t\t\t\"Error: Reading chip id\\n\");\n" "> > +\t\tdev_err(dev, \"Error: Reading chip id\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > -\tdev_dbg(data->dev, \"Chip Id %x\\n\", val);\n" "> > +\tdev_dbg(dev, \"Chip Id %x\\n\", val);\n" - "> > \302\240\tfor (i = 0; i < ARRAY_SIZE(bmc150_accel_chip_info_tbl);\n" + "> > ?\tfor (i = 0; i < ARRAY_SIZE(bmc150_accel_chip_info_tbl);\n" "> > i++) {\n" - "> > \302\240\t\tif (bmc150_accel_chip_info_tbl[i].chip_id == val)\n" + "> > ?\t\tif (bmc150_accel_chip_info_tbl[i].chip_id == val)\n" "> > {\n" - "> > \302\240\t\t\tdata->chip_info =\n" + "> > ?\t\t\tdata->chip_info =\n" "> > &bmc150_accel_chip_info_tbl[i];\n" "> > @@ -1499,7 +1511,7 @@ static int bmc150_accel_chip_init(struct\n" "> > bmc150_accel_data *data)\n" - "> > \302\240\t}\n" - "> > \302\240\n" - "> > \302\240\tif (!data->chip_info) {\n" + "> > ?\t}\n" + "> > ?\n" + "> > ?\tif (!data->chip_info) {\n" "> > -\t\tdev_err(data->dev, \"Invalid chip %x\\n\", val);\n" "> > +\t\tdev_err(dev, \"Invalid chip %x\\n\", val);\n" - "> > \302\240\t\treturn -ENODEV;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn -ENODEV;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1516,8 +1528,7 @@ static int bmc150_accel_chip_init(struct\n" "> > bmc150_accel_data *data)\n" - "> > \302\240\tret = regmap_write(data->regmap,\n" + "> > ?\tret = regmap_write(data->regmap,\n" "> > BMC150_ACCEL_REG_PMU_RANGE,\n" - "> > \302\240\t\t\t\302\240\302\240\302\240BMC150_ACCEL_DEF_RANGE_4G);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t???BMC150_ACCEL_DEF_RANGE_4G);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev,\n" "> > -\t\t\t\t\t\"Error writing\n" "> > reg_pmu_range\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_pmu_range\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1535,8 +1546,7 @@ static int bmc150_accel_chip_init(struct\n" "> > bmc150_accel_data *data)\n" - "> > \302\240\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_INT |\n" - "> > \302\240\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_RESET);\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_INT |\n" + "> > ?\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_RESET);\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev,\n" "> > -\t\t\t\"Error writing reg_int_rst_latch\\n\");\n" "> > +\t\tdev_err(dev, \"Error writing reg_int_rst_latch\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" "> > @@ -1556,7 +1566,6 @@ int bmc150_accel_core_probe(struct device\n" "> > *dev, struct regmap *regmap, int irq,\n" - "> > \302\240\n" - "> > \302\240\tdata = iio_priv(indio_dev);\n" - "> > \302\240\tdev_set_drvdata(dev, indio_dev);\n" + "> > ?\n" + "> > ?\tdata = iio_priv(indio_dev);\n" + "> > ?\tdev_set_drvdata(dev, indio_dev);\n" "> > -\tdata->dev = dev;\n" - "> > \302\240\tdata->irq = irq;\n" - "> > \302\240\n" - "> > \302\240\tdata->regmap = regmap;\n" + "> > ?\tdata->irq = irq;\n" + "> > ?\n" + "> > ?\tdata->regmap = regmap;\n" "> > @@ -1580,13 +1589,13 @@ int bmc150_accel_core_probe(struct device\n" "> > *dev, struct regmap *regmap, int irq,\n" - "> > \302\240\t\t\t\t\t\302\240bmc150_accel_trigger_hand\n" + "> > ?\t\t\t\t\t?bmc150_accel_trigger_hand\n" "> > ler,\n" - "> > \302\240\t\t\t\t\t\302\240&bmc150_accel_buffer_ops)\n" + "> > ?\t\t\t\t\t?&bmc150_accel_buffer_ops)\n" "> > ;\n" - "> > \302\240\tif (ret < 0) {\n" + "> > ?\tif (ret < 0) {\n" "> > -\t\tdev_err(data->dev, \"Failed: iio triggered buffer\n" "> > setup\\n\");\n" "> > +\t\tdev_err(dev, \"Failed: iio triggered buffer\n" "> > setup\\n\");\n" - "> > \302\240\t\treturn ret;\n" - "> > \302\240\t}\n" - "> > \302\240\n" - "> > \302\240\tif (data->irq > 0) {\n" - "> > \302\240\t\tret = devm_request_threaded_irq(\n" + "> > ?\t\treturn ret;\n" + "> > ?\t}\n" + "> > ?\n" + "> > ?\tif (data->irq > 0) {\n" + "> > ?\t\tret = devm_request_threaded_irq(\n" "> > -\t\t\t\t\t\tdata->dev, data-\n" "> > >irq,\n" "> > +\t\t\t\t\t\tdev, data->irq,\n" - "> > \302\240\t\t\t\t\t\tbmc150_accel_irq_h\n" + "> > ?\t\t\t\t\t\tbmc150_accel_irq_h\n" "> > andler,\n" - "> > \302\240\t\t\t\t\t\tbmc150_accel_irq_t\n" + "> > ?\t\t\t\t\t\tbmc150_accel_irq_t\n" "> > hread_handler,\n" - "> > \302\240\t\t\t\t\t\tIRQF_TRIGGER_RISIN\n" + "> > ?\t\t\t\t\t\tIRQF_TRIGGER_RISIN\n" "> > G,\n" "> > @@ -1604,7 +1613,7 @@ int bmc150_accel_core_probe(struct device\n" "> > *dev, struct regmap *regmap, int irq,\n" - "> > \302\240\t\tret = regmap_write(data->regmap,\n" + "> > ?\t\tret = regmap_write(data->regmap,\n" "> > BMC150_ACCEL_REG_INT_RST_LATCH,\n" - "> > \302\240\t\t\t\t\302\240\302\240\302\240BMC150_ACCEL_INT_MODE_LATCH_RES\n" + "> > ?\t\t\t\t???BMC150_ACCEL_INT_MODE_LATCH_RES\n" "> > ET);\n" - "> > \302\240\t\tif (ret < 0) {\n" + "> > ?\t\tif (ret < 0) {\n" "> > -\t\t\tdev_err(data->dev, \"Error writing\n" "> > reg_int_rst_latch\\n\");\n" "> > +\t\t\tdev_err(dev, \"Error writing\n" "> > reg_int_rst_latch\\n\");\n" - "> > \302\240\t\t\tgoto err_buffer_cleanup;\n" - "> > \302\240\t\t}\n" - "> > \302\240\n" + "> > ?\t\t\tgoto err_buffer_cleanup;\n" + "> > ?\t\t}\n" + "> > ?\n" "> > @@ -1653,9 +1662,9 @@ int bmc150_accel_core_remove(struct device\n" "> > *dev)\n" - "> > \302\240\n" - "> > \302\240\tiio_device_unregister(indio_dev);\n" - "> > \302\240\n" + "> > ?\n" + "> > ?\tiio_device_unregister(indio_dev);\n" + "> > ?\n" "> > -\tpm_runtime_disable(data->dev);\n" "> > -\tpm_runtime_set_suspended(data->dev);\n" "> > -\tpm_runtime_put_noidle(data->dev);\n" "> > +\tpm_runtime_disable(dev);\n" "> > +\tpm_runtime_set_suspended(dev);\n" "> > +\tpm_runtime_put_noidle(dev);\n" - "> > \302\240\n" - "> > \302\240\tbmc150_accel_unregister_triggers(data,\n" + "> > ?\n" + "> > ?\tbmc150_accel_unregister_triggers(data,\n" "> > BMC150_ACCEL_TRIGGERS - 1);\n" - "> > \302\240\n" + "> > ?\n" "> > @@ -1704,7 +1713,7 @@ static int\n" "> > bmc150_accel_runtime_suspend(struct device *dev)\n" - "> > \302\240\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" - "> > \302\240\tint ret;\n" - "> > \302\240\n" - "> > -\tdev_dbg(data->dev,\302\240\302\240__func__);\n" - "> > +\tdev_dbg(dev,\302\240\302\240__func__);\n" - "> > \302\240\tret = bmc150_accel_set_mode(data,\n" + "> > ?\tstruct bmc150_accel_data *data = iio_priv(indio_dev);\n" + "> > ?\tint ret;\n" + "> > ?\n" + "> > -\tdev_dbg(data->dev,??__func__);\n" + "> > +\tdev_dbg(dev,??__func__);\n" + "> > ?\tret = bmc150_accel_set_mode(data,\n" "> > BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0);\n" - "> > \302\240\tif (ret < 0)\n" - "> > \302\240\t\treturn -EAGAIN;\n" + "> > ?\tif (ret < 0)\n" + "> > ?\t\treturn -EAGAIN;\n" "> > @@ -1719,7 +1728,7 @@ static int bmc150_accel_runtime_resume(struct\n" "> > device *dev)\n" - "> > \302\240\tint ret;\n" - "> > \302\240\tint sleep_val;\n" - "> > \302\240\n" - "> > -\tdev_dbg(data->dev,\302\240\302\240__func__);\n" - "> > +\tdev_dbg(dev,\302\240\302\240__func__);\n" - "> > \302\240\n" - "> > \302\240\tret = bmc150_accel_set_mode(data,\n" + "> > ?\tint ret;\n" + "> > ?\tint sleep_val;\n" + "> > ?\n" + "> > -\tdev_dbg(data->dev,??__func__);\n" + "> > +\tdev_dbg(dev,??__func__);\n" + "> > ?\n" + "> > ?\tret = bmc150_accel_set_mode(data,\n" "> > BMC150_ACCEL_SLEEP_MODE_NORMAL, 0);\n" - "> > \302\240\tif (ret < 0)\n" + "> > ?\tif (ret < 0)\n" > > -8754b54c28ee8ff2b0bcb9f47d61e53c003050e7ec9275972be4a3b0e5a589d4 +280407d2284e828103b2abe44ac667ea23603080fe25669d8dd439de8ba09b4b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.