From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Date: Tue, 19 Apr 2016 23:24:42 -0700 Subject: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) In-Reply-To: <1461118677-28142-2-git-send-email-kys@microsoft.com> References: <1461118655-28103-1-git-send-email-kys@microsoft.com> <1461118677-28142-1-git-send-email-kys@microsoft.com> <1461118677-28142-2-git-send-email-kys@microsoft.com> Message-ID: <1461133482.2923.28.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. > > Signed-off-by: K. Y. Srinivasan > --- > ????????V2: Addressed most of the comments from > ??????????? Alexander Duyck > ??????????? and Rustad, Mark D . > > ????????V3: Addressed additional comments from > ??????????? Alexander Duyck > > ????????V4: Addressed kbuild errors reported by: > ??????????? kbuild test robot > > ????????V5: Addressed additional comments from > ??????????? Alexander Duyck First I commend you on actually making a proper changelog for a patch. ?The only issue I have is that the changelog provides not actual changes. ?Saying you reacted to comments does not summarize what the actual changes were. ?I purposely did not review the earlier versions because by the time I went to do a review, there was another version already submitted. ?So your changelog requires that users look at all the previous emails to actually see what Alex and Mark requested in changes. I am telling you this for future patches, it will not impact these patches, just really disappointing. ?I will take the extra time to track down all the previous emails and the changes requested to ensure you made all the changes that were requested of you. :-( ?This will just delay when I apply the patches for testing. > > ?drivers/net/ethernet/intel/ixgbevf/ixgbevf.h????? |?? 12 ++ > ?drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |?? 31 +++- > ?drivers/net/ethernet/intel/ixgbevf/mbx.c????????? |?? 12 ++ > ?drivers/net/ethernet/intel/ixgbevf/vf.c?????????? |? 216 > +++++++++++++++++++++ > ?drivers/net/ethernet/intel/ixgbevf/vf.h?????????? |??? 2 + > ?5 files changed, 266 insertions(+), 7 deletions(-) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbcDTGYr (ORCPT ); Wed, 20 Apr 2016 02:24:47 -0400 Received: from mga03.intel.com ([134.134.136.65]:6406 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750762AbcDTGYq (ORCPT ); Wed, 20 Apr 2016 02:24:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,508,1455004800"; d="asc'?scan'208";a="88443486" Message-ID: <1461133482.2923.28.camel@intel.com> Subject: Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) From: Jeff Kirsher To: "K. Y. Srinivasan" , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com, eli@mellanox.com, jackm@mellanox.com, yevgenyp@mellanox.com, john.ronciak@intel.com, intel-wired-lan@lists.osuosl.org, alexander.duyck@gmail.com Date: Tue, 19 Apr 2016 23:24:42 -0700 In-Reply-To: <1461118677-28142-2-git-send-email-kys@microsoft.com> References: <1461118655-28103-1-git-send-email-kys@microsoft.com> <1461118677-28142-1-git-send-email-kys@microsoft.com> <1461118677-28142-2-git-send-email-kys@microsoft.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Kkir4QACtr8b7lCaI9xB" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-Kkir4QACtr8b7lCaI9xB Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote: > On Hyper-V, the VF/PF communication is a via software mediated path > as opposed to the hardware mailbox. Make the necessary > adjustments to support Hyper-V. >=20 > Signed-off-by: K. Y. Srinivasan > --- > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0V2: Addressed most of the= comments from > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Alexan= der Duyck > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 and Ru= stad, Mark D . >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0V3: Addressed additional = comments from > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Alexan= der Duyck >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0V4: Addressed kbuild erro= rs reported by: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kbuild= test robot >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0V5: Addressed additional = comments from > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Alexan= der Duyck First I commend you on actually making a proper changelog for a patch. =C2=A0The only issue I have is that the changelog provides not actual changes. =C2=A0Saying you reacted to comments does not summarize what the actual changes were. =C2=A0I purposely did not review the earlier versions because by the time I went to do a review, there was another version already submitted. =C2=A0So your changelog requires that users look at all the previous emails to actually see what Alex and Mark requested in changes. I am telling you this for future patches, it will not impact these patches, just really disappointing. =C2=A0I will take the extra time to track down all the previous emails and the changes requested to ensure you made all the changes that were requested of you. :-( =C2=A0This will just delay when I apply the patches for testing. >=20 > =C2=A0drivers/net/ethernet/intel/ixgbevf/ixgbevf.h=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 12 ++ > =C2=A0drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |=C2=A0=C2=A0 31 = +++- > =C2=A0drivers/net/ethernet/intel/ixgbevf/mbx.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 12 ++ > =C2=A0drivers/net/ethernet/intel/ixgbevf/vf.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 216 > +++++++++++++++++++++ > =C2=A0drivers/net/ethernet/intel/ixgbevf/vf.h=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 2 + > =C2=A05 files changed, 266 insertions(+), 7 deletions(-) --=-Kkir4QACtr8b7lCaI9xB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXFyCqAAoJEOVv75VaS+3OXs0QAIhD7cnzNvXnaxpJtQCEPHw0 X9pHxLNsm8tDkEvA5LesQN+03SD8APowE6OO5oe7ZOM2XenOTMpsiPpKOcQWR0tQ 3sZCADEVzelHoox1erppIlhjb2BG3HsZNNJ87TsAQNmbs5iLatFtAgct/PC+w3rc xvjjIdV652oY6yX38/a2BVQwACtZIz1PgGa2d2LBL3TQi5/6frXNfVgiVfSOe3DP EOBp3Jk6aG8hfyrFupOKzOXI8nXVaCeD+YgJvKdOrEwXi+LC8BXCtw2dLoCv7lq9 A0mqn1i+A+nXV1DOZ3HBvv0iJ+DKNd5abRSVlU/VxW+lrB3hyTRQYeRlt6BpSJhM Q1/I8QNt+eJmI7+jyKNaKsfyP3qjo6E8msIGFVeM0DpCRVBUJIcTdE6yNzoCyAl4 n/BKAvt9b++m7KfXg1n2I5QE6o7R1/PU04uInuMK0988vC1vLtA9mAL53xh/Fdr8 YJIoTMoTMXvXZGBOx/QB23T4usAd7EHHtYlFYpmvy2uXAXh3ByF1bJMk5opeE4OT HYL8f+H4phxSzrAZhyaE9bHpT/JJqZUexNfUZZlpOBBVhLpwSiNQIqR3STd2+/6L HEq0JBVdPxBhVclcSQkevCorFJyC3Is0psgU0ah88ngBevYo8s7MM/cY1hIhmJR6 dKtPxpE/8GRE+9+YpvIR =aiXL -----END PGP SIGNATURE----- --=-Kkir4QACtr8b7lCaI9xB--