diff for duplicates of <1461161760.6620.306.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index ea0f276..82d120d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -7,8 +7,8 @@ On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: > > > > Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > --- -> > drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++ -> > 1 file changed, 2 insertions(+) +> > ? drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++ +> > ? 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c > > b/drivers/i2c/busses/i2c-designware-platdrv.c @@ -16,25 +16,25 @@ On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote: > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c > > @@ -268,6 +268,8 @@ rpm_disable: -> > pm_runtime_put_noidle(&pdev->dev); -> > } +> > ?? pm_runtime_put_noidle(&pdev->dev); +> > ?? } > > > > + i2c_dw_plat_prepare_clk(dev, false); > > + -> > return r; -> > } +> > ?? return r; +> > ? } > > > This is a bit unclear to me does devm_clk_get take care of clk -> disabling +> disabling? > in case of probe error or driver removal? > -> I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions -> (devm_*)") removed it but at quick look drivers/clk/clk-devres.c: -> devm_clk_release() calls only clk_put and I don't see disable is done +> I see Andy's 1cb715ca4694 ("i2c-designware: move to managed functions? +> (devm_*)") removed it but at quick look drivers/clk/clk-devres.c:? +> devm_clk_release() calls only clk_put and I don't see disable is done? > down the path. The following is a mistake of the mentioned patch. -- clk_disable_unprepare(dev->clk); +-???????clk_disable_unprepare(dev->clk); I did at the same mistake in dw_dmac driver which had been fixed later in the commit 8be4f523b480 ("dmaengine: dw: fix regression in dw_probe() diff --git a/a/content_digest b/N1/content_digest index a9c28a3..1a0056c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,16 +1,10 @@ "ref\01460638414-5987-1-git-send-email-jszhang@marvell.com\0" "ref\01460638414-5987-3-git-send-email-jszhang@marvell.com\0" "ref\057177C32.4090000@linux.intel.com\0" - "From\0Andy Shevchenko <andriy.shevchenko@linux.intel.com>\0" - "Subject\0Re: [PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare\0" + "From\0andriy.shevchenko@linux.intel.com (Andy Shevchenko)\0" + "Subject\0[PATCH 2/4] i2c: designware-platdrv: fix unbalanced clk enable and prepare\0" "Date\0Wed, 20 Apr 2016 17:16:00 +0300\0" - "To\0Jarkko Nikula <jarkko.nikula@linux.intel.com>" - Jisheng Zhang <jszhang@marvell.com> - mika.westerberg@linux.intel.com - " wsa@the-dreams.de\0" - "Cc\0linux-i2c@vger.kernel.org" - linux-kernel@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Wed, 2016-04-20 at 15:55 +0300, Jarkko Nikula wrote:\n" @@ -22,8 +16,8 @@ "> > \n" "> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>\n" "> > ---\n" - "> > \302\240 drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++\n" - "> > \302\240 1 file changed, 2 insertions(+)\n" + "> > ? drivers/i2c/busses/i2c-designware-platdrv.c | 2 ++\n" + "> > ? 1 file changed, 2 insertions(+)\n" "> > \n" "> > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c\n" "> > b/drivers/i2c/busses/i2c-designware-platdrv.c\n" @@ -31,25 +25,25 @@ "> > --- a/drivers/i2c/busses/i2c-designware-platdrv.c\n" "> > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c\n" "> > @@ -268,6 +268,8 @@ rpm_disable:\n" - "> > \302\240\302\240\t\tpm_runtime_put_noidle(&pdev->dev);\n" - "> > \302\240\302\240\t}\n" + "> > ??\t\tpm_runtime_put_noidle(&pdev->dev);\n" + "> > ??\t}\n" "> > \n" "> > +\ti2c_dw_plat_prepare_clk(dev, false);\n" "> > +\n" - "> > \302\240\302\240\treturn r;\n" - "> > \302\240 }\n" + "> > ??\treturn r;\n" + "> > ? }\n" "> > \n" "> This is a bit unclear to me does devm_clk_get take care of clk\n" - "> disabling\302\240\n" + "> disabling?\n" "> in case of probe error or driver removal?\n" "> \n" - "> I see Andy's 1cb715ca4694 (\"i2c-designware: move to managed functions\302\240\n" - "> (devm_*)\") removed it but at quick look drivers/clk/clk-devres.c:\302\240\n" - "> devm_clk_release() calls only clk_put and I don't see disable is done\302\240\n" + "> I see Andy's 1cb715ca4694 (\"i2c-designware: move to managed functions?\n" + "> (devm_*)\") removed it but at quick look drivers/clk/clk-devres.c:?\n" + "> devm_clk_release() calls only clk_put and I don't see disable is done?\n" "> down the path.\n" "\n" "The following is a mistake of the mentioned patch.\n" - "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240clk_disable_unprepare(dev->clk);\n" + "-???????clk_disable_unprepare(dev->clk);\n" "\n" "I did at the same mistake in dw_dmac driver which had been fixed later\n" "in the commit 8be4f523b480 (\"dmaengine: dw: fix regression in dw_probe()\n" @@ -59,4 +53,4 @@ "Andy Shevchenko <andriy.shevchenko@linux.intel.com>\n" Intel Finland Oy -6fdca68d2c5fcb7ea6da16eff266795e242b7d027518d82b15512efdddca21b4 +675d45ae72d2b0527da62d06c87e8e29835fa2cc8190c8e703251cfaf4e07abd
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.