From mboxrd@z Thu Jan  1 00:00:00 1970
From: mlin@kernel.org (Ming Lin)
Date: Thu, 21 Apr 2016 11:11:35 -0700
Subject: [PATCH v2 RFC] nvme: improve performance for virtual NVMe devices
In-Reply-To: <20160421133823.GA13563@infradead.org>
References: <1460657059-21214-1-git-send-email-helen.koike@collabora.co.uk>
 <5718D697.3050800@collabora.co.uk> <20160421133823.GA13563@infradead.org>
Message-ID: <1461262295.4797.11.camel@ssi>

On Thu, 2016-04-21@06:38 -0700, Christoph Hellwig wrote:
> I've not spent much time at it due to a busy conference week, but there
> are two main comments on why I don't think this is suitable as is
> despite really liking the general idea.
> 
>  - I'd really like this to be proposed as an official extension to the
>    NVMe technical workgroup.  I'm also happy to help with making that
>    happen.  I really don't like to merge it until we have some basic

That'd be great help. Thanks.

>    agreement on it, although once the basic agreement is there it
>    shouldn't be too hard to also support the older google specific
>    version.  And this is no new feedback, a couple of people including
>    me said that a long time ago, and we've seen zero action on it.

For "action", did you mean the "agreement" or the spec extension
proposal?

I think you'll make the proposal, right?

>  - the code is a mess in this version.  I really don't see the need for
>    all the ifdefs, but if you really want to keep them they should move
>    out of the main code path and just stub out helpers that would
>    otherwise do work.

I made the mess :)

I thought this before.
Probably add a new file ext.c and move these code into it.

Then add a nvme_ext_ops ...