From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Date: Fri, 28 Sep 2012 12:42:33 +0200 (CEST) Subject: [U-Boot] [PATCH v2 09/14] mx5 clocks: Fix get_ipg_per_clk() In-Reply-To: <50656E5F.10807@denx.de> Message-ID: <1461581765.5409249.1348828952980.JavaMail.root@advansee.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Friday, September 28, 2012 11:31:11 AM, Stefano Babic wrote: > On 27/09/2012 22:23, Beno?t Th?baudeau wrote: > > This fixes the "IPG PERCLK" frequency printed by the clocks > > command. The issue > > was that get_ipg_per_clk() used periph_clk instead of lp_apm in the > > case > > CCM.CBCMR.perclk_lp_apm_sel is set. > > > > It also fixes I?C support. > > > > Hi Beno?t, > > I understand "clocks" reports a wrong value only if > CCM.CBCMR.perclk_lp_apm_sel is set, not always. Correct. > Can you better explain me which is wrong and which is the fix for I2C > ? > It seems unrelated, and I do not get the reason checking the patch It's only because mxc_get_clock(MXC_IPG_CLK) (or mxc_get_clock(MXC_I2C_CLK) after [1]) both return get_ipg_per_clk() for the I?C driver's clock. Best regards, Beno?t [1] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=f6e11ba5997be9cc1044ca55f7b20d04bb7ed38a