From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr() Date: Tue, 26 Apr 2016 07:40:43 -0700 Message-ID: <1461681643.2726.140.camel@perches.com> References: <1461253130-9266-1-git-send-email-gustavo@padovan.org> <1461253130-9266-2-git-send-email-gustavo@padovan.org> <1461661318.7839.5.camel@pengutronix.de> <20160426142906.GI7857@joana> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1EC736E861 for ; Tue, 26 Apr 2016 14:40:49 +0000 (UTC) In-Reply-To: <20160426142906.GI7857@joana> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan , Lucas Stach Cc: devel@driverdev.osuosl.org, Daniel Stone , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Riley Andrews , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Daniel Vetter , Daniel Vetter , Andrew Morton , John Harrison List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE2LTA0LTI2IGF0IDExOjI5IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6 Cj4gMjAxNi0wNC0yNiBMdWNhcyBTdGFjaCA8bC5zdGFjaEBwZW5ndXRyb25peC5kZT46Cj4gPiBB bSBEb25uZXJzdGFnLCBkZW4gMjEuMDQuMjAxNiwgMTI6MzggLTAzMDAgc2NocmllYiBHdXN0YXZv IFBhZG92YW46Cj4gPiA+IEZyb206IEd1c3Rhdm8gUGFkb3ZhbiA8Z3VzdGF2by5wYWRvdmFuQGNv bGxhYm9yYS5jby51az4KPiA+ID4gCj4gPiA+IFRoaXMgZnVuY3Rpb24gaGFkIGNvcGllcyBpbiAz IGRpZmZlcmVudCBmaWxlcy4gVW5pZnkgdGhlbSBpbiBrZXJuZWwuaC4KPiA+ID4gCj4gPiA+IENj OiBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPgo+ID4gPiBDYzogQW5kcmV3IE1vcnRvbiA8 YWtwbUBsaW51eC1mb3VuZGF0aW9uLm9yZz4KPiA+ID4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGll ZEBsaW51eC5pZT4KPiA+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwu Y29tPgo+ID4gPiBDYzogUm9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28u dWs+Cj4gPiA+IAo+ID4gVGhvdWdoIEkgbm9ybWFsbHkgcHJlZmVyIHN0YXRpYyBpbmxpbmUgZnVu Y3Rpb25zLCBJIHNlZSB0aGUgYmVuZWZpdHMgb2YKPiA+IHVzaW5nIHRoZSBtYWNybyBmb3JtIGhl cmUuCgpBbiBpbmxpbmUgY291bGQgc3RpbGwgd29yawoJc3RhdGljIGlubGluZSB2b2lkIF9fdXNl ciAqdTY0X3RvX3VzZXJfcHRyKHU2NCBhZGRyZXNzKQoJewoJCXJldHVybiAodm9pZCBfX3VzZXIg KikodWludHB0cl90KWFkZHJlc3M7Cgl9CmlmIHRoZSBtYWNybyB3YXMKCSNkZWZpbmUgdTY0X3Rv X3VzZXJfcHRyKHgpCQlcCgkoewkJCQkJXAoJCXR5cGVjaGVjayh1NjQsIHgpOwkJXAoJCSh1NjRf dG9fdXNlcl9wdHIpKHgpOwkJXAoJfSkKCnRoZSBwYXJlbnRoZXNpcyBhcm91bmQgdGhlIHU2NF90 b191c2VyX3B0cgppbiB0aGUgbWFjcm8gc2hvdWxkIHByZXZlbnQgZXhwYW5zaW9uLgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752014AbcDZOkt (ORCPT ); Tue, 26 Apr 2016 10:40:49 -0400 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:43769 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750843AbcDZOks (ORCPT ); Tue, 26 Apr 2016 10:40:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3870:4321:5007:6742:7514:7576:10004:10400:10848:11026:11473:11658:11914:12043:12517:12519:12740:13069:13156:13161:13228:13229:13311:13357:13439:14040:14181:14659:14721:21080:30003:30051:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: home87_5dcbec4778021 X-Filterd-Recvd-Size: 2467 Message-ID: <1461681643.2726.140.camel@perches.com> Subject: Re: [PATCH v12 1/2] kernel.h: add u64_to_user_ptr() From: Joe Perches To: Gustavo Padovan , Lucas Stach Cc: Gustavo Padovan , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Daniel Stone , Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Daniel Vetter , Andrew Morton , John Harrison Date: Tue, 26 Apr 2016 07:40:43 -0700 In-Reply-To: <20160426142906.GI7857@joana> References: <1461253130-9266-1-git-send-email-gustavo@padovan.org> <1461253130-9266-2-git-send-email-gustavo@padovan.org> <1461661318.7839.5.camel@pengutronix.de> <20160426142906.GI7857@joana> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-04-26 at 11:29 -0300, Gustavo Padovan wrote: > 2016-04-26 Lucas Stach : > > Am Donnerstag, den 21.04.2016, 12:38 -0300 schrieb Gustavo Padovan: > > > From: Gustavo Padovan > > > > > > This function had copies in 3 different files. Unify them in kernel.h. > > > > > > Cc: Joe Perches > > > Cc: Andrew Morton > > > Cc: David Airlie > > > Cc: Daniel Vetter > > > Cc: Rob Clark > > > Signed-off-by: Gustavo Padovan > > > > > Though I normally prefer static inline functions, I see the benefits of > > using the macro form here. An inline could still work static inline void __user *u64_to_user_ptr(u64 address) { return (void __user *)(uintptr_t)address; } if the macro was #define u64_to_user_ptr(x) \ ({ \ typecheck(u64, x); \ (u64_to_user_ptr)(x); \ }) the parenthesis around the u64_to_user_ptr in the macro should prevent expansion.