From: Johannes Berg <johannes@sipsolutions.net>
To: Petko Manolov <petkan@mip-labs.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, a1291762@gmail.com
Subject: Re: [PATCH v2 0/2] pegasus: correct buffer sizes
Date: Wed, 27 Apr 2016 11:44:05 +0200 [thread overview]
Message-ID: <1461750245.3723.8.camel@sipsolutions.net> (raw)
In-Reply-To: <20160427093358.GA30444@p310>
On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote:
>
> Your guess turned out to be not so wild. ;) All Pegasus devices are
> configured (by the driver) to append CRC at the end of each RX
> packet. However, the driver reports packet length that does not
> include it.
Interesting, then my guess was wrong though, since the length is
reported without it, or am I misunderstanding this?
> I doubt the appended CRC is being silently verified by the upper
> layer, bit i might be wrong of course.
It's even "outside" the skb as you describe it, so it can't even be
touched, no?
> Perhaps it is best if instruct the device to not include the CRC as
> it seems ignored anyway.
Yeah, there's no point in passing it over the bus.
johannes
next prev parent reply other threads:[~2016-04-27 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 7:35 [PATCH v2 0/2] pegasus: correct buffer sizes Petko Manolov
2016-04-27 7:35 ` [PATCH v2 1/2] pegasus: fixes URB buffer allocation size; Petko Manolov
2016-04-27 7:35 ` [PATCH v2 2/2] pegasus: fixes reported packet length Petko Manolov
2016-04-27 7:46 ` [PATCH v2 0/2] pegasus: correct buffer sizes Johannes Berg
[not found] ` <20160427093358.GA30444@p310>
2016-04-27 9:44 ` Johannes Berg [this message]
2016-04-27 16:26 ` David Laight
2016-04-28 6:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461750245.3723.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=a1291762@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=petkan@mip-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.