From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, w.bumiller@proxmox.com,
eblake@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/2] vvfat: Fix default volume label
Date: Wed, 27 Apr 2016 14:24:43 +0200 [thread overview]
Message-ID: <1461759883-8589-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1461759883-8589-1-git-send-email-kwolf@redhat.com>
Commit d5941dd documented that it leaves the default volume name as it
was ("QEMU VVFAT"), but it doesn't actually implement this. You get an
empty name (eleven space characters) instead.
This fixes the implementation to apply the advertised default.
Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/vvfat.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/vvfat.c b/block/vvfat.c
index f9d4e82..e4817dd 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1109,6 +1109,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}
memcpy(s->volume_label, label, label_length);
+ } else {
+ memcpy(s->volume_label, "QEMU VVFAT", 10);
}
if (floppy) {
--
1.8.3.1
next prev parent reply other threads:[~2016-04-27 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 12:24 [Qemu-devel] [PATCH 0/2] vvfat: Fix regressions introduced in 2.4 Kevin Wolf
2016-04-27 12:24 ` [Qemu-devel] [PATCH 1/2] vvfat: Fix volume name assertion Kevin Wolf
2016-04-27 14:02 ` Max Reitz
2016-04-27 12:24 ` Kevin Wolf [this message]
2016-04-27 14:06 ` [Qemu-devel] [PATCH 2/2] vvfat: Fix default volume label Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461759883-8589-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.