All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	tgraf@suug.ch, pshelar@nicira.com, jbenc@redhat.com,
	hannes@stressinduktion.org, sergei.shtylyov@cogentembedded.com,
	Tom Herbert <tom@herbertland.com>
Subject: Re: [PATCH net] ip_tunnel: fix preempt warning in ip tunnel creation/updating
Date: Thu, 28 Apr 2016 16:11:16 +0200	[thread overview]
Message-ID: <1461852676.4802.31.camel@redhat.com> (raw)
In-Reply-To: <1461845394.5535.96.camel@edumazet-glaptop3.roam.corp.google.com>

On Thu, 2016-04-28 at 05:09 -0700, Eric Dumazet wrote:
> On Thu, 2016-04-28 at 11:04 +0200, Paolo Abeni wrote:
> > After the commit e09acddf873b ("ip_tunnel: replace dst_cache with generic
> > implementation"), a preemption debug warning is triggered on ip4
> > tunnels updating; the dst cache helper needs to be invoked in unpreemptible
> > context.
> > 
> > We don't need to load the cache on tunnel update, so this commit fixes
> > the warning replacing the load with a dst cache reset, which is
> > preempt safe.
> > 
> > Fixes: e09acddf873b ("ip_tunnel: replace dst_cache with generic
> > implementation")
> > 
> > Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> > ---
> 
> Seems good to me, thanks.
> 
> Note that the Fixes: tag should not be followed by a blank line.
> (And presumably no line wrap is necessary)
> It really is part of the standard set of tags.
> They should be grouped together.

Oops, I missed that points and checkpatch.pl did not help. 
Thank you for the advice.

Paolo

  reply	other threads:[~2016-04-28 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28  9:04 [PATCH net] ip_tunnel: fix preempt warning in ip tunnel creation/updating Paolo Abeni
2016-04-28 12:09 ` Eric Dumazet
2016-04-28 14:11   ` Paolo Abeni [this message]
2016-04-29 18:11 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461852676.4802.31.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=hannes@stressinduktion.org \
    --cc=jbenc@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tgraf@suug.ch \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.