All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>
Cc: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 10/10] usb: musb: Remove pm_runtime_set_irq_safe
Date: Thu, 28 Apr 2016 10:33:20 -0700	[thread overview]
Message-ID: <1461864800-29979-11-git-send-email-tony@atomide.com> (raw)
In-Reply-To: <1461864800-29979-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

With the pull up being handled with delayed work, we can
now finally remove pm_runtime_set_irq_safe that blocks the
MUSB glue from idling.

Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
---
 drivers/usb/musb/musb_core.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index b492316..f4731a0 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2216,12 +2216,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 	pm_runtime_mark_last_busy(musb->controller);
 	pm_runtime_put_autosuspend(musb->controller);
 
-	/*
-	 * For why this is currently needed, see commit 3e43a0725637
-	 * ("usb: musb: core: add pm_runtime_irq_safe()")
-	 */
-	pm_runtime_irq_safe(musb->controller);

  parent reply	other threads:[~2016-04-28 17:33 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 17:33 [PATCH 00/10] Get MUSB PM runtime working again Tony Lindgren
     [not found] ` <1461864800-29979-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-28 17:33   ` [PATCH 01/10] usb: phy: Fix initial state for twl6030 Tony Lindgren
2016-04-28 17:33   ` [PATCH 02/10] usb: musb: Fix idling after host mode by increasing autosuspend delay Tony Lindgren
     [not found]     ` <1461864800-29979-3-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-05-05 15:02       ` Bin Liu
2016-05-05 17:04         ` Tony Lindgren
     [not found]           ` <20160505170439.GX5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-05-05 17:47             ` Bin Liu
2016-05-06  6:45               ` Felipe Balbi
     [not found]                 ` <87k2j7it0f.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-05-09 19:57                   ` Tony Lindgren
2016-04-28 17:33   ` [PATCH 03/10] usb: musb: Fix PM runtime handling for connected cable Tony Lindgren
     [not found]     ` <1461864800-29979-4-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-28 17:53       ` Sergei Shtylyov
     [not found]         ` <57224E1F.7040707-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-04-28 18:07           ` Tony Lindgren
     [not found]             ` <20160428180741.GF5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-29 15:52               ` Tony Lindgren
2016-04-28 17:33   ` [PATCH 04/10] usb: musb: Remove unnecessary shutdown function Tony Lindgren
     [not found]     ` <1461864800-29979-5-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-05-05 19:20       ` Bin Liu
2016-05-05 19:28         ` Tony Lindgren
     [not found]           ` <20160505192852.GD5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-05-05 19:49             ` Bin Liu
2016-04-28 17:33   ` [PATCH 05/10] usb: musb: Fix PM runtime autosuspend Tony Lindgren
2016-04-28 17:33   ` [PATCH 06/10] usb: musb: Split PM runtime between wrapper IP and musb core Tony Lindgren
2016-04-28 17:33   ` [PATCH 07/10] usb: musb: Manage USB phy from PM runtime calls Tony Lindgren
2016-04-28 17:33   ` [PATCH 08/10] usb: musb: Remove try_idle for 2430 glue layer Tony Lindgren
2016-04-28 17:33   ` [PATCH 09/10] usb: musb: Fix PM runtime with delayed work Tony Lindgren
2016-04-28 17:33   ` Tony Lindgren [this message]
2016-05-01  6:33   ` [PATCH 00/10] Get MUSB PM runtime working again Ivaylo Dimitrov
     [not found]     ` <5725A31D.8020508-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-03 16:25       ` Tony Lindgren
     [not found]         ` <20160503162528.GM5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-05-03 17:43           ` Ivaylo Dimitrov
     [not found]             ` <5728E334.3090000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-05-11 23:03               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461864800-29979-11-git-send-email-tony@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=b-liu-l0cyMroinI0@public.gmane.org \
    --cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=george.cherian-l0cyMroinI0@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.