From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Ziswiler Subject: Re: [PATCH v2 00/10] STMPE fixes/rework and add STMPE1600 support Date: Fri, 29 Apr 2016 19:23:06 +0000 Message-ID: <1461957784.3869.50.camel@toradex.com> References: <1461845589-4826-1-git-send-email-patrice.chotard@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1461845589-4826-1-git-send-email-patrice.chotard@st.com> Content-Language: en-US Content-ID: <52D1F8FFBCDC6D4997D2B3E2ECBF273B@eurprd05.prod.outlook.com> Sender: linux-kernel-owner@vger.kernel.org To: "patrice.chotard@st.com" , "linux-kernel@vger.kernel.org" , "gnurou@gmail.com" , "linux-gpio@vger.kernel.org" , "lee.jones@linaro.org" , "linus.walleij@linaro.org" Cc: "dinguyen@opensource.altera.com" , "stefan@agner.ch" , "shiraz.linux.kernel@gmail.com" , "vireshk@kernel.org" , "dev@lynxeye.de" , "thierry.reding@gmail.com" , "maxime.coquelin@st.com" , "amelie.delaunay@st.com" , "linux-arm-kernel@lists.infradead.org" , "shawnguo@kernel.org" , "kernel@pengutronix.de" List-Id: linux-gpio@vger.kernel.org T24gVGh1LCAyMDE2LTA0LTI4IGF0IDE0OjEyICswMjAwLCBwYXRyaWNlLmNob3RhcmRAc3QuY29t IHdyb3RlOg0KPiBGcm9tOiBQYXRyaWNlIENob3RhcmQgPHBhdHJpY2UuY2hvdGFyZEBzdC5jb20+ DQo+IA0KPiANCj4gVGhpcyBzZXJpZXMgY2xlYW5zIGFuZCBmaXhlcyBzb21lIGJ1Z3MgaW4gTUZE L0dQSU8gU1RNUEUgZHJpdmVycyBhbmQNCj4gcHJlcGFyZQ0KPiDCoHRoZSBncm91bmQgdG8gYWRk IG5ldyBTVE1QRTE2MDAgc3VwcG9ydC4NCj4gDQo+IFNUTVBFMTYwMCBkYXRhc2hlZXQgaXMgYXZh aWxhYmxlIGhlcmUgOsKgDQo+IGh0dHA6Ly93d3cyLnN0LmNvbS9jb250ZW50L3N0X2NvbS9lbi9w cm9kdWN0cy9pbnRlcmZhY2VzLWFuZC10cmFuc2NlaQ0KPiB2ZXJzLw0KPiBpLW8tZXhwYW5kZXJz LWFuZC1sZXZlbC10cmFuc2xhdG9ycy9pLW8tZXhwYW5kZXJzL3N0bXBlMTYwMC5odG1sDQo+IA0K PiBPbmx5IFNUTVBFMTYwMCBoYXMgYmVlbiB0ZXN0ZWQgb24gU1RNMzIgcGxhdGZvcm0uIEFzIGkg aGF2ZSBubyBib2FyZA0KPiB3aXRoDQo+IG90aGVycyBTVE1QRQ0KPiB2YXJpYW50KFNUTVBFNjEw L1NUTVBFODAxL1NUTVBFODExL1NUTVBFMTYwMS9TVE1QRTE4MDEvU1RNUEUyNDAxDQo+IGFuZCBT VE1QRTI0MDMpLCBpIHB1dCBpbiBDQyBib2FyZHMncyBtYWludGFpbmVycyB3aGljaCBhcmUgdXNp bmcNCj4gb3RoZXJzIFNUTVBFIHZhcmlhbnQuDQo+IA0KPiBJZiB0aGV5IGNhbiBraW5kbHkgY2hl Y2sgdGhhdCBubyByZWdyZXNzaW9uIGhhcyBiZWVuIGludHJvZHVjZSBieQ0KPiB0aGlzIHNlcmll cw0KPiA6DQo+IA0KPiBGb3IgQVJNL0ZSRUVTQ0FMRSBJTVggLyBNWEMgQVJNIEFSQ0hJVEVDVFVS RToNCj4gCV8gU2hhd24gR3VvIDxzaGF3bmd1b0BrZXJuZWwub3JnPg0KPiAJXyBTYXNjaGEgSGF1 ZXIgPGtlcm5lbEBwZW5ndXRyb25peC5kZT4NCj4gDQo+IEZvciBBUk0vU09DRlBHQSBBUkNISVRF Q1RVUkUNCj4gCV8gRGluaCBOZ3V5ZW4gPGRpbmd1eWVuQG9wZW5zb3VyY2UuYWx0ZXJhLmNvbT4N Cj4gDQo+IEZvciBTUEVBUiBQTEFURk9STSBTVVBQT1JUDQo+IAlfIFZpcmVzaCBLdW1hciA8dmly ZXNoa0BrZXJuZWwub3JnPg0KPiAJXyBTaGlyYXogSGFzaGltIDxzaGlyYXoubGludXgua2VybmVs QGdtYWlsLmNvbT4NCj4gDQo+IEZvciBBcGFsaXMvQ29saWJyaSBib2FyZCBTVVBQT1JUDQo+IAlf IG1hcmNlbC56aXN3aWxlckB0b3JhZGV4LmNvbQ0KPiAJXyBzdGVmYW5AYWduZXIuY2gNCj4gCV8g ZGV2QGx5bnhleWUuZGUNCj4gCV8gVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWls LmNvbT4NCj4gCV8gQWxleGFuZHJlIENvdXJib3QgPGdudXJvdUBnbWFpbC5jb20+DQo+IA0KPiBG b3IgQVJNL1V4NTAwIEFSTSBBUkNISVRFQ1RVUkUNCj4gCV8gTGludXMgV2FsbGVpaiA8bGludXMu d2FsbGVpakBsaW5hcm8ub3JnPg0KPiANCj4gDQo+IHYxID0+IHYyOg0KPiAJXyB1cGRhdGUgQ2Mg bGlzdA0KPiAJXyBmaXgga2J1aWxkIHRlc3Qgcm9ib3Qgd2FybmluZ3Mgb24gb3JpZ2luYWwgcGF0 Y2ggMw0KPiAJXyBzcGxpdCBwYXRjaCA2IHRvIGV4dHJhY3QgdXNhZ2Ugb2YgZ2VuZXJpYyBiaXRt YXNrIG5hbWUNCj4gCV8gc3BsaXQgcGF0Y2ggNiBhbmQgNyBhbmQgaW50cm9kdWNlIGEgbmV3IHdh eSB0byBhY2Nlc3MNCj4gcmVnaXN0ZXJzDQo+IAnCoMKgZm9yIGJvdGggbWZkL3N0bXBlIGFuZCBn cGlvL2dwaW8tc3RtcGUgZHJpdmVycy4NCj4gCV8gcmVtb3ZlIHBhdGNoIDgNCj4gDQo+IFBhdHJp Y2UgQ2hvdGFyZCAoMTApOg0KPiDCoCBtZmQ6IHN0bXBlOiBBZGQgU1RNUEVfSURYX1NZU19DVFJM LzIgZW51bQ0KPiDCoCBtZmQ6IHN0bXBlOiBBZGQgcmVzZXQgc3VwcG9ydCBmb3IgYWxsIFNUTVBF IHZhcmlhbnQNCj4gwqAgZ3Bpbzogc3RtcGU6IGZpeCBlZGdlIGFuZCByaXNpbmcvZmFsbGluZyBl ZGdlIGRldGVjdGlvbg0KPiDCoCBncGlvOiBzdG1wZTogd3JpdGUgaW50IHN0YXR1cyByZWdpc3Rl ciBvbmx5IHdoZW4gbmVlZGVkDQo+IMKgIG1mZDogc3RtcGU6IHVzZSBnZW5lcmljIGJpdCBtYXNr IG5hbWUNCj4gwqAgbWZkOiBzdG1wZTogcmV3b3JrIHJlZ2lzdGVycyBhY2Nlc3MNCj4gwqAgZ3Bp bzogc3RtcGU6IHJld29yayByZWdpc3RlcnMgYWNjZXNzDQo+IMKgIERvY3VtZW50YXRpb246IGR0 OiBhZGQgc3RtcGUxNjAwIGNvbXBhdGlibGUgc3RyaW5nIHRvIHN0bXBlIG1mZA0KPiDCoCBtZmQ6 IEFkZCBTVE1QRTE2MDAgc3VwcG9ydA0KPiDCoCBncGlvOiBzdG1wZTogQWRkIFNUTVBFMTYwMCBz dXBwb3J0DQo+IA0KPiDCoERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvc3Rt cGUudHh0IHzCoMKgwqAyICstDQo+IMKgZHJpdmVycy9ncGlvL2dwaW8tc3RtcGUuY8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8IDE2Nw0KPiArKysrKysrKysr KysrKysrKy0tLS0tLS0NCj4gwqBkcml2ZXJzL21mZC9zdG1wZS1pMmMuY8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgfMKgwqDCoDIgKw0KPiDCoGRyaXZl cnMvbWZkL3N0bXBlLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgfCAxNjENCj4gKysrKysrKysrKysrKysrKysrKy0tLS0NCj4gwqBkcml2 ZXJzL21mZC9zdG1wZS5owqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoHzCoMKgODUgKysrKysrKysrKy0tDQo+IMKgaW5jbHVkZS9saW51eC9t ZmQvc3RtcGUuaMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8 wqDCoDIxICsrKw0KPiDCoDYgZmlsZXMgY2hhbmdlZCwgMzUyIGluc2VydGlvbnMoKyksIDg2IGRl bGV0aW9ucygtKQ0KDQpJIGdhdmUgdGhlIHdob2xlIHNlcmllcyBhIHNwaW4gYm90aCBvbiBBcGFs aXMgaU1YNlEgMkdCIElUIFYxLjFCIGFzDQp3ZWxsIGFzIEFwYWxpcyBUMzAgMkdCIFYxLjFBIGJv dGggZmVhdHVyaW5nIGEgU1RNUEU4MTEgYW5kIGFuIEVEVCBWR0ENCnRvdWNoIHBhbmVsIGNvbm5l Y3RlZCB0byBpdCBzdGlsbCB3b3JrcyBwZXJmZWN0bHkgcnVubmluZyBMWERFIG9uIHRvcA0Kb2Yg dGhlIG1vZGVzZXR0aW5nIFggZHJpdmVyLg0KDQpUZXN0ZWQtYnk6IE1hcmNlbCBaaXN3aWxlciA8 bWFyY2VsLnppc3dpbGVyQHRvcmFkZXguY29tPg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: marcel.ziswiler@toradex.com (Marcel Ziswiler) Date: Fri, 29 Apr 2016 19:23:06 +0000 Subject: [PATCH v2 00/10] STMPE fixes/rework and add STMPE1600 support In-Reply-To: <1461845589-4826-1-git-send-email-patrice.chotard@st.com> References: <1461845589-4826-1-git-send-email-patrice.chotard@st.com> Message-ID: <1461957784.3869.50.camel@toradex.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2016-04-28 at 14:12 +0200, patrice.chotard at st.com wrote: > From: Patrice Chotard > > > This series cleans and fixes some bugs in MFD/GPIO STMPE drivers and > prepare > ?the ground to add new STMPE1600 support. > > STMPE1600 datasheet is available here :? > http://www2.st.com/content/st_com/en/products/interfaces-and-transcei > vers/ > i-o-expanders-and-level-translators/i-o-expanders/stmpe1600.html > > Only STMPE1600 has been tested on STM32 platform. As i have no board > with > others STMPE > variant(STMPE610/STMPE801/STMPE811/STMPE1601/STMPE1801/STMPE2401 > and STMPE2403), i put in CC boards's maintainers which are using > others STMPE variant. > > If they can kindly check that no regression has been introduce by > this series > : > > For ARM/FREESCALE IMX / MXC ARM ARCHITECTURE: > _ Shawn Guo > _ Sascha Hauer > > For ARM/SOCFPGA ARCHITECTURE > _ Dinh Nguyen > > For SPEAR PLATFORM SUPPORT > _ Viresh Kumar > _ Shiraz Hashim > > For Apalis/Colibri board SUPPORT > _ marcel.ziswiler at toradex.com > _ stefan at agner.ch > _ dev at lynxeye.de > _ Thierry Reding > _ Alexandre Courbot > > For ARM/Ux500 ARM ARCHITECTURE > _ Linus Walleij > > > v1 => v2: > _ update Cc list > _ fix kbuild test robot warnings on original patch 3 > _ split patch 6 to extract usage of generic bitmask name > _ split patch 6 and 7 and introduce a new way to access > registers > ??for both mfd/stmpe and gpio/gpio-stmpe drivers. > _ remove patch 8 > > Patrice Chotard (10): > ? mfd: stmpe: Add STMPE_IDX_SYS_CTRL/2 enum > ? mfd: stmpe: Add reset support for all STMPE variant > ? gpio: stmpe: fix edge and rising/falling edge detection > ? gpio: stmpe: write int status register only when needed > ? mfd: stmpe: use generic bit mask name > ? mfd: stmpe: rework registers access > ? gpio: stmpe: rework registers access > ? Documentation: dt: add stmpe1600 compatible string to stmpe mfd > ? mfd: Add STMPE1600 support > ? gpio: stmpe: Add STMPE1600 support > > ?Documentation/devicetree/bindings/mfd/stmpe.txt |???2 +- > ?drivers/gpio/gpio-stmpe.c???????????????????????| 167 > +++++++++++++++++------- > ?drivers/mfd/stmpe-i2c.c?????????????????????????|???2 + > ?drivers/mfd/stmpe.c?????????????????????????????| 161 > +++++++++++++++++++---- > ?drivers/mfd/stmpe.h?????????????????????????????|??85 ++++++++++-- > ?include/linux/mfd/stmpe.h???????????????????????|??21 +++ > ?6 files changed, 352 insertions(+), 86 deletions(-) I gave the whole series a spin both on Apalis iMX6Q 2GB IT V1.1B as well as Apalis T30 2GB V1.1A both featuring a STMPE811 and an EDT VGA touch panel connected to it still works perfectly running LXDE on top of the modesetting X driver. Tested-by: Marcel Ziswiler