All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Bart Van Assche
	<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>,
	target-devel
	<target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: iSER multi-queue configuration
Date: Sat, 30 Apr 2016 23:07:06 -0700	[thread overview]
Message-ID: <1462082826.11010.3.camel@kernel.org> (raw)
In-Reply-To: <57256FB6.7030607-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

On Sun, 2016-05-01 at 05:53 +0300, Sagi Grimberg wrote:
> > Hi Sagi,
> 
> Hi Ming,
> 
> > I'm looking at why there is only 1 HW queue for iser.
> > 
> > 2185 int scsi_mq_setup_tags(struct Scsi_Host *shost)
> > 2186 {
> > ...
> > 2199         shost->tag_set.nr_hw_queues = shost->nr_hw_queues ? :
> > 1;
> > 
> > 
> > It seems because iser code does not set shost->nr_hw_queues at all.
> > 
> > Why?
> 
> The iscsi driver has not yet been converted to scsi_mq and iser as
> an iscsi transport still does not use multi-queue.

I'm going to compare performance between NVMe over RDMA and SCSI over
RDMA. SRP supports scsi_mq, so I'd use SRP to do the apples-to-apples
comparison.

> 
> In iscsi, a hw queue maps to an iscsi session. In order to support
> multi-queue we need to have iscsi open multiple sessions and map
> a session to a queue.
> 
> I had some preliminary works on this (joint with Mike Christie) but I
> didn't have time thus far to implement a full conversion to scsi-mq.

I'd happy to test it once you done.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-05-01  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-29 21:11 iSER multi-queue configuration Ming Lin
2016-04-30  6:13 ` Ming Lin
     [not found]   ` <1461996836.4373.5.camel-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-05-01  2:53     ` Sagi Grimberg
     [not found]       ` <57256FB6.7030607-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-05-01  6:07         ` Ming Lin [this message]
2016-05-02 15:12           ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462082826.11010.3.camel@kernel.org \
    --to=mlin-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    --cc=target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.