From: Johannes Berg <johannes@sipsolutions.net>
To: Julian Calaby <julian.calaby@gmail.com>,
Yongqin Liu <yongqin.liu@linaro.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Filipe Brandenburger <filbranden@google.com>
Subject: Re: [PATCH 1/1] iw: Android.mk & version.sh: update for Android based compilation
Date: Mon, 02 May 2016 08:33:28 +0200 [thread overview]
Message-ID: <1462170808.5898.2.camel@sipsolutions.net> (raw)
In-Reply-To: <CAGRGNgUzimCmk+2aBDwqcqxnjRUhRni93UZ9Ln88amX84c8u8w@mail.gmail.com> (sfid-20160429_012659_977445_10CE3B7C)
On Fri, 2016-04-29 at 09:26 +1000, Julian Calaby wrote:
> > +
> > +# Silence some warnings for now. Needs to be fixed upstream.
> > b/26105799
> Comments like this worry me: who is being referred to as "upstream",
> what are these warnings and why has nobody fixed them?
>
It's funny, because we're upstream (the kernel.org iw repository I
maintain) and they're submitting a Makefile to the same upstream -
saying that "upstream" should fix warnings.
In reality, it's a deluded comment - the warnings from -Wunused-
parameter are entirely useless and cannot be fixed without cluttering
the code with __maybe_unused (or so) since the functions implement
APIs.
This alone is a reason to reject this patch.
If there are legitimate warnings, submit patches first to fix them (and
perhaps add the relevant warning to the real Makefile).
If I then reject those "fixes", don't put such a baselessly accusatory
comment into the Makefile.
johannes
prev parent reply other threads:[~2016-05-02 6:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 13:36 [PATCH 1/1] iw: Android.mk & version.sh: update for Android based compilation Yongqin Liu
2016-04-28 23:26 ` Julian Calaby
2016-05-02 6:33 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462170808.5898.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=filbranden@google.com \
--cc=julian.calaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.