From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: dynamic ps + offchannel mgmt_tx + HW RoC
Date: Tue, 03 May 2016 15:14:03 +0200 [thread overview]
Message-ID: <1462281243.2251.2.camel@sipsolutions.net> (raw)
In-Reply-To: <CABPxzYLtu53V79O--eDJEdRfn-zw3Wq9Po04F=uFp_FrfJjuiA@mail.gmail.com> (sfid-20160503_145337_966449_6F26A629)
On Tue, 2016-05-03 at 18:23 +0530, Krishna Chaitanya wrote:
> Hi,
>
> When the HW is in PS and Dynamic PS is enabled we are dropping
> all the offchannel frames. Sequence is as below
>
> if hw is in PS: stop_queues reason=PS, queue dynamic_ps_disable_work
> send Offchannel mgmt_tx
> drop the packet because offchanel + stop_reasons[q] !=0
>
> How should we handle this? SW RoC is handling this
> by checking for offchannel and bringing the HW out of PS before
> handing the packet to TX path, so it works fine.
You should handle this by not doing such a non-sensical thing and
finally implementing powersave properly in the driver :)
johannes
next prev parent reply other threads:[~2016-05-03 13:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 12:53 dynamic ps + offchannel mgmt_tx + HW RoC Krishna Chaitanya
2016-05-03 13:14 ` Johannes Berg [this message]
2016-05-03 14:16 ` Krishna Chaitanya
2016-05-03 14:32 ` Krishna Chaitanya
2016-05-03 16:01 ` Johannes Berg
2016-05-03 16:58 ` Krishna Chaitanya
2016-05-03 17:21 ` Janusz Dziedzic
2016-05-03 17:42 ` Johannes Berg
2016-05-03 19:35 ` Johannes Berg
2016-05-03 19:50 ` Krishna Chaitanya
2016-05-03 20:03 ` Johannes Berg
2016-05-04 6:38 ` Krishna Chaitanya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462281243.2251.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=chaitanya.mgit@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.