From: Hannes Reinecke <hare@suse.de>
To: Christophe Varoqui <christophe.varoqui@gmail.com>
Cc: Hannes Reinecke <hare@suse.com>, dm-devel@redhat.com
Subject: [PATCH 6/6] libmultipath: fixup dm_rename to complete cookie on failure
Date: Wed, 4 May 2016 07:57:30 +0200 [thread overview]
Message-ID: <1462341450-5507-7-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1462341450-5507-1-git-send-email-hare@suse.de>
From my understanding we should be calling udev_complete() on
a cookie if dm_task_set_cookie() failed.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
libmultipath/devmapper.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 0ae72fc..5396521 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -1442,8 +1442,10 @@ dm_rename (const char * old, char * new)
dm_task_no_open_count(dmt);
if (!dm_task_set_cookie(dmt, &cookie,
- DM_UDEV_DISABLE_LIBRARY_FALLBACK))
+ DM_UDEV_DISABLE_LIBRARY_FALLBACK)) {
+ dm_udev_complete(cookie);
goto out;
+ }
r = dm_task_run(dmt);
if (!r)
--
2.6.6
next prev parent reply other threads:[~2016-05-04 5:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 5:57 [PATCH 0/6] multipath cookie handling rework Hannes Reinecke
2016-05-04 5:57 ` [PATCH 1/6] libmultipath: pass in cookie as argument for dm_simplecmd() Hannes Reinecke
2016-05-06 19:06 ` Benjamin Marzinski
2016-05-04 5:57 ` [PATCH 2/6] libmultipath: pass in 'cookie' as argument for dm_addmap() Hannes Reinecke
2016-05-06 19:27 ` Benjamin Marzinski
2016-05-04 5:57 ` [PATCH 3/6] Remove 'udev_sync' argument from dm_simplecmd() Hannes Reinecke
2016-05-06 19:50 ` Benjamin Marzinski
2016-05-04 5:57 ` [PATCH 4/6] libmultipath: Fixup 'DM_DEVICE_RELOAD' handling Hannes Reinecke
2016-05-06 20:12 ` Benjamin Marzinski
2016-05-09 10:26 ` Hannes Reinecke
2016-05-09 14:56 ` Benjamin Marzinski
2016-05-04 5:57 ` [PATCH 5/6] devmapper: do not flush I/O for DM_DEVICE_CREATE Hannes Reinecke
2016-05-06 20:18 ` Benjamin Marzinski
2016-05-04 5:57 ` Hannes Reinecke [this message]
2016-05-06 20:29 ` [PATCH 6/6] libmultipath: fixup dm_rename to complete cookie on failure Benjamin Marzinski
2016-05-06 21:59 ` Alasdair G Kergon
2016-05-06 22:45 ` Benjamin Marzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462341450-5507-7-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
--cc=hare@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.