From: Dario Faggioli <dario.faggioli@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wei.liu2@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH for 4.7 1/4] xen: sched: avoid spuriously re-enabling IRQs in csched2_switch_sched()
Date: Wed, 4 May 2016 11:08:43 +0200 [thread overview]
Message-ID: <1462352923.4413.20.camel@citrix.com> (raw)
In-Reply-To: <5729D38D02000078000E8639@prv-mh.provo.novell.com>
On Wed, 2016-05-04 at 02:48 -0600, Jan Beulich wrote:
> > > > On 03.05.16 at 23:46, <dario.faggioli@citrix.com> wrote:
> > In fact, interrupts are already disabled when calling
> > the hook from schedule_cpu_switch(), and hence using
> > anything different than just spin_lock() is wrong (and
> > ASSERT()-s in debug builds) or unnecessary.
> Well, this is a little too broad a statement: spin_lock_irqsave()
> would be quite fine in this situation.
>
That would be covered by the "or unnecessary" part.
As in "spin_lock_irq() is wrong and spin_lock_irqsave() is
unnecessary".
> >
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Actual code change
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
>
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-05-04 9:08 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 21:46 [PATCH for 4.7 0/4] Assorted scheduling fixes Dario Faggioli
2016-05-03 21:46 ` [PATCH for 4.7 1/4] xen: sched: avoid spuriously re-enabling IRQs in csched2_switch_sched() Dario Faggioli
2016-05-04 8:48 ` Jan Beulich
2016-05-04 9:08 ` Dario Faggioli [this message]
2016-05-04 15:11 ` George Dunlap
2016-05-04 15:58 ` Dario Faggioli
2016-05-04 17:05 ` George Dunlap
2016-05-04 17:21 ` Dario Faggioli
2016-05-04 17:34 ` George Dunlap
2016-05-06 13:21 ` Dario Faggioli
2016-05-06 13:48 ` Wei Liu
2016-05-09 14:42 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 2/4] xen: sched: fix killing an uninitialized timer in free_pdata Dario Faggioli
2016-05-04 15:25 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 3/4] xen: credit2: fix 2 (minor) issues in load tracking logic Dario Faggioli
2016-05-04 15:38 ` George Dunlap
2016-05-03 21:46 ` [PATCH for 4.7 4/4] xen: adopt .deinit_pdata and improve timer handling Dario Faggioli
2016-05-04 15:51 ` George Dunlap
2016-05-04 15:53 ` Meng Xu
2016-05-06 23:05 ` Dario Faggioli
2016-05-07 21:19 ` Meng Xu
2016-05-08 3:12 ` Meng Xu
2016-05-09 8:07 ` Juergen Gross
2016-05-09 13:22 ` Dario Faggioli
2016-05-09 14:08 ` Meng Xu
2016-05-09 14:52 ` Dario Faggioli
2016-05-09 14:58 ` Meng Xu
2016-05-09 14:46 ` George Dunlap
2016-05-09 14:58 ` Wei Liu
2016-05-09 15:35 ` George Dunlap
2016-05-04 1:26 ` [PATCH for 4.7 0/4] Assorted scheduling fixes Konrad Rzeszutek Wilk
2016-05-04 9:06 ` Dario Faggioli
2016-05-05 12:00 ` Julien Grall
2016-05-05 12:38 ` Dario Faggioli
2016-05-04 15:53 ` George Dunlap
2016-05-04 16:04 ` Wei Liu
2016-05-07 21:23 ` Meng Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462352923.4413.20.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.