From: "Woodhouse, David" <david.woodhouse@intel.com>
To: "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>
Cc: "mmarek@suse.com" <mmarek@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dhowells@redhat.com" <dhowells@redhat.com>
Subject: Re: [PATCH] kbuild: fix if_change and friends to consider argument order
Date: Thu, 5 May 2016 08:08:15 +0000 [thread overview]
Message-ID: <1462435694.44077.9.camel@intel.com> (raw)
In-Reply-To: <1462434312-19422-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 895 bytes --]
On Thu, 2016-05-05 at 16:45 +0900, Masahiro Yamada wrote:
>
> This commit fixes arg-check to compare two strings as a whole.
> $(strip ...) is important because we want to ignore the difference
> that comes from white-spaces.
Do we?
I can construct a hypothetical situation in which whitespace differs
and we *do* want it to make a difference (for example I used to sign
with a key called 'My Signing Key.pem' and now I've changed to use
'My Signing Key.pem'. (OK, it's a *stupid* example but still...)
I couldn't come up with the converse — where whitespace does change for
some reason, but we really don't want to rebuild.
Should we err on the side of caution, and let whitespace changes
trigger a rebuild?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3437 bytes --]
next prev parent reply other threads:[~2016-05-05 8:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 7:45 [PATCH] kbuild: fix if_change and friends to consider argument order Masahiro Yamada
2016-05-05 8:08 ` Woodhouse, David [this message]
2016-05-05 14:49 ` Masahiro Yamada
2016-05-05 18:00 ` Masahiro Yamada
2016-05-06 2:12 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462435694.44077.9.camel@intel.com \
--to=david.woodhouse@intel.com \
--cc=dhowells@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.