All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
	Ian Munsie <imunsie@au1.ibm.com>, mikey <mikey@neuling.org>,
	linuxppc-dev@lists.ozlabs.org,
	 Frederic Barrat <frederic.barrat@fr.ibm.com>
Subject: Re: [PATCH] cxl: Add kernel API to allow a context to operate with relocate disabled
Date: Fri, 06 May 2016 12:23:32 +1000	[thread overview]
Message-ID: <1462501412.8044.0.camel@ellerman.id.au> (raw)
In-Reply-To: <572A1E30.2020306@linux.vnet.ibm.com>

On Wed, 2016-05-04 at 18:07 +0200, Frederic Barrat wrote:

> Hi Ian,
> 
> The principle is fine, but the cxl_start_context2 API bothers me a bit. 
> Would something similar to this make sense, I think it would keep the 
> API cleaner:
> 
> /* new kernel-only API */
> void cxl_set_translation_mode(struct cxl_context *ctx, bool real_mode)
> 
> For mlx5, the call sequence would be:
> 	ctx = cxl_dev_context_init()
> 	cxl_set_translation_mode(ctx, true)
> 	cxl_start_context(ctx)

I'd prefer that if it works.

The new "2" API and the bool being passed everywhere is a bit smelly.

cheers

  reply	other threads:[~2016-05-06  2:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04  6:54 [PATCH] cxl: Add kernel API to allow a context to operate with relocate disabled Ian Munsie
2016-05-04 16:07 ` Frederic Barrat
2016-05-06  2:23   ` Michael Ellerman [this message]
2016-05-06  7:27   ` Ian Munsie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462501412.8044.0.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=frederic.barrat@fr.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.