From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3426.houston.hp.com (g4t3426.houston.hp.com [15.201.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D83051A1EFE for ; Mon, 9 May 2016 15:43:14 -0700 (PDT) Message-ID: <1462833254.27137.113.camel@hpe.com> Subject: Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks From: Toshi Kani Date: Mon, 09 May 2016 16:34:14 -0600 In-Reply-To: <20160509211903.GW18496@dastard> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-3-git-send-email-toshi.kani@hpe.com> <1462817565.27137.102.camel@hpe.com> <20160509211903.GW18496@dastard> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dave Chinner , Dan Williams Cc: Christoph Hellwig , Jan Kara , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , micah.parrish@hpe.com, Jens Axboe , Andreas Dilger , Al Viro , linux-fsdevel , Theodore Ts'o List-ID: T24gVHVlLCAyMDE2LTA1LTEwIGF0IDA3OjE5ICsxMDAwLCBEYXZlIENoaW5uZXIgd3JvdGU6Cj4g T24gTW9uLCBNYXkgMDksIDIwMTYgYXQgMTE6MjM6MDNBTSAtMDcwMCwgRGFuIFdpbGxpYW1zIHdy b3RlOgo+ID4gCj4gPiBPbiBNb24sIE1heSA5LCAyMDE2IGF0IDExOjEyIEFNLCBUb3NoaSBLYW5p IDx0b3NoaS5rYW5pQGhwZS5jb20+IHdyb3RlOgo+ID4gPiAKPiA+ID4gT24gU3VuLCAyMDE2LTA1 LTA4IGF0IDEyOjE0IC0wNzAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6Cj4gPiA+ID4gCj4gPiA+ID4g T24gVGh1LCBNYXkgNSwgMjAxNiBhdCA1OjI5IFBNLCBUb3NoaSBLYW5pIDx0b3NoaS5rYW5pQGhw ZS5jb20+Cj4gPiA+ID4gd3JvdGU6CsKgOgo+ID4gPiA+IFRoaXMgcGF0Y2ggc2hvdWxkIHJlcGxh Y2UgYmxrZGV2X2RheF9jYXBhYmxlKCksIG9yIGp1c3QgcmV1c2UgdGhhdAo+ID4gPiA+IGV4aXN0 aW5nIHJvdXRpbmUsIG9yIGFtIEkgbWlzc2luZyBzb21ldGhpbmc/Cj4gPiA+Cj4gPiA+IEdvb2Qg cXVlc3Rpb24uwqDCoGJkZXZfc3VwcG9ydHNfZGF4KCkgaXMgYSBoZWxwZXIgZnVuY3Rpb24gdGFp bG9yZWQgZm9yCj4gPiA+IHRoZSBmaWxlc3lzdGVtJ3MgbW91bnQgLW8gZGF4IGNhc2UuwqDCoFdo aWxlIGJsa2Rldl9kYXhfY2FwYWJsZSgpIGlzCj4gPiA+IHNpbWlsYXIsIGl0IGRvZXMgbm90IG5l ZWQgZXJyb3IgbWVzc2FnZXMgbGlrZSAiZGV2aWNlIGRvZXMgbm90Cj4gPiA+IHN1cHBvcnQgZGF4 IiBzaW5jZSBpdCBpbXBsaWNpdGx5IGVuYWJsZXMgZGF4IHdoZW4gY2FwYWJsZS7CoMKgU28sIEkK PiA+ID4gdGhpbmsgd2UgY2FuIGtlZXAgYmxrZGV2X2RheF9jYXBhYmxlKCksIGJ1dCBjaGFuZ2Ug aXQgdG8gY2FsbAo+ID4gPiBiZGV2X2RpcmVjdF9hY2Nlc3MoKSBzbyB0aGF0IGFjdHVhbCBjaGVj ayBpcyBwZXJmb3JtZWQgaW4gYSBzaW5nbGUKPiA+ID4gcGxhY2UuCj4gPgo+ID4gU291bmRzIGdv b2QgdG8gbWUuCj4KPiBDYW4geW91IG5hbWUgdGhlbSBjb25zaXN0ZW50bHkgdGhlbj8gaS5lLiBi bGtkZXZfZGF4X3N1cHBvcnRlZCgpIGFuZAo+IGJsa2Rldl9kYXhfY2FwYWJsZSgpPwoKU3VyZS4g wqBXaWxsIGRvLgoKVGhhbmtzLAotVG9zaGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KTGludXgtbnZkaW1tIG1haWxpbmcgbGlzdApMaW51eC1udmRpbW1A bGlzdHMuMDEub3JnCmh0dHBzOi8vbGlzdHMuMDEub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt bnZkaW1tCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3426.houston.hp.com ([15.201.208.54]:16067 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbcEIWnP (ORCPT ); Mon, 9 May 2016 18:43:15 -0400 Message-ID: <1462833254.27137.113.camel@hpe.com> Subject: Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks From: Toshi Kani To: Dave Chinner , Dan Williams Cc: Jan Kara , Al Viro , Jens Axboe , Christoph Hellwig , Boaz Harrosh , Theodore Ts'o , Andreas Dilger , Ross Zwisler , micah.parrish@hpe.com, "linux-nvdimm@lists.01.org" , linux-fsdevel , "linux-kernel@vger.kernel.org" Date: Mon, 09 May 2016 16:34:14 -0600 In-Reply-To: <20160509211903.GW18496@dastard> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-3-git-send-email-toshi.kani@hpe.com> <1462817565.27137.102.camel@hpe.com> <20160509211903.GW18496@dastard> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote: > On Mon, May 09, 2016 at 11:23:03AM -0700, Dan Williams wrote: > > > > On Mon, May 9, 2016 at 11:12 AM, Toshi Kani wrote: > > > > > > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: > > > > > > > > On Thu, May 5, 2016 at 5:29 PM, Toshi Kani > > > > wrote:  : > > > > This patch should replace blkdev_dax_capable(), or just reuse that > > > > existing routine, or am I missing something? > > > > > > Good question.  bdev_supports_dax() is a helper function tailored for > > > the filesystem's mount -o dax case.  While blkdev_dax_capable() is > > > similar, it does not need error messages like "device does not > > > support dax" since it implicitly enables dax when capable.  So, I > > > think we can keep blkdev_dax_capable(), but change it to call > > > bdev_direct_access() so that actual check is performed in a single > > > place. > > > > Sounds good to me. > > Can you name them consistently then? i.e. blkdev_dax_supported() and > blkdev_dax_capable()? Sure.  Will do. Thanks, -Toshi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbcEIWnQ (ORCPT ); Mon, 9 May 2016 18:43:16 -0400 Received: from g4t3426.houston.hp.com ([15.201.208.54]:16067 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626AbcEIWnP (ORCPT ); Mon, 9 May 2016 18:43:15 -0400 Message-ID: <1462833254.27137.113.camel@hpe.com> Subject: Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks From: Toshi Kani To: Dave Chinner , Dan Williams Cc: Jan Kara , Al Viro , Jens Axboe , Christoph Hellwig , Boaz Harrosh , "Theodore Ts'o" , Andreas Dilger , Ross Zwisler , micah.parrish@hpe.com, "linux-nvdimm@lists.01.org" , linux-fsdevel , "linux-kernel@vger.kernel.org" Date: Mon, 09 May 2016 16:34:14 -0600 In-Reply-To: <20160509211903.GW18496@dastard> References: <1462494596-20938-1-git-send-email-toshi.kani@hpe.com> <1462494596-20938-3-git-send-email-toshi.kani@hpe.com> <1462817565.27137.102.camel@hpe.com> <20160509211903.GW18496@dastard> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote: > On Mon, May 09, 2016 at 11:23:03AM -0700, Dan Williams wrote: > > > > On Mon, May 9, 2016 at 11:12 AM, Toshi Kani wrote: > > > > > > On Sun, 2016-05-08 at 12:14 -0700, Dan Williams wrote: > > > > > > > > On Thu, May 5, 2016 at 5:29 PM, Toshi Kani > > > > wrote:  : > > > > This patch should replace blkdev_dax_capable(), or just reuse that > > > > existing routine, or am I missing something? > > > > > > Good question.  bdev_supports_dax() is a helper function tailored for > > > the filesystem's mount -o dax case.  While blkdev_dax_capable() is > > > similar, it does not need error messages like "device does not > > > support dax" since it implicitly enables dax when capable.  So, I > > > think we can keep blkdev_dax_capable(), but change it to call > > > bdev_direct_access() so that actual check is performed in a single > > > place. > > > > Sounds good to me. > > Can you name them consistently then? i.e. blkdev_dax_supported() and > blkdev_dax_capable()? Sure.  Will do. Thanks, -Toshi