All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Intel graphics driver community testing & development
	<intel-gfx@lists.freedesktop.org>
Cc: Jani Nikula <jani.nikula@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH maintainer-tools v3] dim: Resist committing patches that modify files outside of i915
Date: Tue, 10 May 2016 11:52:32 +0300	[thread overview]
Message-ID: <1462870352.3969.2.camel@linux.intel.com> (raw)
In-Reply-To: <1462870248-10425-1-git-send-email-joonas.lahtinen@linux.intel.com>

Disregard this v3.

On ti, 2016-05-10 at 11:50 +0300, Joonas Lahtinen wrote:
> If committing to drm-intel-next-queued branch, require the committer
> to be aware that they are committing outside of drm/i915 maintenance
> scope.
> 
> v2:
> - Do not use warn_or_fail (Jani)
> - Only apply to drm-intel-next-queued branch (Daniel)
> 
> v3:
> - Do not use HEAD but $commit (Jani)
> 
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> ---
>  dim | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/dim b/dim
> index d9c1be5..cbdae85 100755
> --- a/dim
> +++ b/dim
> @@ -691,6 +691,17 @@ function checkpatch_commit
>  	if test "$bug_lines" -eq 1; then
>  		warn_or_fail "New BUG macro added"
>  	fi
> +
> +        if [ "$branch" = "drm-intel-next-queued" ]; then
> +		local non_i915_files=$(git diff-tree --no-commit-id --name-only -r HEAD | \
> +			grep -v "^\(drivers/gpu/drm/i915/\|include/drm/i915\|include/uapi/drm/i915\)")
> +
> +		if [ -n "$non_i915_files" ]; then
> +			echo -e "The following files are outside of i915 maintenance scope:\n"
> +			echo "$non_i915_files"
> +			echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
> +		fi
> +	fi
>  }
>  
>  # turn $1 in to a git commit range
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-05-10  8:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10  8:16 [PATCH maintainer-tools v2] dim: Resist committing patches that modify files outside of i915 Joonas Lahtinen
2016-05-10  8:37 ` Jani Nikula
2016-05-10  8:50   ` [PATCH maintainer-tools v3] " Joonas Lahtinen
2016-05-10  8:52     ` Joonas Lahtinen [this message]
2016-05-10  8:51   ` [PATCH maintainer-tools v4] " Joonas Lahtinen
2016-05-10  9:22     ` Jani Nikula
2016-05-10  9:34       ` Joonas Lahtinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462870352.3969.2.camel@linux.intel.com \
    --to=joonas.lahtinen@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.