From: Johannes Berg <johannes@sipsolutions.net>
To: Wei-Ning Huang <wnhuang@chromium.org>,
Linux-Wireless <linux-wireless@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Sameer Nanda <snanda@chromium.org>,
Todd Broch <tbroch@chromium.org>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
Date: Wed, 11 May 2016 09:21:31 +0200 [thread overview]
Message-ID: <1462951291.2869.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1462430663-9448-1-git-send-email-wnhuang@chromium.org> (sfid-20160505_084446_369647_C7B8DEBC)
On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
> Recent new hardware has the ability to switch between tablet mode and
> clamshell mode. To optimize WiFi performance, we want to be able to
> use different power table between modes. This patch adds a new
> netlink message type and cfg80211_ops function to allow userspace to
> trigger a power mode switch for a given wireless interface.
I'm not a fan of this at all. Too much magic.
FWIW, we implemented something similar, currently with vendor commands,
that simply allows to set the TX power in a more controlled fashion,
i.e. allows setting TX power per band/channel range. For our device
it's only 2.4 GHz vs. 5.2 GHz, but I can imagine that you might want to
split it a bit further, so perhaps we need to advertise those ranges
somehow.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Wei-Ning Huang <wnhuang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Linux-Wireless
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Sameer Nanda <snanda-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Todd Broch <tbroch-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support
Date: Wed, 11 May 2016 09:21:31 +0200 [thread overview]
Message-ID: <1462951291.2869.4.camel@sipsolutions.net> (raw)
In-Reply-To: <1462430663-9448-1-git-send-email-wnhuang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> (sfid-20160505_084446_369647_C7B8DEBC)
On Thu, 2016-05-05 at 14:44 +0800, Wei-Ning Huang wrote:
> Recent new hardware has the ability to switch between tablet mode and
> clamshell mode. To optimize WiFi performance, we want to be able to
> use different power table between modes. This patch adds a new
> netlink message type and cfg80211_ops function to allow userspace to
> trigger a power mode switch for a given wireless interface.
I'm not a fan of this at all. Too much magic.
FWIW, we implemented something similar, currently with vendor commands,
that simply allows to set the TX power in a more controlled fashion,
i.e. allows setting TX power per band/channel range. For our device
it's only 2.4 GHz vs. 5.2 GHz, but I can imagine that you might want to
split it a bit further, so perhaps we need to advertise those ranges
somehow.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-11 7:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 6:44 [PATCH] cfg80211/nl80211: add wifi tx power mode switching support Wei-Ning Huang
2016-05-05 16:07 ` Dan Williams
2016-05-06 8:19 ` Wei-Ning Huang
2016-05-11 5:03 ` Wei-Ning Huang
2016-05-11 18:33 ` Dan Williams
2016-05-12 9:34 ` Wei-Ning Huang
2016-05-12 22:02 ` Arend van Spriel
2016-05-13 3:22 ` Wei-Ning Huang
2016-06-28 10:57 ` Johannes Berg
2016-06-28 10:57 ` Johannes Berg
2016-07-07 9:30 ` Wei-Ning Huang
2016-05-11 7:21 ` Johannes Berg [this message]
2016-05-11 7:21 ` Johannes Berg
2016-11-21 8:50 ` form factor subsystem (Re: [PATCH] cfg80211/nl80211: add wifi tx power mode switching support) Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462951291.2869.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=snanda@chromium.org \
--cc=tbroch@chromium.org \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.