From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C476DC6FA8E for ; Thu, 2 Mar 2023 12:32:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbjCBMcP (ORCPT ); Thu, 2 Mar 2023 07:32:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229897AbjCBMcO (ORCPT ); Thu, 2 Mar 2023 07:32:14 -0500 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C246188 for ; Thu, 2 Mar 2023 04:32:11 -0800 (PST) Received: from epcas5p1.samsung.com (unknown [182.195.41.39]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20230302123209epoutp02824bf6a30a7d7f1f5096475b1cb256d8~ImiFqSpJ_1360813608epoutp02v for ; Thu, 2 Mar 2023 12:32:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20230302123209epoutp02824bf6a30a7d7f1f5096475b1cb256d8~ImiFqSpJ_1360813608epoutp02v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677760329; bh=w8lus32mfN0JsldgiFkE/jaxZOJ68qTXGqyvtoCNxcQ=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=ILrvpVMk1jGLtCouwmbaSGz0PgiJH7peL4HRfpDsRvMb8MrI92E/vf3j/6i5EJ7YW qRcLv67yG4I2uXNJwB+INrihOZU3cxNTLQk547gaO6sh394k2QJlyUKHbRPRjLPAwD UoqrmFTppF7Vx9LdzBPkdNLNT5umG7ArcfrjE6uk= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas5p4.samsung.com (KnoxPortal) with ESMTP id 20230302123208epcas5p4a38a06d8833ecace1c6eb7cec280b060~ImiFGeMQN1989019890epcas5p4P; Thu, 2 Mar 2023 12:32:08 +0000 (GMT) Received: from epsmges5p1new.samsung.com (unknown [182.195.38.177]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PS9Tg4sRVz4x9Pr; Thu, 2 Mar 2023 12:32:07 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 0A.02.10528.74790046; Thu, 2 Mar 2023 21:32:07 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20230302123207epcas5p3b89e4e110aaf44961fabed425666503c~ImiDVctGY1454014540epcas5p3V; Thu, 2 Mar 2023 12:32:07 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230302123206epsmtrp2660aad4ee146a31982a2ecacd41652fc~ImiDUeGRw2648826488epsmtrp2B; Thu, 2 Mar 2023 12:32:06 +0000 (GMT) X-AuditID: b6c32a49-e75fa70000012920-48-64009747c4b2 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 5D.23.18071.64790046; Thu, 2 Mar 2023 21:32:06 +0900 (KST) Received: from pankajdubey02 (unknown [107.122.12.6]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302123202epsmtip200d1dfcf9283d65f0b5c1ec163b7fe7c~Imh-emAVy2740827408epsmtip2K; Thu, 2 Mar 2023 12:32:02 +0000 (GMT) From: "Pankaj Dubey" To: "'Krzysztof Kozlowski'" , "'Shradha Todi'" , , , , , , , , , , , , , Cc: , , , , In-Reply-To: Subject: RE: [PATCH 08/16] PCI: samsung: Rename exynos_pcie to samsung_pcie Date: Thu, 2 Mar 2023 18:02:01 +0530 Message-ID: <146301d94d03$002ba040$0082e0c0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHB3D0FgV9/Br8Y35oSVRdB1anKHwF30rWoAbvCRL0BoFQ7lK7vreOg Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA01TbUxbZRTm3tveFmbZXQfhHZkGb2ACE2gnLS8GcFFgl4xMki3OLGbdDb2h CP1Ib9nUudmxMjoEHKJWuoF8jM0RRCiMIB9K+LRGO3GDpQEiIJsIiCsQGCuKpWXKv+ec8zzv Oc95c/iY0IkH8jNVOkarorNJ3IfT2hsWGnHI5CUXWceC4URFKw6v5yrgF302LjS3liPQ4bRx 4JfLZTxYPDOJwa652zyoL3RyoeW3ES68234Nhz9VDOLw8zvfotCwbuBAQ38+B37VN86DG51t PLhuesSBRb3nYLPlU+ygHzVvWeVR35jHeVSlJYey1F3GqbGRTpxasNl41PQ9E0o1X/+Aalpo Q6lqvQOnilvqEGrJ8lzaMyey4hQMLWe0QYwqXS3PVGXEk4ePyl6TSaQicYQ4FsaQQSpaycST ialpEcmZ2S6bZNBpOjvHlUqjWZaMSojTqnN0TJBCzeriSUYjz9ZEayJZWsnmqDIiVYzuZbFI dEDiIp7KUhiMy6imPPCd1plqVI84/QsQbz4gosF9Wx5vEwuJDgSU/BlegPi48CIC7pQacU+w ggCT7Tv0qaJ+wMD1FLoQMNTUsBXMIqDqV6ObhRNRwPa4wl3wI7oxMPlzrTvAiAYETFcVuVne RAIwPel0d99NHAb1F0rceQ4RDG5/f9edFxCxYLQ/H/XgXcBaNs3ZxBixH9yomsM8MwWBtQc3 uJvYj0gGD0bWMA8nAPzR38fbbAyIm96g9EklxyNIBEOL17bwbjA72MLz4ECwtNDlcs134VRQ 20F50jrQWFi7RX8FdN/blPJd74eBr9ujPK18QZFzGvUoBcB4Sehh7wOrv/+4NeVeMHmxdmuL FFiz25EryPPmbcbM24yZtxkw/9+sEuHUIXsYDavMYFiJRqxizvz34elqpQVxX0F4ShsyPvEo sgdB+UgPAvgY6Sc4q/eSCwVy+t33GK1aps3JZtgeROLadgkW6J+udp2RSicTR8eKoqVSaXTs S1IxGSB4Id6aLiQyaB2TxTAaRvtUh/K9A/VoY9Vqg+7qxsf2tYYW/sgpc33+27Ps1bOHlHMK x9HURE1AyT/OsiufdF8eOFIwEUc/q5182H7emuBPDsZ14sKOWztObNioopi6nvjclcr8QkIw bHp4Plz0/hm7LxuSR/vURIyWH9kply3K8oZSakLWq+3DO41EwK6p4c7QGfh3aVxz4hv3jwdP xQzcvCDlii9V/hJm3vP6yl8S6b7RNCzkQ4VEU+twznclpfIz845VzYvKkt5cb60RGH+IMXL3 m5tIuxfh+3jHApI3FhH72VT5yRXHR8OLdHLS3tyoV0mrkg47ji7PZbTdMpQes1480LvQ/eJS Y2jy6ZMH9efeSqkrJjmsghaHY1qW/heSRlKHjgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWy7bCSvK7bdIYUg03njC0ezNvGZrGkKcNi /pFzrBazts1ltPj4+xyLxYovM9kt+l48ZLbY+3oru0VDz29Wi02Pr7FaXN41h83i7LzjbBYz zu9jsmj508Ji0XK0ncVi7ZG77Bb/9+xgt/gz/QOLRe/hWovNm6YyO4h4vNn0nd1j56y77B4L NpV6bFrVyeZx59oeNo93586xezy5Mp3JY/OSeo+N73YweSxq+Mjm0bdlFaPH501yATxRXDYp qTmZZalF+nYJXBknlnxiL9grWXFv2hT2BsbZol2MnBwSAiYSa461sILYQgK7GSXaJlhCxGUk Jq9ewQphC0us/PecvYuRC6jmBaPE+Z6D7CAJNgF9iXM/5rGCJEQELjBLPD93mgXEYRbYxCjx edlaZoiW14wSl57cZQJp4RSwk5j+aw9Yu7CAt8SaxolgcRYBFYmtJy6DxXkFLCVuH21ngrAF JU7OfMICYjMLaEv0PmxlhLGXLXzNDHGfgsTPp8vAbhURcJN4eu0nM0SNuMTLo0fYJzAKz0Iy ahaSUbOQjJqFpGUBI8sqRsnUguLc9NxiwwLDvNRyveLE3OLSvHS95PzcTYzglKCluYNx+6oP eocYmTgYDzFKcDArifBWNzCkCPGmJFZWpRblxxeV5qQWH2KU5mBREue90HUyXkggPbEkNTs1 tSC1CCbLxMEp1cC0wqrYWT3O/PvV9OYtRzyFBfVq+BpXH7wYomm/5s9W5ghRz9WJxxgUNTZ+ uLqtw3yd8cOHr++t/PwlpXjzH83Nb3k+8nsJxwv+5+Xbl5/3WZZP7/lTZvGUfFsbu/9NQq2J 5y5YfRdR7BQ7mB3oUd/1Z83eXes0Fl/rDIvbFsCeNlOwLNCVOU60cKGz7af+W5ddFvxnXLO2 IeeYoVql5+di086S3S03jrC+0JVNXbN4723L5h95iYab7Hhe8LAq8JU3Kt/7Ozm8c1vCchmZ LS2fI5SSDvz5t8puQ8T19yHhv7cdn/y3QWlr8s58ftElU57fs7T/oTUl00Ht5rz9LpMdTdyD U89O59m9c+2/WylKLMUZiYZazEXFiQBcTG9SeAMAAA== X-CMS-MailID: 20230302123207epcas5p3b89e4e110aaf44961fabed425666503c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230214121436epcas5p1641de02220bea5edb23bc875b6311270 References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-9-shradha.t@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Thursday, February 16, 2023 4:37 PM > To: Shradha Todi ; lpieralisi=40kernel.org; > kw=40linux.com; robh=40kernel.org; bhelgaas=40google.com; > krzysztof.kozlowski+dt=40linaro.org; alim.akhtar=40samsung.com; > jingoohan1=40gmail.com; Sergey.Semin=40baikalelectronics.ru; > lukas.bulwahn=40gmail.com; hongxing.zhu=40nxp.com; tglx=40linutronix.de; > m.szyprowski=40samsung.com; jh80.chung=40samsung.co; > pankaj.dubey=40samsung.com > Cc: linux-pci=40vger.kernel.org; devicetree=40vger.kernel.org; linux-arm- > kernel=40lists.infradead.org; linux-samsung-soc=40vger.kernel.org; linux- > kernel=40vger.kernel.org > Subject: Re: =5BPATCH 08/16=5D PCI: samsung: Rename exynos_pcie to > samsung_pcie >=20 > On 14/02/2023 13:13, Shradha Todi wrote: > > The platform specific structure being used is named exynos_pcie. > > Changing it to samsung_pcie for making it generic. > > > > Suggested-by: Pankaj Dubey > > Signed-off-by: Shradha Todi > > --- > > drivers/pci/controller/dwc/pci-samsung.c =7C 190 > > +++++++++++------------ > > 1 file changed, 95 insertions(+), 95 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-samsung.c > > b/drivers/pci/controller/dwc/pci-samsung.c > > index d5adf1017a05..be0177fcd763 100644 > > --- a/drivers/pci/controller/dwc/pci-samsung.c > > +++ b/drivers/pci/controller/dwc/pci-samsung.c > > =40=40 -23,7 +23,7 =40=40 > > > > =23include =22pcie-designware.h=22 > > > > -=23define to_exynos_pcie(x) dev_get_drvdata((x)->dev) > > +=23define to_samsung_pcie(x) dev_get_drvdata((x)->dev) > > > > /* PCIe APPL registers */ > > =23define EXYNOS_PCIE_IRQ_PULSE 0x000 > > =40=40 -51,7 +51,7 =40=40 > > =23define EXYNOS_PCIE_APPL_SLV_ARMISC 0x120 > > =23define EXYNOS_PCIE_APPL_SLV_DBI_ENABLE BIT(21) > > > > -struct exynos_pcie =7B > > +struct samsung_pcie =7B >=20 > No, I don't see benefit of this at all. How we call stuff inside driver i= s not related > whether this is for Tesla or Exynos. We could even call it =22pony=22. :)= Thus > renamings just to support new variant of Samsung device is not a good rea= son. >=20 Whole intention of this whole series was to make exynos-pcie driver to supp= ort for all Samsung manufactured SoCs be it Exynos series or custom ASIC su= ch as fsd, artpect-v8.=20 While doing so, we feel for better readability and conveying better names f= or files, structs, internal APIs will help developers for understanding and= reusing it. For example we know that clock initialization will remain comm= on (thanks for bulk_clk_xxx APIs) so we kept APIs for handling clocks start= ing with samsung_clk_xxxx, but if we have to implement two variant of APIs,= or struct targeting different platforms it would be good if they have plat= form specific prefixes. This will help in grep or future code maintenance.= =20 Though technically all these can be done even without renaming, but if we s= ee no impact as such, so why not use better names? > Unless all of the old =22exynos=22 names will be soon needed for some exy= nos- > specific variants? >=20 No we don't have any such plans. > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC008C6FA8E for ; Thu, 2 Mar 2023 12:33:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:MIME-Version:Message-ID:Date :Subject:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wxWueTsXwC4aqDWT+nLcYAWraraF2IwR0ZH+tecUpWI=; b=Wu25zFB2GFfo6T NjHdpFSPXg+OJGTqfYhjr5Nc3ILR0vsEZhX0sD0GGERwBNHp2ZNIjXih9o5MVeGwi8dhTDUZkPVTa fzpHZ6XDbQYKP1cgcJ5QGj5j2CRoT+a9boOtRSiBN0+tgsiujNZeIXfbGRC+uViC8weQq7eJuRror 3RRtpawGCKBQlVGxHHRJYcIaJdJEzWbdjjrsWIyzmZbkaWrbQS0jz1nRIBFpuzFoam+9yOOsadIJa KTC6JUZBOZlWVWPelCiuvNAeyS+px7k8xBPr+MI9vdxIAgpHiQeqIzGfnrA2nZQurpGgtcYnUrNIY scFZsV/U3Qx9C/XWEaNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXi6i-0029fC-4q; Thu, 02 Mar 2023 12:32:24 +0000 Received: from mailout2.samsung.com ([203.254.224.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXi6b-0029by-7p for linux-arm-kernel@lists.infradead.org; Thu, 02 Mar 2023 12:32:22 +0000 Received: from epcas5p1.samsung.com (unknown [182.195.41.39]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20230302123209epoutp02171b2362b780eff9495f4ef7d3db1a28~ImiFj7mp01525115251epoutp02I for ; Thu, 2 Mar 2023 12:32:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20230302123209epoutp02171b2362b780eff9495f4ef7d3db1a28~ImiFj7mp01525115251epoutp02I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1677760329; bh=w8lus32mfN0JsldgiFkE/jaxZOJ68qTXGqyvtoCNxcQ=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=ILrvpVMk1jGLtCouwmbaSGz0PgiJH7peL4HRfpDsRvMb8MrI92E/vf3j/6i5EJ7YW qRcLv67yG4I2uXNJwB+INrihOZU3cxNTLQk547gaO6sh394k2QJlyUKHbRPRjLPAwD UoqrmFTppF7Vx9LdzBPkdNLNT5umG7ArcfrjE6uk= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas5p4.samsung.com (KnoxPortal) with ESMTP id 20230302123208epcas5p4a38a06d8833ecace1c6eb7cec280b060~ImiFGeMQN1989019890epcas5p4P; Thu, 2 Mar 2023 12:32:08 +0000 (GMT) Received: from epsmges5p1new.samsung.com (unknown [182.195.38.177]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4PS9Tg4sRVz4x9Pr; Thu, 2 Mar 2023 12:32:07 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 0A.02.10528.74790046; Thu, 2 Mar 2023 21:32:07 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20230302123207epcas5p3b89e4e110aaf44961fabed425666503c~ImiDVctGY1454014540epcas5p3V; Thu, 2 Mar 2023 12:32:07 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20230302123206epsmtrp2660aad4ee146a31982a2ecacd41652fc~ImiDUeGRw2648826488epsmtrp2B; Thu, 2 Mar 2023 12:32:06 +0000 (GMT) X-AuditID: b6c32a49-e75fa70000012920-48-64009747c4b2 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 5D.23.18071.64790046; Thu, 2 Mar 2023 21:32:06 +0900 (KST) Received: from pankajdubey02 (unknown [107.122.12.6]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20230302123202epsmtip200d1dfcf9283d65f0b5c1ec163b7fe7c~Imh-emAVy2740827408epsmtip2K; Thu, 2 Mar 2023 12:32:02 +0000 (GMT) From: "Pankaj Dubey" To: "'Krzysztof Kozlowski'" , "'Shradha Todi'" , , , , , , , , , , , , , Cc: , , , , In-Reply-To: Subject: RE: [PATCH 08/16] PCI: samsung: Rename exynos_pcie to samsung_pcie Date: Thu, 2 Mar 2023 18:02:01 +0530 Message-ID: <146301d94d03$002ba040$0082e0c0$@samsung.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHB3D0FgV9/Br8Y35oSVRdB1anKHwF30rWoAbvCRL0BoFQ7lK7vreOg Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA01TbUxbZRTm3tveFmbZXQfhHZkGb2ACE2gnLS8GcFFgl4xMki3OLGbdDb2h CP1Ib9nUudmxMjoEHKJWuoF8jM0RRCiMIB9K+LRGO3GDpQEiIJsIiCsQGCuKpWXKv+ec8zzv Oc95c/iY0IkH8jNVOkarorNJ3IfT2hsWGnHI5CUXWceC4URFKw6v5yrgF302LjS3liPQ4bRx 4JfLZTxYPDOJwa652zyoL3RyoeW3ES68234Nhz9VDOLw8zvfotCwbuBAQ38+B37VN86DG51t PLhuesSBRb3nYLPlU+ygHzVvWeVR35jHeVSlJYey1F3GqbGRTpxasNl41PQ9E0o1X/+Aalpo Q6lqvQOnilvqEGrJ8lzaMyey4hQMLWe0QYwqXS3PVGXEk4ePyl6TSaQicYQ4FsaQQSpaycST ialpEcmZ2S6bZNBpOjvHlUqjWZaMSojTqnN0TJBCzeriSUYjz9ZEayJZWsnmqDIiVYzuZbFI dEDiIp7KUhiMy6imPPCd1plqVI84/QsQbz4gosF9Wx5vEwuJDgSU/BlegPi48CIC7pQacU+w ggCT7Tv0qaJ+wMD1FLoQMNTUsBXMIqDqV6ObhRNRwPa4wl3wI7oxMPlzrTvAiAYETFcVuVne RAIwPel0d99NHAb1F0rceQ4RDG5/f9edFxCxYLQ/H/XgXcBaNs3ZxBixH9yomsM8MwWBtQc3 uJvYj0gGD0bWMA8nAPzR38fbbAyIm96g9EklxyNIBEOL17bwbjA72MLz4ECwtNDlcs134VRQ 20F50jrQWFi7RX8FdN/blPJd74eBr9ujPK18QZFzGvUoBcB4Sehh7wOrv/+4NeVeMHmxdmuL FFiz25EryPPmbcbM24yZtxkw/9+sEuHUIXsYDavMYFiJRqxizvz34elqpQVxX0F4ShsyPvEo sgdB+UgPAvgY6Sc4q/eSCwVy+t33GK1aps3JZtgeROLadgkW6J+udp2RSicTR8eKoqVSaXTs S1IxGSB4Id6aLiQyaB2TxTAaRvtUh/K9A/VoY9Vqg+7qxsf2tYYW/sgpc33+27Ps1bOHlHMK x9HURE1AyT/OsiufdF8eOFIwEUc/q5182H7emuBPDsZ14sKOWztObNioopi6nvjclcr8QkIw bHp4Plz0/hm7LxuSR/vURIyWH9kply3K8oZSakLWq+3DO41EwK6p4c7QGfh3aVxz4hv3jwdP xQzcvCDlii9V/hJm3vP6yl8S6b7RNCzkQ4VEU+twznclpfIz845VzYvKkt5cb60RGH+IMXL3 m5tIuxfh+3jHApI3FhH72VT5yRXHR8OLdHLS3tyoV0mrkg47ji7PZbTdMpQes1480LvQ/eJS Y2jy6ZMH9efeSqkrJjmsghaHY1qW/heSRlKHjgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKIsWRmVeSWpSXmKPExsWy7bCSvK7bdIYUg03njC0ezNvGZrGkKcNi /pFzrBazts1ltPj4+xyLxYovM9kt+l48ZLbY+3oru0VDz29Wi02Pr7FaXN41h83i7LzjbBYz zu9jsmj508Ji0XK0ncVi7ZG77Bb/9+xgt/gz/QOLRe/hWovNm6YyO4h4vNn0nd1j56y77B4L NpV6bFrVyeZx59oeNo93586xezy5Mp3JY/OSeo+N73YweSxq+Mjm0bdlFaPH501yATxRXDYp qTmZZalF+nYJXBknlnxiL9grWXFv2hT2BsbZol2MnBwSAiYSa461sILYQgK7GSXaJlhCxGUk Jq9ewQphC0us/PecvYuRC6jmBaPE+Z6D7CAJNgF9iXM/5rGCJEQELjBLPD93mgXEYRbYxCjx edlaZoiW14wSl57cZQJp4RSwk5j+aw9Yu7CAt8SaxolgcRYBFYmtJy6DxXkFLCVuH21ngrAF JU7OfMICYjMLaEv0PmxlhLGXLXzNDHGfgsTPp8vAbhURcJN4eu0nM0SNuMTLo0fYJzAKz0Iy ahaSUbOQjJqFpGUBI8sqRsnUguLc9NxiwwLDvNRyveLE3OLSvHS95PzcTYzglKCluYNx+6oP eocYmTgYDzFKcDArifBWNzCkCPGmJFZWpRblxxeV5qQWH2KU5mBREue90HUyXkggPbEkNTs1 tSC1CCbLxMEp1cC0wqrYWT3O/PvV9OYtRzyFBfVq+BpXH7wYomm/5s9W5ghRz9WJxxgUNTZ+ uLqtw3yd8cOHr++t/PwlpXjzH83Nb3k+8nsJxwv+5+Xbl5/3WZZP7/lTZvGUfFsbu/9NQq2J 5y5YfRdR7BQ7mB3oUd/1Z83eXes0Fl/rDIvbFsCeNlOwLNCVOU60cKGz7af+W5ddFvxnXLO2 IeeYoVql5+di086S3S03jrC+0JVNXbN4723L5h95iYab7Hhe8LAq8JU3Kt/7Ozm8c1vCchmZ LS2fI5SSDvz5t8puQ8T19yHhv7cdn/y3QWlr8s58ftElU57fs7T/oTUl00Ht5rz9LpMdTdyD U89O59m9c+2/WylKLMUZiYZazEXFiQBcTG9SeAMAAA== X-CMS-MailID: 20230302123207epcas5p3b89e4e110aaf44961fabed425666503c X-Msg-Generator: CA CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230214121436epcas5p1641de02220bea5edb23bc875b6311270 References: <20230214121333.1837-1-shradha.t@samsung.com> <20230214121333.1837-9-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230302_043217_646629_3F7AF1F7 X-CRM114-Status: GOOD ( 26.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > -----Original Message----- > From: Krzysztof Kozlowski > Sent: Thursday, February 16, 2023 4:37 PM > To: Shradha Todi ; lpieralisi@kernel.org; > kw@linux.com; robh@kernel.org; bhelgaas@google.com; > krzysztof.kozlowski+dt@linaro.org; alim.akhtar@samsung.com; > jingoohan1@gmail.com; Sergey.Semin@baikalelectronics.ru; > lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; tglx@linutronix.de; > m.szyprowski@samsung.com; jh80.chung@samsung.co; > pankaj.dubey@samsung.com > Cc: linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 08/16] PCI: samsung: Rename exynos_pcie to > samsung_pcie > > On 14/02/2023 13:13, Shradha Todi wrote: > > The platform specific structure being used is named exynos_pcie. > > Changing it to samsung_pcie for making it generic. > > > > Suggested-by: Pankaj Dubey > > Signed-off-by: Shradha Todi > > --- > > drivers/pci/controller/dwc/pci-samsung.c | 190 > > +++++++++++------------ > > 1 file changed, 95 insertions(+), 95 deletions(-) > > > > diff --git a/drivers/pci/controller/dwc/pci-samsung.c > > b/drivers/pci/controller/dwc/pci-samsung.c > > index d5adf1017a05..be0177fcd763 100644 > > --- a/drivers/pci/controller/dwc/pci-samsung.c > > +++ b/drivers/pci/controller/dwc/pci-samsung.c > > @@ -23,7 +23,7 @@ > > > > #include "pcie-designware.h" > > > > -#define to_exynos_pcie(x) dev_get_drvdata((x)->dev) > > +#define to_samsung_pcie(x) dev_get_drvdata((x)->dev) > > > > /* PCIe APPL registers */ > > #define EXYNOS_PCIE_IRQ_PULSE 0x000 > > @@ -51,7 +51,7 @@ > > #define EXYNOS_PCIE_APPL_SLV_ARMISC 0x120 > > #define EXYNOS_PCIE_APPL_SLV_DBI_ENABLE BIT(21) > > > > -struct exynos_pcie { > > +struct samsung_pcie { > > No, I don't see benefit of this at all. How we call stuff inside driver is not related > whether this is for Tesla or Exynos. We could even call it "pony". :) Thus > renamings just to support new variant of Samsung device is not a good reason. > Whole intention of this whole series was to make exynos-pcie driver to support for all Samsung manufactured SoCs be it Exynos series or custom ASIC such as fsd, artpect-v8. While doing so, we feel for better readability and conveying better names for files, structs, internal APIs will help developers for understanding and reusing it. For example we know that clock initialization will remain common (thanks for bulk_clk_xxx APIs) so we kept APIs for handling clocks starting with samsung_clk_xxxx, but if we have to implement two variant of APIs, or struct targeting different platforms it would be good if they have platform specific prefixes. This will help in grep or future code maintenance. Though technically all these can be done even without renaming, but if we see no impact as such, so why not use better names? > Unless all of the old "exynos" names will be soon needed for some exynos- > specific variants? > No we don't have any such plans. > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel