diff for duplicates of <1463024360.16747.4.camel@plaes.org> diff --git a/a/1.txt b/N1/1.txt index e062d95..c0152d8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -23,11 +23,11 @@ On Wed, 2016-05-11 at 15:15 -0700, Stephen Boyd wrote: > > > @@ -107,7 +107,7 @@ static int > > > sun4i_a10_display_reset_xlate(struct > > > reset_controller_dev *rcdev, -> > > static void __init sun4i_a10_display_init(struct device_node +> > > ?static void __init sun4i_a10_display_init(struct device_node > > > *node, -> > > const struct +> > > ? ??const struct > > > sun4i_a10_display_clk_data *data) -> > > { +> > > ?{ > > > - const char *parents[data->parents]; > > > + const char *parents[4]; > > This change breaks at least de_[bf]e clocks which have 3 clock @@ -36,16 +36,16 @@ On Wed, 2016-05-11 at 15:15 -0700, Stephen Boyd wrote: > I just used the largest data->parents number, which was 4. How > does that break anything? -If you look at the sun4i_a10_display_init, it contains this block: +If you look at the?sun4i_a10_display_init, it contains this block: - ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); - if (ret != ARRAY_SIZE(parents)) { - pr_err("%s: Could not retrieve the parents\n", clk_name); - goto unmap; - } +? ? ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); +????if (ret != ARRAY_SIZE(parents)) { +????????pr_err("%s: Could not retrieve the parents\n", clk_name); +????????goto unmap; +????} of_clk_parent_fill returns 3 for de_be/de_fe nodes, and ARRAY_SIZE(parents) is 4. -Päikest, +P?ikest, Priit :) diff --git a/a/content_digest b/N1/content_digest index ca9abe6..1abdd85 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,27 +6,10 @@ "ref\020160509223924.GX3492@codeaurora.org\0" "ref\01462907459.9981.0.camel@plaes.org\0" "ref\020160511221541.GG3492@codeaurora.org\0" - "From\0Priit Laes <plaes@plaes.org>\0" - "Subject\0Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" + "From\0plaes@plaes.org (Priit Laes)\0" + "Subject\0[linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver\0" "Date\0Thu, 12 May 2016 06:39:20 +0300\0" - "To\0Stephen Boyd <sboyd@codeaurora.org>\0" - "Cc\0Maxime Ripard <maxime.ripard@free-electrons.com>" - Mike Turquette <mturquette@baylibre.com> - David Airlie <airlied@linux.ie> - Chen-Yu Tsai <wens@csie.org> - Rob Herring <robh+dt@kernel.org> - Daniel Vetter <daniel@ffwll.ch> - Hans de Goede <hdegoede@redhat.com> - devicetree@vger.kernel.org - linux-clk@vger.kernel.org - linux-arm-kernel@lists.infradead.org - linux-kernel@vger.kernel.org - linux-sunxi@googlegroups.com - dri-devel@lists.freedesktop.org - Boris Brezillon <boris.brezillon@free-electrons.com> - Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - Alexander Kaplan <alex@nextthing.co> - " Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Wed, 2016-05-11 at 15:15 -0700, Stephen Boyd wrote:\n" @@ -54,11 +37,11 @@ "> > > @@ -107,7 +107,7 @@ static int\n" "> > > sun4i_a10_display_reset_xlate(struct\n" "> > > reset_controller_dev *rcdev,\n" - "> > > \302\240static void __init sun4i_a10_display_init(struct device_node\n" + "> > > ?static void __init sun4i_a10_display_init(struct device_node\n" "> > > *node,\n" - "> > > \302\240\t\t\t\t\t\302\240\302\240const struct\n" + "> > > ?\t\t\t\t\t??const struct\n" "> > > sun4i_a10_display_clk_data *data)\n" - "> > > \302\240{\n" + "> > > ?{\n" "> > > -\tconst char *parents[data->parents];\n" "> > > +\tconst char *parents[4];\n" "> > This change breaks at least de_[bf]e clocks which have 3 clock\n" @@ -67,18 +50,18 @@ "> I just used the largest data->parents number, which was 4. How\n" "> does that break anything?\n" "\n" - "If you look at the\302\240sun4i_a10_display_init, it contains this block:\n" + "If you look at the?sun4i_a10_display_init, it contains this block:\n" "\n" - "\302\240 \302\240 ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents));\n" - "\302\240\302\240\302\240\302\240if (ret != ARRAY_SIZE(parents)) {\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pr_err(\"%s: Could not retrieve the parents\\n\", clk_name);\n" - "\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240goto unmap;\n" - "\302\240\302\240\302\240\302\240}\n" + "? ? ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents));\n" + "????if (ret != ARRAY_SIZE(parents)) {\n" + "????????pr_err(\"%s: Could not retrieve the parents\\n\", clk_name);\n" + "????????goto unmap;\n" + "????}\n" "\n" "of_clk_parent_fill returns 3 for de_be/de_fe nodes, and\n" "ARRAY_SIZE(parents) is 4.\n" "\n" - "P\303\244ikest,\n" + "P?ikest,\n" Priit :) -656919e0dc7f7e4999c5784463d1eecb2d6dfbe571895851fef837605000b6a0 +5bdd9febc0e5d63b5247919c5d3a22b42e72edce214eaa9e49ed9d4f6cee38f4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.