From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] mac80211: add vht cap decode to debugfs.
Date: Thu, 12 May 2016 11:12:47 +0200 [thread overview]
Message-ID: <1463044367.13313.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1462224198-24154-1-git-send-email-greearb@candelatech.com> (sfid-20160502_232327_373056_D35C73E3)
On Mon, 2016-05-02 at 14:23 -0700, greearb@candelatech.com wrote:
>
> + PFLAG(MAX_MPDU_LENGTH_3895, "MAX-MPDU-3895");
> + PFLAG(MAX_MPDU_LENGTH_7991, "MAX-MPDU-7991");
> + PFLAG(MAX_MPDU_LENGTH_11454, "MAX-MPDU-11454");
This doesn't work as intended, please treat this two-bit field
properly.
> + PFLAG(SUPP_CHAN_WIDTH_160MHZ, "160Mhz");
> + PFLAG(SUPP_CHAN_WIDTH_160_80PLUS80MHZ, "160-
> 80+80Mhz");
Same here.
> + PFLAG(RXSTBC_1, "RXSTBC_1");
> + PFLAG(RXSTBC_2, "RXSTBC_2");
> + PFLAG(RXSTBC_3, "RXSTBC_3");
> + PFLAG(RXSTBC_4, "RXSTBC_4");
This is clearly also wrong, as you could even see in the output you
pasted into the commit log.
johannes
next prev parent reply other threads:[~2016-05-12 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 21:23 [PATCH v2] mac80211: add vht cap decode to debugfs greearb
2016-05-02 21:24 ` Johannes Berg
2016-05-12 9:12 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-05-13 18:29 greearb
2016-05-31 13:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463044367.13313.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.