From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dan.rpsys.net (5751f4a1.skybroadband.com [87.81.244.161]) by mail.openembedded.org (Postfix) with ESMTP id 7212E62137 for ; Thu, 12 May 2016 09:57:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u4C9v36J031391 for ; Thu, 12 May 2016 10:57:03 +0100 Received: from dan.rpsys.net ([127.0.0.1]) by localhost (dan.rpsys.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i4vPaLwGrdDd for ; Thu, 12 May 2016 10:57:03 +0100 (BST) Received: from hex ([192.168.3.34]) (authenticated bits=0) by dan.rpsys.net (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id u4C9uxDx031388 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 12 May 2016 10:57:00 +0100 Message-ID: <1463047019.9746.7.camel@linuxfoundation.org> From: Richard Purdie To: bitbake-devel Date: Thu, 12 May 2016 10:56:59 +0100 X-Mailer: Evolution 3.16.5-1ubuntu3.1 Mime-Version: 1.0 Subject: [PATCH] cookerdata: Fix log messages and ensure we exit X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 09:57:04 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit The string formatting wasn't correct and we should exit if we hit errors here similar to the other exception handlers. Signed-off-by: Richard Purdie diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index 50259a9..fba95af 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -192,7 +192,8 @@ def catch_parse_error(func): fn, _, _, _ = traceback.extract_tb(tb, 1)[0] if not fn.startswith(bbdir): break - parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb)) + parselog.critical("Unable to parse %s" % fn, exc_info=(exc_class, exc, tb)) + sys.exit(1) except bb.parse.ParseError as exc: parselog.critical(str(exc)) sys.exit(1)