From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 2/2] HID: multitouch: enable the Surface 3 Type Cover to report multitouch data Date: Fri, 13 May 2016 19:09:47 +0300 Message-ID: <1463155787.17131.351.camel@linux.intel.com> References: <1463062363-12405-1-git-send-email-benjamin.tissoires@redhat.com> <1463062363-12405-2-git-send-email-benjamin.tissoires@redhat.com> <1463149818.17131.349.camel@linux.intel.com> <20160513144927.GZ23234@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160513144927.GZ23234@mail.corp.redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Benjamin Tissoires Cc: Jiri Kosina , Bastien Nocera , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Fri, 2016-05-13 at 16:49 +0200, Benjamin Tissoires wrote: > On May 13 2016 or thereabouts, Andy Shevchenko wrote: > >=20 > > On Thu, 2016-05-12 at 16:12 +0200, Benjamin Tissoires wrote: > > >=20 > > > There is no reasons to filter out keyboard and consumer control > > > collections > > > in hid-multitouch. > > > With the previous hid-input fix, there is now a full support of > > > the > > > Type > > > Cover and we can remove all specific bits from hid-core and hid- > > > microsoft. > > >=20 > > > hid-multitouch will automatically set HID_QUIRK_NO_INIT_REPORTS s= o > > > we > > > can > > > also remove it from the list of ushbid quirks. > > >=20 > > > Signed-off-by: Benjamin Tissoires > > > --- > > >=20 > > > Andy, would you mind checking if this series is sufficient to > > > enable > > > the > > > TypeCover of the Surface Book? > > Tested-by: Andy Shevchenko > >=20 > > Noticed little difference that there is no event for the device > > anymore, > > just /dev/usb/hiddev0. Would it work properly under X? > Not sure what you mean. > I get 3 input nodes: > Microsoft Surface Type Cover Keyboard > Microsoft Surface Type Cover Consumer Control > Microsoft Surface Type Cover Touchpad >=20 > Each on this input device is properly assigned an event node and X > works > with them. >=20 > If there is no /dev/input/eventX created for your cover, then this is > not normal and needs to be investigated. There is no /dev/input/eventX for the touchpad.=C2=A0 It prints that input device is under /usb.../input8, but the actual nod= e I got events from is /dev/usb/hiddev0. --=20 Andy Shevchenko Intel Finland Oy