From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: linux-input@vger.kernel.org, aduggan@synaptics.com,
benjamin.tissoires@redhat.com, jkosina@suse.cz
Subject: hid-rmi: configuration automatically changed after suspend/resume
Date: Mon, 06 Jul 2015 12:20:51 +0200 [thread overview]
Message-ID: <1463383.73UKVcFjqX@xps13> (raw)
Hi,
I recently noticed that there's a minor issue with hid-rmi.c. After a
suspend/resume cycle the f11 control register is set to the default
configuration, thus undoing the changes performed on init.
I made some changes to the driver to prevent this from happening: the
configuration is saved on suspend and restored upon resume. This seemed
the simplest thing to do, but I encountered a small problem.
I'm saving and writing the whole register since the kernel can't know
what userspace tools might have done. According to a comment in the
sources, some firmwares split the control register, so blindly copying
and writing 20 sequential bytes as I'm doing could be a problem.
Is there a way to recognize those firmwares? Or even better, is there a
way to prevent the firmware from restoring the default configuration?
PS: I didn't check if the same happens with other registers, but I
suspenct it does.
Thanks,
Gabriele
next reply other threads:[~2015-07-06 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 10:20 Gabriele Mazzotta [this message]
2015-07-06 23:47 ` hid-rmi: configuration automatically changed after suspend/resume Andrew Duggan
2015-07-07 10:01 ` Gabriele Mazzotta
2015-07-07 14:45 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463383.73UKVcFjqX@xps13 \
--to=gabriele.mzt@gmail.com \
--cc=aduggan@synaptics.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.