From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3427.houston.hpe.com ([15.241.140.73]:4667 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbcEROK0 (ORCPT ); Wed, 18 May 2016 10:10:26 -0400 Message-ID: <1463580074.1575.7.camel@hpe.com> Subject: Re: [PATCH] remove unused blkdev_dax_capable() function From: Toshi Kani To: Arnd Bergmann Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com, viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 08:01:14 -0600 In-Reply-To: <3280835.MNk2ItMooy@wuerfel> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> <1462897437-16626-7-git-send-email-toshi.kani@hpe.com> <3280835.MNk2ItMooy@wuerfel> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-block-owner@vger.kernel.org List-Id: linux-block@vger.kernel.org On Wed, 2016-05-18 at 09:54 +0200, Arnd Bergmann wrote: > The change from blkdev_dax_capable() to bdev_dax_capable() removed the > only user of the former, so we now get a build warning: > > fs/block_dev.c:1244:13: error: 'blkdev_dax_capable' defined but not used > [-Werror=unused-function] >  static bool blkdev_dax_capable(struct block_device *bdev) > > This removes the now-unused function. > > Signed-off-by: Arnd Bergmann > Fixes: a8078b1fc616 ("block: Update blkdev_dax_capable() for > consistency")  : > It's not entirely from the patch description what the intention was here > in keeping two slightly different implementations of the same function > in one file, my best guess is that it was not intentional and we should > just remove this. Thanks for the build fix.  Looks like there was a conflict between 8044aae6f374 and a8078b1fc616d, which resulted this build error. Both patches moved blkdev_dax_capable() from block/ioctl.c to fs/block_dev.c. Acked-by: Toshi Kani Thanks, -Toshi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 85A1F1A1FB6 for ; Wed, 18 May 2016 07:10:31 -0700 (PDT) Message-ID: <1463580074.1575.7.camel@hpe.com> Subject: Re: [PATCH] remove unused blkdev_dax_capable() function From: Toshi Kani Date: Wed, 18 May 2016 08:01:14 -0600 In-Reply-To: <3280835.MNk2ItMooy@wuerfel> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> <1462897437-16626-7-git-send-email-toshi.kani@hpe.com> <3280835.MNk2ItMooy@wuerfel> Mime-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Arnd Bergmann Cc: hch@infradead.org, jack@suse.cz, linux-block@vger.kernel.org, linux-nvdimm@lists.01.org, david@fromorbit.com, linux-kernel@vger.kernel.org, micah.parrish@hpe.com, axboe@fb.com, adilger.kernel@dilger.ca, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, tytso@mit.edu List-ID: T24gV2VkLCAyMDE2LTA1LTE4IGF0IDA5OjU0ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOgo+ IFRoZSBjaGFuZ2UgZnJvbSBibGtkZXZfZGF4X2NhcGFibGUoKSB0byBiZGV2X2RheF9jYXBhYmxl KCkgcmVtb3ZlZCB0aGUKPiBvbmx5IHVzZXIgb2YgdGhlIGZvcm1lciwgc28gd2Ugbm93IGdldCBh IGJ1aWxkIHdhcm5pbmc6Cj4gCj4gZnMvYmxvY2tfZGV2LmM6MTI0NDoxMzogZXJyb3I6ICdibGtk ZXZfZGF4X2NhcGFibGUnIGRlZmluZWQgYnV0IG5vdCB1c2VkCj4gWy1XZXJyb3I9dW51c2VkLWZ1 bmN0aW9uXQo+IMKgc3RhdGljIGJvb2wgYmxrZGV2X2RheF9jYXBhYmxlKHN0cnVjdCBibG9ja19k ZXZpY2UgKmJkZXYpCj4gCj4gVGhpcyByZW1vdmVzIHRoZSBub3ctdW51c2VkIGZ1bmN0aW9uLgo+ IAo+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVyZ21hbm4gPGFybmRAYXJuZGIuZGU+Cj4gRml4ZXM6 IGE4MDc4YjFmYzYxNiAoImJsb2NrOiBVcGRhdGUgYmxrZGV2X2RheF9jYXBhYmxlKCkgZm9yCj4g Y29uc2lzdGVuY3kiKQrCoDoKPiBJdCdzIG5vdCBlbnRpcmVseSBmcm9tIHRoZSBwYXRjaCBkZXNj cmlwdGlvbiB3aGF0IHRoZSBpbnRlbnRpb24gd2FzIGhlcmUKPiBpbiBrZWVwaW5nIHR3byBzbGln aHRseSBkaWZmZXJlbnQgaW1wbGVtZW50YXRpb25zIG9mIHRoZSBzYW1lIGZ1bmN0aW9uCj4gaW4g b25lIGZpbGUsIG15IGJlc3QgZ3Vlc3MgaXMgdGhhdCBpdCB3YXMgbm90IGludGVudGlvbmFsIGFu ZCB3ZSBzaG91bGQKPiBqdXN0IHJlbW92ZSB0aGlzLgoKVGhhbmtzIGZvciB0aGUgYnVpbGQgZml4 LiDCoExvb2tzIGxpa2UgdGhlcmUgd2FzIGEgY29uZmxpY3QKYmV0d2VlbsKgODA0NGFhZTZmMzc0 IGFuZMKgYTgwNzhiMWZjNjE2ZCwgd2hpY2ggcmVzdWx0ZWQgdGhpcyBidWlsZCBlcnJvci4KQm90 aCBwYXRjaGVzIG1vdmVkIGJsa2Rldl9kYXhfY2FwYWJsZSgpIGZyb23CoGJsb2NrL2lvY3RsLmMK dG/CoGZzL2Jsb2NrX2Rldi5jLgoKQWNrZWQtYnk6IFRvc2hpIEthbmkgPHRvc2hpLmthbmlAaHBl LmNvbT4KClRoYW5rcywKLVRvc2hpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1tQGxpc3Rz LjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52ZGlt bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbcEROK2 (ORCPT ); Wed, 18 May 2016 10:10:28 -0400 Received: from g4t3427.houston.hpe.com ([15.241.140.73]:4667 "EHLO g4t3427.houston.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbcEROK0 (ORCPT ); Wed, 18 May 2016 10:10:26 -0400 X-Greylist: delayed 53906 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 May 2016 10:10:26 EDT Message-ID: <1463580074.1575.7.camel@hpe.com> Subject: Re: [PATCH] remove unused blkdev_dax_capable() function From: Toshi Kani To: Arnd Bergmann Cc: dan.j.williams@intel.com, jack@suse.cz, david@fromorbit.com, viro@zeniv.linux.org.uk, axboe@fb.com, hch@infradead.org, boaz@plexistor.com, tytso@mit.edu, adilger.kernel@dilger.ca, ross.zwisler@linux.intel.com, micah.parrish@hpe.com, linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 08:01:14 -0600 In-Reply-To: <3280835.MNk2ItMooy@wuerfel> References: <1462897437-16626-1-git-send-email-toshi.kani@hpe.com> <1462897437-16626-7-git-send-email-toshi.kani@hpe.com> <3280835.MNk2ItMooy@wuerfel> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-05-18 at 09:54 +0200, Arnd Bergmann wrote: > The change from blkdev_dax_capable() to bdev_dax_capable() removed the > only user of the former, so we now get a build warning: > > fs/block_dev.c:1244:13: error: 'blkdev_dax_capable' defined but not used > [-Werror=unused-function] >  static bool blkdev_dax_capable(struct block_device *bdev) > > This removes the now-unused function. > > Signed-off-by: Arnd Bergmann > Fixes: a8078b1fc616 ("block: Update blkdev_dax_capable() for > consistency")  : > It's not entirely from the patch description what the intention was here > in keeping two slightly different implementations of the same function > in one file, my best guess is that it was not intentional and we should > just remove this. Thanks for the build fix.  Looks like there was a conflict between 8044aae6f374 and a8078b1fc616d, which resulted this build error. Both patches moved blkdev_dax_capable() from block/ioctl.c to fs/block_dev.c. Acked-by: Toshi Kani Thanks, -Toshi