From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga04.intel.com ([192.55.52.120]:61162 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753286AbcEROXh (ORCPT ); Wed, 18 May 2016 10:23:37 -0400 From: "Coelho, Luciano" To: "reinoudkoornstra@gmail.com" CC: "linux-kernel@vger.kernel.org" , linuxwifi , "torvalds@linux-foundation.org" , "Berg, Johannes" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "egrumbach@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [GIT] Networking Date: Wed, 18 May 2016 14:23:31 +0000 Message-ID: <1463581411.29999.1.camel@intel.com> (sfid-20160518_162359_424681_8DFA4140) References: <20160517.151113.367799295750703003.davem@davemloft.net> <1463568714.13625.18.camel@intel.com> <1463575273.13625.23.camel@intel.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gV2VkLCAyMDE2LTA1LTE4IGF0IDA2OjUxIC0wNjAwLCBSZWlub3VkIEtvb3Juc3RyYSB3cm90 ZToNCj4gT24gV2VkLCBNYXkgMTgsIDIwMTYgYXQgNjo0MSBBTSwgQ29lbGhvLCBMdWNpYW5vDQo+ IDxsdWNpYW5vLmNvZWxob0BpbnRlbC5jb20+IHdyb3RlOg0KPiA+IA0KPiA+IE9uIFdlZCwgMjAx Ni0wNS0xOCBhdCAwNjoyMCAtMDYwMCwgUmVpbm91ZCBLb29ybnN0cmEgd3JvdGU6DQo+ID4gPiAN Cj4gPiA+IE9uIFdlZCwgTWF5IDE4LCAyMDE2IGF0IDQ6NTEgQU0sIENvZWxobywgTHVjaWFubw0K PiA+ID4gPGx1Y2lhbm8uY29lbGhvQGludGVsLmNvbT4gd3JvdGU6DQo+ID4gPiA+IA0KPiA+ID4g PiANCj4gPiA+ID4gSGkgRW1tYW51ZWwsIExpbnVzLA0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4g PiA+IE9uIFdlZCwgMjAxNi0wNS0xOCBhdCAwNjozNyArMDMwMCwgRW1tYW51ZWwgR3J1bWJhY2gg d3JvdGU6DQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4gDQo+ID4gPiA+ID4gT24gV2VkLCBNYXkgMTgs IDIwMTYgYXQgNDowMCBBTSwgTGludXMgVG9ydmFsZHMNCj4gPiA+ID4gPiA8dG9ydmFsZHNAbGlu dXgtZm91bmRhdGlvbi5vcmc+IHdyb3RlOg0KPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiANCj4g PiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gT24gVHVlLCBNYXkgMTcsIDIwMTYgYXQgMTI6MTEgUE0s IERhdmlkIE1pbGxlciA8ZGF2ZW1AZGF2ZW0NCj4gPiA+ID4gPiA+IGxvZnQNCj4gPiA+ID4gPiA+ IC5uZXQNCj4gPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiB3cm90 ZToNCj4gPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiA+IA0KPiA+ID4gPiA+ID4gPiBIaWdobGln aHRzOg0KPiA+ID4gPiA+ID4gTG93bGlnaHRzOg0KPiA+ID4gPiA+ID4gDQo+ID4gPiA+ID4gPiDC oDEpIHRoZSBpd2x3aWZpIGRyaXZlciBzZWVtcyB0byBiZSBicm9rZW4NCj4gPiA+ID4gPiA+IA0K PiA+ID4gPiA+ID4gTXkgbGFwdG9wIHRoYXQgdXNlcyB0aGUgaW50ZWwgNzY4MCBpd2x3aWZpIG1v ZHVsZSBubyBsb25nZXINCj4gPiA+ID4gPiA+IGNvbm5lY3RzDQo+ID4gPiA+ID4gPiB0byB0aGUg bmV0d29yay4gSXQgZmFpbHMgd2l0aCBhICJNaWNyb2NvZGUgU1cgZXJyb3INCj4gPiA+ID4gPiA+ IGRldGVjdGVkLiINCj4gPiA+ID4gPiA+IGFuZA0KPiA+ID4gPiA+ID4gc3Bld3Mgb3V0IHJlZ2lz dGVyIHN0YXRlIG92ZXIgYW5kIG92ZXIgYWdhaW4uDQo+ID4gPiA+ID4gQ2FuIHdlIGhhdmUgdGhl IHJlZ2lzdGVyIHN0YXRlIGFuZCB0aGUgQVNTRVJUIC8gTk1JIC8NCj4gPiA+ID4gPiB3aGF0ZXZl cg0KPiA+ID4gPiA+IHRoYXQNCj4gPiA+ID4gPiBnb2VzIGFsb25nIHdpdGggaXQ/DQo+ID4gPiA+ ID4gVGhpcyBjbGVhcmx5IG1lYW5zIHRoYXQgdGhlIGZpcm13YXJlIGlzIGNyYXNoaW5nLCBidXQg SSBkb24ndA0KPiA+ID4gPiA+IGtub3cNCj4gPiA+ID4gPiB3aHksDQo+ID4gPiA+ID4gSSBjb3Bp ZWQgaGVyZSB0aGUgbGluZXMgdGhhdCBJIG5lZWQgZnJvbSBhbm90aGVyIGJ1ZyB3aXRoDQo+ID4g PiA+ID4gYW5vdGhlcg0KPiA+ID4gPiA+IGRldmljZSB3aXRoIGFub3RoZXIgZmlybXdhcmUsDQo+ ID4gPiA+ID4gYnV0IHRoZSBsb2cgdGhhdCB3ZSB3aWxsIHN0aWxsIGV4cGxhaW4gd2hhdCBJIG5l ZWQ6DQo+ID4gPiA+IEkgbWFuYWdlZCB0byByZXByb2R1Y2UgdGhpcyBidWcgbG9jYWxseSB3aXRo IExpbnVzJw0KPiA+ID4gPiBtYXN0ZXIuwqDCoEknbQ0KPiA+ID4gPiBpbnZlc3RpZ2F0aW5nIHRo ZSBjYXVzZSBhbmQgSSdsbCBsZXQgeW91IGhvdyBpdCBnb2VzLg0KPiA+ID4gSSBkaWQgcnVuIHRo ZSBsYXRlc3QgZ2l0IGNvZGUgYXMgd2VsbCA0LjYrDQo+ID4gPiBpd2x3aWZpIHdlbnQgcGVhcnNo YXBlIGluIG15IGNhc2UgYXMgd2VsbC4NCj4gPiA+IEkganVzdCB1cGRhdGVkIHRoZSBtaWNyb2Nv ZGUgYXMgd2VsbCwgaXQgZGlkbid0IG1hdHRlci4NCj4gPiA+IDQuNi1yYzcgd29ya3MgZmluZSBh bmQgbm8gZXJyb3JzIGFyZSByZXBvcnRlZCB3aXRoIGl3bHdpZmkuDQo+ID4gPiANCj4gPiA+IEhl cmUncyBvdXRwdXQgdGhhdCBtaWdodCBjb21lIGluIGhhbmR5DQo+ID4gVGhhbmtzISBUaGF0IGlz IGhlbHBmdWwuDQo+ID4gDQo+ID4gU2luY2UgeW91IHNheSB0aGF0IDQuNi1yYzcgd29ya3MgYnV0 IDQuNiBkb2Vzbid0LCB0aGUgcHJpbWUgc3VzcGVjdA0KPiA+IGlzDQo+ID4gY29tbWl0IDVjMDhi MGY1MDI2ZiAoIml3bHdpZmk6IG12bTogZG9uJ3Qgb3ZlcnJpZGUgdGhlIHJhdGUgd2l0aA0KPiA+ IHRoZQ0KPiA+IEFNU0RVIGxlbiIpLCB3aGljaCBpcyB0aGUgb25seSBpd2x3aWZpIHBhdGNoIGJl dHdlZW4gdGhvc2UgdHdvDQo+ID4gcmVsZWFzZXMuDQo+ID4gDQo+ID4gQ291bGQgeW91IHRyeSB0 byByZXZlcnQgdGhhdCBhbmQgc2VlIGlmIHRoZSBlcnJvciBpcyBnb25lPw0KPiBXaWxsIGRvLCBz aW5jZSBnaXQgcmV2ZXJ0IGZhaWxlZCBJJ2xsIHJldmVydCBtYW51YWxseSBhbmQgcmVwb3J0DQo+ IGJhY2suDQoNCkkgY2FuIGNvbmZpcm0gdGhhdCA0LjYgY29udGFpbnMgdGhlIHNhbWUgYnVnLiDC oEFuZCByZXZlcnRpbmcgdGhlIHBhdGNoDQpJIG1lbnRpb25lZCBkb2VzIHNvbHZlIHRoZSBwcm9i bGVtLi4uDQoNClRoZSBzYW1lIHBhdGNoIHdvcmtzIGZpbmUgaW4gb3VyIGludGVybmFsIHRyZWUu IMKgSSdsbCBoYXZlIHRvIGZpZ3VyZQ0Kb3V0IHRvZ2V0aGVyIHdpdGggRW1tYW51ZWwgd2hhdCB0 aGUgcHJvYmxlbSBhY3R1YWxseSBpcy4NCg0KLS0NCkx1Y2Eu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932479AbcEROXi (ORCPT ); Wed, 18 May 2016 10:23:38 -0400 Received: from mga04.intel.com ([192.55.52.120]:61162 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753286AbcEROXh (ORCPT ); Wed, 18 May 2016 10:23:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,329,1459839600"; d="scan'208";a="957263148" From: "Coelho, Luciano" To: "reinoudkoornstra@gmail.com" CC: "linux-kernel@vger.kernel.org" , linuxwifi , "torvalds@linux-foundation.org" , "Berg, Johannes" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "egrumbach@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [GIT] Networking Thread-Topic: [GIT] Networking Thread-Index: AQHRsLaf8kQ/OuMXFEaLwxa9HQIEjZ++dGMAgAAYrgCAAAXdgIAAAv6AgAAZl4A= Date: Wed, 18 May 2016 14:23:31 +0000 Message-ID: <1463581411.29999.1.camel@intel.com> References: <20160517.151113.367799295750703003.davem@davemloft.net> <1463568714.13625.18.camel@intel.com> <1463575273.13625.23.camel@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.8.149] Content-Type: text/plain; charset="utf-8" Content-ID: <04A0B55698731F47A91BDBFC24C7B85B@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4IENi3q028113 On Wed, 2016-05-18 at 06:51 -0600, Reinoud Koornstra wrote: > On Wed, May 18, 2016 at 6:41 AM, Coelho, Luciano > wrote: > > > > On Wed, 2016-05-18 at 06:20 -0600, Reinoud Koornstra wrote: > > > > > > On Wed, May 18, 2016 at 4:51 AM, Coelho, Luciano > > > wrote: > > > > > > > > > > > > Hi Emmanuel, Linus, > > > > > > > > > > > > On Wed, 2016-05-18 at 06:37 +0300, Emmanuel Grumbach wrote: > > > > > > > > > > > > > > > On Wed, May 18, 2016 at 4:00 AM, Linus Torvalds > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Tue, May 17, 2016 at 12:11 PM, David Miller > > > > > loft > > > > > > .net > > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > Highlights: > > > > > > Lowlights: > > > > > > > > > > > >  1) the iwlwifi driver seems to be broken > > > > > > > > > > > > My laptop that uses the intel 7680 iwlwifi module no longer > > > > > > connects > > > > > > to the network. It fails with a "Microcode SW error > > > > > > detected." > > > > > > and > > > > > > spews out register state over and over again. > > > > > Can we have the register state and the ASSERT / NMI / > > > > > whatever > > > > > that > > > > > goes along with it? > > > > > This clearly means that the firmware is crashing, but I don't > > > > > know > > > > > why, > > > > > I copied here the lines that I need from another bug with > > > > > another > > > > > device with another firmware, > > > > > but the log that we will still explain what I need: > > > > I managed to reproduce this bug locally with Linus' > > > > master.  I'm > > > > investigating the cause and I'll let you how it goes. > > > I did run the latest git code as well 4.6+ > > > iwlwifi went pearshape in my case as well. > > > I just updated the microcode as well, it didn't matter. > > > 4.6-rc7 works fine and no errors are reported with iwlwifi. > > > > > > Here's output that might come in handy > > Thanks! That is helpful. > > > > Since you say that 4.6-rc7 works but 4.6 doesn't, the prime suspect > > is > > commit 5c08b0f5026f ("iwlwifi: mvm: don't override the rate with > > the > > AMSDU len"), which is the only iwlwifi patch between those two > > releases. > > > > Could you try to revert that and see if the error is gone? > Will do, since git revert failed I'll revert manually and report > back. I can confirm that 4.6 contains the same bug.  And reverting the patch I mentioned does solve the problem... The same patch works fine in our internal tree.  I'll have to figure out together with Emmanuel what the problem actually is. -- Luca.