From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Petros Koutoupis <petros@petroskoutoupis.com>,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org
Subject: Re: scsi_common: Modify SMR device type to reflect SCSI specification
Date: Sun, 22 May 2016 10:20:43 -0700 [thread overview]
Message-ID: <1463937643.2257.19.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1463882319.4525.3.camel@petros-ultrathin>
On Sat, 2016-05-21 at 20:58 -0500, Petros Koutoupis wrote:
> This change is purely cosmetic but we should adjust device type 0x14
> to reflect the definition given in the SCSI specification standard
> (SPC -5).
>
> Implying Direct-Access assumes that the device supports the
> traditional Direct-Access command set when Host Managed Zoned Block
> Devices support a subset of that command set with a few zone specific
> additions. Please refer to the ZBC for details.
This string is output via an sdev_printk. Technically, that makes it a
an ABI for stuff that does log parsing. It's only a weak ABI because
logs are somewhat changeable so it's not that we can't do this, but I'd
like a good reason before doing it.
Can you explain why you want do do this? ... your change log is very
vague. I think it's because you think we should more closely reflect
the language in table 148 (peripheral device type field) but that's not
very convincing because none of the rest of our definitions exactly
reflect that language either. Plus the current definition reflects how
RBC devices are presented, so it seems logical.
James
next prev parent reply other threads:[~2016-05-22 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-22 1:58 scsi_common: Modify SMR device type to reflect SCSI specification Petros Koutoupis
2016-05-22 17:20 ` James Bottomley [this message]
2016-05-22 18:11 ` Petros Koutoupis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463937643.2257.19.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=petros@petroskoutoupis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.